src/goInstallTools: report when go.toolsManagement.go is not executable

When go.toolsManagement.go is not a valid executable, we forgot to
log it. Instead, let `getGoVersion` throw an error so the later fallback
logging kicks in.

Moreover, if `go.logging.level` is error or more verbose,
record the detailed error message in the console to help debugging.

Fixes #2753

Change-Id: Icfb149779af3a1dc256cc11c931d1f29fb2b1a6a
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/501056
Reviewed-by: Suzy Mueller <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>

Author: hyangah

src/goInstallTools.ts

@@ -16,7 +16,7 @@ import { ConfigurationTarget } from 'vscode';
 import { extensionInfo, getGoConfig, getGoplsConfig } from './config';
 import { toolExecutionEnvironment, toolInstallationEnvironment } from './goEnv';
 import { addGoRuntimeBaseToPATH, clearGoRuntimeBaseFromPATH } from './goEnvironmentStatus';
-import { logVerbose } from './goLogging';
+import { logVerbose, logError } from './goLogging';
 import { GoExtensionContext } from './context';
 import { addGoStatus, initGoStatusBar, outputChannel, removeGoStatus } from './goStatus';
 import {
@@ -108,16 +108,17 @@ export async function getGoForInstall(goVersion: GoVersion, silent?: boolean): P
 	if (!configured) {
 		return goVersion;
 	}
-	if (executableFileExists(configured)) {
-		try {
-			const go = await getGoVersion(configured);
-			if (go) return go;
-		} finally {
-			if (!silent) {
-				outputChannel.appendLine(
-					`Ignoring misconfigured 'go.toolsManagement.go' (${configured}). Provide a valid Go command.`
-				);
-			}
+
+	try {
+		const go = await getGoVersion(configured);
+		if (go) return go;
+	} catch (e) {
+		logError(`getGoForInstall failed to run 'go version' with the configured go for tool install: ${e}`);
+	} finally {
+		if (!silent) {
+			outputChannel.appendLine(
+				`Ignoring misconfigured 'go.toolsManagement.go' (${configured}). Provide a valid path to the Go command.`
+			);
 		}
 	}