Skip to content

Commit 50efa73

Browse files
committed
test/integration/goDebug: modify teardown+cleanup test
dlv dap started to handle disconnect requests while debugees are running. Completely skip sending a disconnect request before disposing the debug adapter during testing. Updates #1481 Change-Id: I5f4dad864d3f28d726a64bab8dd45534c8e0d6d7 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/318789 Reviewed-by: Suzy Mueller <[email protected]> Trust: Hyang-Ah Hana Kim <[email protected]>
1 parent 8803f91 commit 50efa73

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

test/integration/goDebug.test.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1606,9 +1606,8 @@ const testAll = (ctx: Mocha.Context, isDlvDap: boolean) => {
16061606
assert.fail(`debug output ${OUTPUT} wasn't built: ${e}`);
16071607
}
16081608

1609-
// It's possible dlv-dap doesn't respond. So, don't wait.
1610-
dc.disconnectRequest({ restart: false });
1611-
await sleep(10);
1609+
// Skip the proper disconnect sequence started with a disconnect request.
1610+
16121611
dlvDapAdapter.dispose(1);
16131612
dc = undefined;
16141613
await sleep(100); // allow dlv to respond and finish cleanup.

0 commit comments

Comments
 (0)