[release] prepare v0.38.0 release

e046798 CHANGELOG: update CHANGELOG for v0.38.0 release
ab0569c .github/workflows: update to go 1.20 from 1.20rc1
54c1493 tools/installtools: remove temporary version pinning for staticcheck
98ffe1c package.json: upgrade esbuild
d28a29c go.mod: update dependencies
a0f2369 src/goTaskProvider: add default go task provider
599cc74 src/goToolsInformation: update version golangci-lint and gopls
d5633a7 src/debugAdapter: handle missing variables gracefully
d31a6c5 src/language/goLanguageServer: support staged auto-update of gopls
7c6518b .vscode/launch.json: use --profile-temp for testing with clean env
af5e63f test/gopls: reenable gopls tests
032fd59 package.json: add gopls and golang to extension keywords
203717d src/goReferencesCodelens: delete references codelens code
196bd79 src/goDeveloperSurvey: fix lint
32a643f CHANGELOG.md: prepare for v0.37.1
a736c61 docs/debugging.md: docs clarity edits
fda7f61 src/goDeveloperSurvey: prepare for 2023 Winter developer survey
8937a53 build/release-nightly: initial commit for release wf in GCB
4bd9718 package.json: include vsce to dev dependency
72095e9 docs/debbugging.md: Reformatting prep for docs edits
2535317 package.json: use @vscode/debugadapter-testsupport
28ed01d package-lock.json: update json5 to v2.2.3
ff1e8cf package.json: remove @vscode/codicons dependency
0adac37 package.json: remove unnecessary ts-loader dependency
560c8f4 test/integration: fix Go Test Runner / parseOutput test on windows
5ec591d .github/workflows: replace xvfb-action with xvfb-run
b7e2421 src/util: avoid picking a module root as an inferred gopath
ec447c2 src/goTools: require go1.18 for staticcheck v0.4.0+
7bc7c52 .github/workflows: drop go1.16, use go1.20rc1
5f9ba9a tools/installtools: install old dlv for go1.16 and 1.17
ae17d4a test/integration/install: set GOMODCACHE before go clean
233f0a2 docs/features.md: add link to inlayHints settings from features.md
399c4c5 src/goTest: do not open text document on didCreateFile
97d9b81 src/goTest: adjust file matching to handle interleaved stdout/stderr
63eef86 package.json: support running tests on darwin-arm64
fa55370 package.json: open for v0.38.0 dev

Change-Id: I01858f4ca64ba42c38ba08b63c0877220a0ff82b

Author: suzmue

.github/workflows/release-nightly.yml

@@ -29,7 +29,7 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v3
         with:
-         go-version: '1.19'
+         go-version: '1.20'
          check-latest: true
          cache: true
 
@@ -55,9 +55,7 @@ jobs:
         run: npm run unit-test
 
       - name: Run tests
-        uses: GabrielBB/xvfb-action@86d97bde4a65fe9b290c0b3fb92c2c4ed0e5302d
-        with:
-          run: npm run test
+        run: xvfb-run -a npm run test
         env:
           CODE_VERSION: 'insiders'
           VSCODEGO_BEFORE_RELEASE_TESTS: true

.github/workflows/test-long-all.yml

@@ -17,7 +17,7 @@ jobs:
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
         version: ['stable', 'insiders']
-        go: ['1.16', '1.17', '1.18', '1.19']
+        go: ['1.17', '1.18', '1.19', '1.20']
 
     steps:
       - name: Clone repository
@@ -53,10 +53,15 @@ jobs:
       - name: Run unit tests
         run: npm run unit-test
 
-      - name: Run tests
-        uses: GabrielBB/xvfb-action@86d97bde4a65fe9b290c0b3fb92c2c4ed0e5302d
-        with:
-          run: npm run test
+      - name: Run tests (Linux)
+        run: xvfb-run -a npm run test
+        if: ${{ matrix.os == 'ubuntu-latest' }}
+        env:
+          CODE_VERSION: ${{ matrix.version }}
+          VSCODEGO_BEFORE_RELEASE_TESTS: true
+      - name: Run tests (Windows/Mac)
+        run: npm run test
+        if: ${{ matrix.os != 'ubuntu-latest' }}
         env:
           CODE_VERSION: ${{ matrix.version }}
           VSCODEGO_BEFORE_RELEASE_TESTS: true

.github/workflows/test-long.yml

@@ -16,7 +16,7 @@ jobs:
       matrix:
         os: [ubuntu-latest, windows-latest] # TODO: reenable macos-latest
         version: ['stable']
-        go: ['1.16', '1.17', '1.18', '1.19']
+        go: ['1.17', '1.18', '1.19', '1.20']
 
     steps:
       - name: Clone repository
@@ -41,7 +41,6 @@ jobs:
       - name: Compile
         run: npm run vscode:prepublish
 
-      # TODO: use `go install` when we all move to 1.16+ (see build/all.bash)
       - name: Install Go tools (Modules mode)
         run: |
             go version
@@ -53,10 +52,14 @@ jobs:
       - name: Run unit tests
         run: npm run unit-test
 
-      - name: Run tests
-        uses: GabrielBB/xvfb-action@86d97bde4a65fe9b290c0b3fb92c2c4ed0e5302d
-        with:
-          run: npm run test
+      - name: Run tests (Linux)
+        run: xvfb-run -a npm run test
+        if: ${{ matrix.os == 'ubuntu-latest' }}
+        env:
+          CODE_VERSION: ${{ matrix.version }}
+      - name: Run tests (Windows/Mac)
+        run: npm run test
+        if: ${{ matrix.os != 'ubuntu-latest' }}
         env:
           CODE_VERSION: ${{ matrix.version }}
 

.github/workflows/test-smoke.yml

@@ -30,7 +30,7 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v3
         with:
-         go-version: '1.19.0'
+         go-version: '1.20'
          check-latest: true
          cache: true
 
@@ -51,10 +51,14 @@ jobs:
       - name: Run unit tests
         run: npm run unit-test
 
-      - name: Run tests
-        uses: GabrielBB/xvfb-action@86d97bde4a65fe9b290c0b3fb92c2c4ed0e5302d
-        with:
-          run: npm run test
+      - name: Run tests (Linux)
+        run: xvfb-run -a npm run test
+        if: ${{ matrix.os == 'ubuntu-latest' }}
+        env:
+          CODE_VERSION: ${{ matrix.version }}
+      - name: Run tests (Windows/Mac)
+        run: npm run test
+        if: ${{ matrix.os != 'ubuntu-latest' }}
         env:
           CODE_VERSION: ${{ matrix.version }}
 

.github/workflows/wiki.yml

@@ -35,7 +35,7 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v3
         with:
-          go-version: '1.19'
+          go-version: '1.20'
           check-latest: true
           cache: true
           cache-dependency-path: '**/go.sum'

.vscode/launch.json

@@ -52,6 +52,7 @@
 			// the workspace path should be GOPATH
 			"args": [
 				"--disable-extensions",
+				"--profile-temp",
 				"--extensionDevelopmentPath=${workspaceFolder}",
 				"--extensionTestsPath=${workspaceFolder}/out/test/integration/index",
 				"--user-data-dir=${workspaceFolder}/.user-data-dir-test",
@@ -74,6 +75,7 @@
 			// the workspace path should be GOPATH
 			"args": [
 				"--disable-extensions",
+				"--profile-temp",
 				"--extensionDevelopmentPath=${workspaceFolder}",
 				"--extensionTestsPath=${workspaceFolder}/out/test/gopls/index",
 				"--user-data-dir=${workspaceFolder}/.user-data-dir-test",

CHANGELOG.md

@@ -1,3 +1,25 @@
+## v0.38.0 - 23 Feb, 2023
+
+This release adds default `go` tasks to help build and test your Go projects.
+
+A list of all issues and changes can be found in the [v0.38.0 milestone](https://github.com/golang/vscode-go/milestone/50) and [commit history](https://github.com/golang/vscode-go/compare/v0.37.1...v0.38.0).
+
+### Changes
+- Added default go task provider ([Issue 194](https://github.com/golang/vscode-go/issues/194)) <!-- CL 467697 -->
+- Updated pinned golangci-lint version to fix memory leak issue with Go 1.20 ([Issue 2654](https://github.com/golang/vscode-go/issues/2654))
+- gopls releases will now have a staged rollout in VS Code ([CL 468497](http://go.dev/cl/468497)) <!-- CL 468497 -->
+- Added extension keywords to make this extension easier to find in the VS Code Extension Marketplace ([Issue 2657](https://github.com/golang/vscode-go/issues/2657)) <!-- CL 467698 -->
+- Deleted the broken references codelens code ([Issue 2519](https://github.com/golang/vscode-go/issues/2519)) <!-- CL 464098 -->
+- Added support to handle missing variables in legacy debug adapter gracefully ([Issue 2397](https://github.com/golang/vscode-go/issues/2397)) <!-- CL 462289 -->
+
+### Development process updates
+- Upgraded esbuild to support s390x ([Issue 2668](https://github.com/golang/vscode-go/issues/2668)) <!-- CL 469915 -->
+- Use --profile-temp for testing with clean env ([Issue 2458](https://github.com/golang/vscode-go/issues/2458)) <!-- CL 468496 -->
+
+### Thanks
+
+Thank you for your contribution, @ankon, @hyangah, @jamalc, and @suzmue!
+
 ## v0.37.1 - 17 Jan, 2023
 
 ### Fixes

build/release-nightly.yaml

@@ -0,0 +1,15 @@
+steps:
+# TODO: check build/test status
+#
+# Install dependencies
+- name: node
+  entrypoint: npm
+  args: ['ci']
+# Build .vsix
+- name: node
+  entrypoint: npm
+  args: ['run', 'package']
+artifacts:
+  objects:
+    location: 'gs://$PROJECT_ID/nightly/$BUILD_ID'
+    paths: ['*.vsix']