Skip to content

Commit 5bef85b

Browse files
vanioghyangah
authored andcommitted
extension/src/goTest.ts: fix testFunctions filter
Add conditional filtering for test functions based on provided function name in _subTestAtCursor Using functionName if it was provided as argument, otherwise find any test function containing the cursor. This change fixes a bug that previously required the cursor to be within the parent function to run subtests. Now, subtests can be executed even if the cursor is not positioned in the parent function. Change-Id: I2667acb6bd5586664ea3b306112bfd9eaa54db76 GitHub-Last-Rev: b80819a GitHub-Pull-Request: #3639 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/638755 kokoro-CI: kokoro <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Hongxiang Jiang <[email protected]> Commit-Queue: Ethan Reesor <[email protected]> Reviewed-by: Ethan Reesor <[email protected]>
1 parent 58145f9 commit 5bef85b

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

extension/src/goTest.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,9 @@ async function _subTestAtCursor(
100100
const { testFunctions, suiteToTest } = await getTestFunctionsAndTestSuite(false, goCtx, editor.document);
101101
// We use functionName if it was provided as argument
102102
// Otherwise find any test function containing the cursor.
103-
const currentTestFunctions = testFunctions.filter((func) => func.range.contains(editor.selection.start));
103+
const currentTestFunctions = args.functionName
104+
? testFunctions.filter((func) => func.name === args.functionName)
105+
: testFunctions.filter((func) => func.range.contains(editor.selection.start));
104106
const testFunctionName =
105107
args && args.functionName ? args.functionName : currentTestFunctions.map((el) => el.name)[0];
106108

0 commit comments

Comments
 (0)