src/debugAdapter: default path separator to '/'

The path separator '/' is accepted by delve for filepaths,
even on windows, but '\\' is not. Therefore we should default
to using '/'.

Updates #1497

Change-Id: If3df8e9a9f05f1b103ee1a361e353f776a057343
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/319350
Trust: Suzy Mueller <[email protected]>
Run-TryBot: Suzy Mueller <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>

Author: suzmue

src/debugAdapter/goDebug.ts

@@ -356,8 +356,8 @@ function logError(...args: any[]) {
 	logger.error(logArgsToString(args));
 }
 
-function findPathSeparator(filePath: string) {
-	return filePath.includes('/') ? '/' : '\\';
+export function findPathSeparator(filePath: string) {
+	return filePath.includes('\\') ? '\\' : '/';
 }
 
 // Comparing two different file paths while ignoring any different path separators.

test/unit/goDebug.test.ts

@@ -4,7 +4,7 @@
  *--------------------------------------------------------*/
 
 import * as assert from 'assert';
-import { normalizeSeparators } from '../../src/debugAdapter/goDebug';
+import { findPathSeparator, normalizeSeparators } from '../../src/debugAdapter/goDebug';
 
 suite('NormalizeSeparators Tests', () => {
 	test('fix separator', () => {
@@ -94,4 +94,42 @@ suite('NormalizeSeparators Tests', () => {
 			assert.strictEqual(got, tc.want);
 		}
 	});
+
+	test('find path separator', () => {
+		const tt = [
+			{
+				input: '../path/to/file',
+				want: '/'
+			},
+			{
+				input: './path/to/file',
+				want: '/'
+			},
+			{
+				input: '..\\path\\to\\file',
+				want: '\\'
+			},
+			{
+				input: '.\\path\\to\\file',
+				want: '\\'
+			},
+			{
+				input: '/path/to/../file',
+				want: '/'
+			},
+			{
+				input: 'c:\\path\\to\\..\\file',
+				want: '\\'
+			},
+			{
+				input: '',
+				want: '/'
+			}
+		];
+
+		for (const tc of tt) {
+			const got = findPathSeparator(tc.input);
+			assert.strictEqual(got, tc.want);
+		}
+	});
 });