Skip to content

Commit 64865db

Browse files
committed
extension/src/goToolsInformation: update gopls version
Gopls v0.16.1 is the latest version. $ cd extension $ go run tools/generate.go -tools And update tools/generate.go to reveal the underlying `go list` command's STDERR output to help debugging in case of failure. Change-Id: Iadc9d621482dd56f7805d7d4c668fdbcc32c6e22 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/598216 kokoro-CI: kokoro <[email protected]> Commit-Queue: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Hongxiang Jiang <[email protected]>
1 parent 61901bb commit 64865db

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

extension/src/goToolsInformation.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,10 @@ export const allToolsInformation: { [key: string]: Tool } = {
103103
description: 'Language Server from Google',
104104
usePrereleaseInPreviewMode: true,
105105
minimumGoVersion: semver.coerce('1.19'),
106-
latestVersion: semver.parse('v0.15.3'),
107-
latestVersionTimestamp: moment('2024-04-12', 'YYYY-MM-DD'),
108-
latestPrereleaseVersion: semver.parse('v0.15.3'),
109-
latestPrereleaseVersionTimestamp: moment('2024-04-12', 'YYYY-MM-DD')
106+
latestVersion: semver.parse('v0.16.1'),
107+
latestVersionTimestamp: moment('2024-07-01', 'YYYY-MM-DD'),
108+
latestPrereleaseVersion: semver.parse('v0.16.1'),
109+
latestPrereleaseVersionTimestamp: moment('2024-07-01', 'YYYY-MM-DD')
110110
},
111111
'dlv': {
112112
name: 'dlv',

extension/tools/generate.go

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ func main() {
235235
// Check for the latest gopls version.
236236
versions, err := listAllModuleVersions("golang.org/x/tools/gopls")
237237
if err != nil {
238-
log.Fatal(err)
238+
log.Fatalf("failed to list all module version: %v", err)
239239
}
240240
latestIndex := len(versions.Versions) - 1
241241
latestPre := versions.Versions[latestIndex]
@@ -250,11 +250,11 @@ func main() {
250250

251251
goplsVersion, err := listModuleVersion(fmt.Sprintf("golang.org/x/tools/gopls@%s", latest))
252252
if err != nil {
253-
log.Fatal(err)
253+
log.Fatalf("failed to list gopls latest version: %v", err)
254254
}
255255
goplsVersionPre, err := listModuleVersion(fmt.Sprintf("golang.org/x/tools/gopls@%s", latestPre))
256256
if err != nil {
257-
log.Fatal(err)
257+
log.Fatalf("failed to list gopls latest prerelease version: %v", err)
258258
}
259259

260260
allToolsFile := filepath.Join(dir, "tools", "allTools.ts.in")
@@ -274,7 +274,9 @@ func main() {
274274
}
275275

276276
func listModuleVersion(path string) (moduleVersion, error) {
277-
output, err := exec.Command("go", "list", "-m", "-json", path).Output()
277+
cmd := exec.Command("go", "list", "-m", "-json", path)
278+
cmd.Stderr = os.Stderr
279+
output, err := cmd.Output()
278280
if err != nil {
279281
return moduleVersion{}, err
280282
}
@@ -287,7 +289,9 @@ func listModuleVersion(path string) (moduleVersion, error) {
287289
}
288290

289291
func listAllModuleVersions(path string) (moduleVersion, error) {
290-
output, err := exec.Command("go", "list", "-m", "-json", "-versions", path).Output()
292+
cmd := exec.Command("go", "list", "-m", "-json", "-versions", path)
293+
cmd.Stderr = os.Stderr
294+
output, err := cmd.Output()
291295
if err != nil {
292296
return moduleVersion{}, err
293297
}

0 commit comments

Comments
 (0)