src/goInstallTools: use go install -v instead of go install -x

hyangah · hyangah · commit 6d4d3bf0ff0d · 2021-10-21T21:04:10.000Z
`go install -x` is very chatty. Node.js child process got choked with ERR_CHILD_PROCESS_STDIO_MAXBUFFER. Change-Id: I70e24348b2db40bdfc99b7328d90e2b24ee7f902 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/357612 Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Suzy Mueller <suzmue@golang.org>
diff --git a/src/goInstallTools.ts b/src/goInstallTools.ts
@@ -257,8 +257,8 @@ async function installToolWithGoInstall(goVersion: GoVersion, env: NodeJS.Dict<s
 	};
 
 	const execFile = util.promisify(cp.execFile);
-	logVerbose(`$ ${goBinary} install -x ${importPath}} (cwd: ${opts.cwd})`);
-	await execFile(goBinary, ['install', '-x', importPath], opts);
+	logVerbose(`$ ${goBinary} install -v ${importPath}} (cwd: ${opts.cwd})`);
+	await execFile(goBinary, ['install', '-v', importPath], opts);
 }
 
 async function installToolWithGoGet(

Original file line number	Diff line number	Diff line change
`@@ -257,8 +257,8 @@ async function installToolWithGoInstall(goVersion: GoVersion, env: NodeJS.Dict<s`
`257`	`257`	`};`
`258`	`258`
`259`	`259`	`const execFile = util.promisify(cp.execFile);`
`260`		- logVerbose(`$ ${goBinary} install -x ${importPath}} (cwd: ${opts.cwd})`);
`261`		`- await execFile(goBinary, ['install', '-x', importPath], opts);`
	`260`	+ logVerbose(`$ ${goBinary} install -v ${importPath}} (cwd: ${opts.cwd})`);
	`261`	`+ await execFile(goBinary, ['install', '-v', importPath], opts);`
`262`	`262`	`}`
`263`	`263`
`264`	`264`	`async function installToolWithGoGet(`