Skip to content

Commit 6e8bbba

Browse files
committed
build: run vsce package during testing
This will detect npm dependency issues that are detected during packaging. Change-Id: I7e3bbeee407b764a18e80a21999385472812cf08 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/279012 Trust: Hyang-Ah Hana Kim <[email protected]> Run-TryBot: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: kokoro <[email protected]> Reviewed-by: Suzy Mueller <[email protected]>
1 parent cf03db6 commit 6e8bbba

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

build/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ ENV PATH /workspace/vscodego/go/bin:/go/bin:/usr/local/go/bin:${PATH}
2727
ENV DEBIAN_FRONTEND noninteractive
2828

2929
RUN apt-get update && apt-get install -y libnss3 libgtk-3-dev libxss1 libasound2 xvfb libsecret-1-0
30+
RUN npm install -g vsce
3031

3132
WORKDIR /workspace
3233
ENTRYPOINT ["build/all.bash"]

build/all.bash

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@ run_test() {
5252

5353
echo "**** Run settings generator ****"
5454
go run tools/generate.go -w=false
55+
56+
echo "**** Check if vsce works ****"
57+
vsce package
5558
}
5659

5760
run_test_in_docker() {

0 commit comments

Comments
 (0)