[release] goTools: don't fail gocode installation if gocode is not already running

stamblerre · hyangah · commit 6fad3bcf18dc · 2020-07-21T20:15:17.000Z
Fixes #355 Fixes #362 Change-Id: Ifdf229ce52a6a4b1a2e4f0a28ac5596405ff4c56 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/242780 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> (cherry picked from commit db1d1b3) Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/243898 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
diff --git a/src/goTools.ts b/src/goTools.ts
@@ -194,7 +194,7 @@ export const allToolsInformation: { [key: string]: Tool } = {
 					return `Installing gocode aborted as existing process cannot be closed. Please kill the running process for gocode and try again.`;
 				}
 			} catch (err) {
-				return `Failed to close gocode process: ${err}.`;
+				// This may fail if gocode isn't already running.
 			}
 			return '';
 		},

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ export const allToolsInformation: { [key: string]: Tool } = {`
`194`	`194`	return `Installing gocode aborted as existing process cannot be closed. Please kill the running process for gocode and try again.`;
`195`	`195`	`}`
`196`	`196`	`} catch (err) {`
`197`		- return `Failed to close gocode process: ${err}.`;
	`197`	`+ // This may fail if gocode isn't already running.`
`198`	`198`	`}`
`199`	`199`	`return '';`
`200`	`200`	`},`