Skip to content

Commit 78c2fac

Browse files
committed
Revert "src/goInstallTools: show error if go.languageserver.restart fails"
This reverts commit b012df4. We are still getting errors like "rejected promise not handled within 1 second: Error: command 'go.languageserver.restart' not found" after this change. It doesn't fail the tests, but pollutes test output. Looking for a better approach. Change-Id: I93bee844ca01f5d0a533f2059eefd00ea127e971 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/418776 TryBot-Result: kokoro <[email protected]> Reviewed-by: Jamal Carvalho <[email protected]> Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
1 parent aa3de7f commit 78c2fac

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

src/goInstallTools.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -191,11 +191,7 @@ export async function installTools(
191191
failures.push({ tool, reason: failed });
192192
} else if (tool.name === 'gopls') {
193193
// Restart the language server if a new binary has been installed.
194-
try {
195-
vscode.commands.executeCommand('go.languageserver.restart', RestartReason.INSTALLATION);
196-
} catch (e) {
197-
vscode.window.showErrorMessage(`Failed to start language server: ${e}`);
198-
}
194+
vscode.commands.executeCommand('go.languageserver.restart', RestartReason.INSTALLATION);
199195
}
200196
}
201197

0 commit comments

Comments
 (0)