[release] prepare v0.40.0 release

aeae497 CHANGELOG.md: add planned release date
208fad7 test/runTest.ts: add missing space in error message
9a76f3b CHANGELOG.md: add information about debugging changes to CHANGELOG
1964a4e src/welcome,README: update welcome docs to discuss telemetry
4ea9b2d src/goToolsInformation: update 3rd party tools version
75fcc92 CHANGELOG.md: prepare for v0.40.0 release
b9a28ab src/goVulncheck: recognize the vulncheck result format (gopls v0.14+)
9c57ee2 src/goToolsInformation: clean up the tools list
053cd93 src/goToolsInformation: delete legacy tools
324992b src/goDebugConfiguration: allow buildFlags passed in array
ed3024f src/utils: move killProcess to test
a829b31 src/debugAdapter/goDebug: fix type error
2232bfa src/avlTree: delete unused utilities
62eb6fe src/commands/toggleGCDetails: remove old command 'gc_details'
eaef5b0 package.json: remove godoctor-based extract func/var commands
6b4ee4d src/goFillStruct: remove Go: Fill struct command
bf75c9f tools/installtools: use the latest dlv
a3d76a5 package.json: remove deprecated settings
5c1eda7 src/goModules: delete unused functions
340f78b src/language/legacy: delete legacy language feature providers
e8b29bc src/goEnv: apply substituteEnv to go.toolsEnvVars
c2bc62f src/goDocumentSymbols: call LSP document symbols feature directly
ab8643c test/gopls/goTest: move text explorer tests to test/gopls
dcf5ecc test/gopls/codelens: move codelense test to gopls-based test
da12e36 package.json: delete ./out/ directory with npm run clean
8411f23 package.json: allow updating hideSystemGoroutines from stack context
b28ad0f package.json: require VS Code 1.75 or newer
63d0c38 src/goMain: apply substituteEnv when reading go.goroot
a42f097 src/goTools: use [email protected] for go1.19
7e2e5ad src/goTelemetry: ask gopls to prompt for telemetry opt-in
75f9d50 package.json: sync gopls settings ([email protected])
b9cfe62 package.json: update gopls settings to match 0.14
d9015c1 src/goInstallTools: require go1.16 or newer for tools installation
b2303c5 package.json: sync settings with gopls v0.13
d5d7ff6 src/envutils.ts: substitute nested env vars in env files

Change-Id: I35876653e142965fce0adae48a9fc250bf8160a7

Author: suzmue

.github/workflows/release-nightly.yml

@@ -29,7 +29,7 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v3
         with:
-         go-version: '1.20'
+         go-version: '1.21'
          check-latest: true
          cache: true
 

.github/workflows/test-long-all.yml

@@ -17,7 +17,7 @@ jobs:
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
         version: ['stable', 'insiders']
-        go: ['1.17', '1.18', '1.19', '1.20']
+        go: ['1.18', '1.19', '1.20', '1.21']
 
     steps:
       - name: Clone repository

.github/workflows/test-long.yml

@@ -16,7 +16,7 @@ jobs:
       matrix:
         os: [ubuntu-latest, windows-latest] # TODO: reenable macos-latest
         version: ['stable']
-        go: ['1.17', '1.18', '1.19', '1.20']
+        go: ['1.18', '1.19', '1.20', '1.21']
 
     steps:
       - name: Clone repository

.github/workflows/test-smoke.yml

@@ -30,7 +30,7 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v3
         with:
-         go-version: '1.20'
+         go-version: '1.21'
          check-latest: true
          cache: true
 

.github/workflows/wiki.yml

@@ -35,7 +35,7 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v3
         with:
-          go-version: '1.20'
+          go-version: '1.21'
           check-latest: true
           cache: true
           cache-dependency-path: '**/go.sum'

CHANGELOG.md

@@ -1,3 +1,74 @@
+## v0.40.0 - 13 Nov, 2023
+
+This extension utilizes [Go Telemetry](https://telemetry.go.dev/privacy) to gather insights
+about the performance and stability of the extension and the language server it employs.
+By default, Telemetry uploading is disabled, but starting from this version,
+a small number of users will be prompted to enable it. Users can enable telemetry uploading
+by either responding to the prompt or running the following command:
+
+```
+go run golang.org/x/telemetry/cmd/gotelemetry@latest on
+```
+
+Once uploading is enabled, the data will be sent to https://telemetry.go.dev
+on a weekly basis. You can find more information about this process at
+[https://telemetry.go.dev/privacy](https://telemetry.go.dev) and in the
+[gopls v0.14 release notes(https://github.com/golang/tools/releases/tag/gopls%2Fv0.14.0).
+
+A comprehensive list of changes can be found in the complete
+[commit history](https://github.com/golang/vscode-go/compare/v0.40.0...v0.39.1).
+
+### Changes
+
+* In this release, we have removed legacy language feature providers that were supported
+by outdated tools. As a result, features such as code completion, navigation,
+documentation, diagnostics, and refactoring will only function
+when the language server (`gopls`) is enabled.
+([Issue 2799](https://github.com/golang/vscode-go/issues/2799))
+
+* The "Go: Fill struct" command has been retired. The same functionality is provided
+as a [Code Action](https://code.visualstudio.com/docs/editor/refactoring#_code-actions-quick-fixes-and-refactorings)
+for refactoring. You can refer to the screenshot for details.
+([Issue 2107](https://github.com/golang/vscode-go/issues/2107)))
+
+* The "Go: Extract to function" and "Go: Extract to variable" commands are no longer needed,
+as they have been replaced by Code Actions provided by gopls.
+([Issue 2862](https://github.com/golang/vscode-go/issues/2862))
+
+* The "buildFlags" attribute for Go launch configuration now accepts a list of strings in
+addition to a string. If using delve at v1.22.2 or newer, this list is passed directly to
+delve. This should help with bugs related to parsing the string of buildFlags, such as in
+[Issue 1831](https://github.com/golang/vscode-go/issues/1831) and
+[Issue 1027](https://github.com/golang/vscode-go/issues/1027).
+([Issue 3009](https://github.com/golang/vscode-go/issues/3009))
+
+* The "Go: Toggle Hide System Goroutines" command was added to make it easier to switch between
+showing / hiding the system goroutines in the callstack view. This command is also
+available in the callstack context menu. The default setting can also be updated by updating
+"hideSystemGoroutines" in either the launch.json or in the "go.delveConfig" setting.
+([Issue 1797](https://github.com/golang/vscode-go/issues/1797#issuecomment-1762145244))
+
+### Fixes
+
+* We have enhanced environment variable substitution. Environment variable references
+like `${env:VAR}` in the `go.toolsEnvVars` setting
+([Issue 2680](https://github.com/golang/vscode-go/issues/2680)) and the `go.goroot` setting
+([Issue 3006](https://github.com/golang/vscode-go/issues/3006)) are now correctly substituted.
+Patterns like `${VAR}` inside environment files (`go.testEnvFile`) can be used to reference
+other environment variables as well. ([Issue 1902](https://github.com/golang/vscode-go/issues/1902))
+
+### Compatibilities
+
+* This extension version requires VS Code 1.75 (January 2023 version) or newer.
+The README.md provides a list of VS Code and Go version requirements.
+* For tools installation managed by the extension, you need go1.18 or a newer version.
+([Issue 2898](golang/vscode-go#2898))
+* The extension has been tested with gopls v0.14 and delve v0.21.
+
+### Thanks
+
+Thank you for your contribution @n1lesh, @suzmue, @hyangah!
+
 ## v0.39.1 - 17 Jul, 2023
 
 This is a point release to update the link for the upcoming Go developer survey.

README.md

@@ -6,25 +6,20 @@
 
 [The VS Code Go extension](https://marketplace.visualstudio.com/items?itemName=golang.go)
 provides rich language support for the
-[Go programming language](https://golang.org/).
+[Go programming language](https://go.dev/).
 
-📣
-[Remote attach debugging](https://github.com/golang/vscode-go/wiki/debugging#connecting-to-headless-delve-with-target-specified-at-server-start-up) is now available via Delve's native DAP implementation with Delve v1.7.3 or newer. It enchances remote debugging with the same
-[debugging features](https://github.com/golang/vscode-go/wiki/debugging) that are already in use for local debugging. It is now the default with the
-[Go Nightly](https://github.com/golang/vscode-go/wiki/nightly) build of the extension and will become the default for the stable releases in mid 2022.
-We recommend switching your remote attach configurations in `launch.json` to use
-`"debugAdapter":"dlv-dap"` now to verify that this works for you.
-Please [file a new issue](https://github.com/golang/vscode-go/issues/new/choose) if you encounter any problems.
+## Requirements
 
-📣📣 Watch [Debugging Treasure Hunt](https://youtu.be/ZPIPPRjwg7Q) from [GopherCon 2021](https://www.gophercon.com/) for a fun take on a debugging demo with VS Code Go and Delve DAP.
+* Visual Studio Code 1.75 or newer (or editors compatible with VS Code 1.75+ APIs)
+* Go 1.18 or newer
 
 ## Quick Start
 
 Welcome! 👋🏻<br/>
 Whether you are new to Go or an experienced Go developer, we hope this
 extension fits your needs and enhances your development experience.
 
-1.  Install [Go](https://golang.org) 1.14 or newer if you haven't already.
+1.  Install [Go](https://go.dev) 1.18 or newer if you haven't already.
 
 1.  Install the [VS Code Go extension].
 
@@ -139,6 +134,50 @@ If you'd like to get early access to new features and bug fixes, you can use the
 nightly build of this extension. Learn how to install it in by reading the
 [Go Nightly documentation](https://github.com/golang/vscode-go/wiki/nightly).
 
+## Telemetry
+
+VS Code Go extension relies on the [Go Telemetry](https://telemetry.go.dev) to
+learn insights about the performance and stability of the extension and the
+language server (`gopls``).
+**Go Telemetry data uploading is disabled by default** and can be enabled
+with the following command:
+
+```
+go run golang.org/x/telemetry/cmd/gotelemetry@latest on
+```
+
+After telemetry is enabled, the language server will upload metrics and stack
+traces to [telemetry.go.dev](https://telemetry.go.dev). You can inspect what
+data is collected and can be uploaded by running:
+
+```
+go run golang.org/x/telemetry/cmdgotelemetry@latest view
+```
+
+If we get enough adoption, this data can significantly advance the pace of
+the Go extension development, and help us meet a higher standard
+of reliability. For example:
+
+- Even with [semi-automated crash
+  reports](https://github.com/golang/vscode-go/issues?q=is%3Aissue+is%3Aopen+label%3AautomatedReport)
+  in VS Code, we've seen several crashers go unreported for weeks or months.
+- Even with [a suite of
+  benchmarks](https://perf.golang.org/dashboard/?benchmark=all&repository=tools&branch=release-branch.go1.20),
+  some performance regressions don't show up in our benchmark environment (such
+  as the [completion bug](https://go.dev/issue/62665) mentioned below!).
+- Even with [lots of great
+  ideas](https://github.com/golang/go/issues?q=is%3Aissue+is%3Aopen+label%3Agopls+label%3Afeaturerequest)
+  for how to improve gopls, we have limited resources. Telemetry can help us
+  identify which new features are most important, and which existing features
+  aren't being used or aren't working well.
+
+These are just a few ways that telemetry can improve gopls. The [telemetry blog
+post series](https://research.swtch.com/telemetry-uses) contains many more.
+
+Go telemetry is designed to be transparent and privacy-preserving. If you have
+concerns about enabling telemetry, you can learn more at
+[https://telemetry.go.dev/privacy](https://telemetry.go.dev/privacy).
+
 ## Contributing
 
 We welcome your contributions and thank you for working to improve the Go

docs/Home.md

@@ -1,14 +1,5 @@
 Welcome to the VSCode Go Wiki!
 
-### 📣 News and Upcoming Changes
-
-[Remote attach debugging](./debugging#connecting-to-headless-delve-with-target-specified-at-server-start-up) is now available via Delve's native DAP implementation with Delve v1.7.3 or newer.
-We plan to enable this as the default in 2022 H1 to enhance remote debugging with the same
-[debugging features](./debugging.md) that are already in use for local debugging.
-We recommend switching your remote attach configurations in `launch.json` to use
-`"debugAdapter":"dlv-dap"` now to verify that this works for you.
-Please [file a new issue](https://github.com/golang/vscode-go/issues/new/choose) if you encounter any problems.
-
 ### User Documentation
 
 * [Overview of Extension Features](features.md)

docs/commands.md

@@ -67,6 +67,10 @@ Runs all unit tests in the current file.
 
 Runs all unit tests in the package of the current file.
 
+### `Go: Toggle Hide System Goroutines`
+
+Toggles hiding the system goroutines from the active debug session call stack view.
+
 ### `Go Test: Refresh`
 
 Refresh a test in the test explorer. Only available as a context menu option in the test explorer.
@@ -171,10 +175,6 @@ Add tags configured in go.addTags setting to selected struct using gomodifytags
 
 Remove tags configured in go.removeTags setting from selected struct using gomodifytags
 
-### `Go: Fill struct`
-
-Fill a struct literal with default values
-
 ### `Go: Show All Commands...`
 
 Shows all commands from the Go extension in the quick pick
@@ -231,14 +231,6 @@ Cancels running tests.
 
 Applies existing cover profile.
 
-### `Go: Extract to function`
-
-Extract to function using godoctor.
-
-### `Go: Extract to variable`
-
-Extract to variable using godoctor.
-
 ### `Go: Restart Language Server`
 
 Restart the running instance of the language server

docs/debugging.md

@@ -444,7 +444,7 @@ Here is the list of attributes specific to Go debugging.
 | `args` | Command line arguments passed to the debugged program.<br/>(Default: `[]`)<br/> | <center>_n/a_</center> |
 | `asRoot` | (Experimental) Debug with elevated permissions (on Unix). It requires `integrated` or `external` console modes and is ignored in remote debugging.<br/>(Default: `false`)<br/> | (Experimental) Debug with elevated permissions (on Unix). This requires `integrated` or `external` console modes and is ignored in remote debugging.<br/>(Default: `false`)<br/> |
 | `backend` | Backend used by delve. Maps to `dlv`'s `--backend` flag.<br/><p>Allowed Values: `"default"`, `"native"`, `"lldb"`, `"rr"`<br/> | <center>_same as Launch_</center>|
-| `buildFlags` | Build flags, to be passed to the Go compiler. Maps to dlv's `--build-flags` flag.<br/>(Default: `""`)<br/> | <center>_n/a_</center> |
+| `buildFlags` | Build flags, to be passed to the Go compiler. Maps to dlv's `--build-flags` flag.<br/>(Default: `[]`)<br/> | <center>_n/a_</center> |
 | `console` | (Experimental) Where to launch the debugger and the debug target: internal console, integrated terminal, or external terminal. It is ignored in remote debugging.<br/><p>Allowed Values: `"internalConsole"`, `"integratedTerminal"`, `"externalTerminal"`<br/>(Default: `internalConsole`)<br/> | (Experimental) Where to launch the debugger: internal console, integrated terminal, or external terminal. This does not affect tty of the running program. It is ignored in remote debugging.<br/><p>Allowed Values: `"internalConsole"`, `"integratedTerminal"`, `"externalTerminal"`<br/>(Default: `internalConsole`)<br/> |
 | `coreFilePath` | Path to the core dump file to open. For use on 'core' mode only<br/>(Default: `""`)<br/> | <center>_n/a_</center> |
 | `cwd` | Workspace relative or absolute path to the working directory of the program being debugged if a non-empty value is specified. The `program` folder is used as the working directory if `cwd` is omitted or empty.<br/>(Default: `""`)<br/> | Workspace relative or absolute path to the working directory of the program being debugged. Default is the current workspace.<br/>(Default: `"${workspaceFolder}"`)<br/> |