Skip to content

Commit 89a1ca0

Browse files
hyangahhyangah
committed
[release] prepare v0.23.0 release
8da2809 utils/pathUtils: add the new installation paths for windows cbb1479 src/goModules: check goVersion isn't null before using it 6c0bda2 package.json: configure the debug adapter from launch.json 481ae47 test/integration/goDebug.test.ts: include reasons for cwd test fail d96dc45 test/integration/goDebug.test.ts: fix local variable assertion 7f1e239 build/all.bash: use delve at master for ci 516bf10 .github/workflows: use delve at master 7dd7f7a src/goLanguageServer: remove go-langserver deprecation warning 8f31447 test/integration/goDebug.test.ts: run existing debug tests on dlv dap 66e03b8 src/pickProcess: fix regexp to detect go versions with no patch version 7fcd3d2 eslint: Fix some eslint warnings 54602c5 src/debugAdapter: disable stackTrace error pop-ups 8272510 package.json: update logOutput documentation in launch config 5e19b9d .github/workflows: update go, node versions 30b086f src/goMain: use lint tool's name as the lint diagnostic collection name e760407 src/goDebugConfiguration.ts: remove gcflags using regexp 150a6d3 package-lock.json: update gts/prettier locked versions 8c699ae build: run with a different version of go 526ef89 .github/workflows: remove macos-latest from test-long.yml 4a719c8 CHANGELOG.md: sync CHANGELOG.md with the one in the release branch 49d737e package.json: change version to v0.23.0-dev f7b122c docs/advanced: add info about format/import 74e266b eslint: reformat files in src with gts fix and eslint comments 289e788 docs/debugging.md: update documentation for processId c7086f8 src/goDebugFactory.ts: remove the "godlvdap" debug type 84a6b61 package.json: add disableConcurrentTests setting 4ef4f53 eslint: Change test files so eslint does not complain d0777c4 .github/workflows: allow to run Long Tests outside the official repo e8a2ba3 .github/workflows: add go1.16 test to Long Tests 64f7875 test/integration: use module mode for testing ab62b6c test/testdata: add missing go.mod file for cwdTest 9233ebf .github/workflows: install gocode-gomod 02b5116 build/all.bash: install gocode-gomode 0dc8517 goLanguageServer: prompt user to fill out survey when they disable gopls 1a9e669 Revert ".github/workflows: run Long Tests with go1.16 rc1" 32a9f15 .github/workflows: run Long Tests with go1.16 rc1 95dc50c goLanguageServer: add logic to prompt users to opt back into gopls 48c4af1 src/pickProcess.ts: add attach by process name command 3ef8679 third_party/tree-kill: remove dependency on mocha 3525068 src/pickProcess.ts: use lsof to find process exes on darwin 3fa9b0f src/debugAdapter2: remove thin adapter for dlv-dap 0c6dce4 goLanguageServer: add special handling for incorrect flags 6a14cd3 package-lock.json: update package-lock.json to lockfile version 2 2e2c885 test: use CODE_VERSION for testing 7452751 test/runTest: add --force-disable-user-env df853b9 src/goDebugFactory.ts: run dlv-dap as a server and connect as server 555b11b docs: fix broken links feee65b src/goMain: fix the exception caused by invalid version string df04ba2 test/runTest: use vscode 1.52.1 6c94bb8 src/goDebugConfiguration.ts: invoke pick process for local attach f2fcdb1 src/goMain: correct showGoWelcomePage hard-coded version string eb53a53 package.json: fix typos ab0629e src/goLanguageServer: add platfom info in the automated issue report 2c40d20 goLanguageServer: disable the language server with SSH URIs 6841fe0 src/goMain: use a hard-coded version string for welcome page state 306da34 src/goLanguageServer: use isInPreviewMode to enable experiments cf5ff5f docs/settings.md: replace the old gopls doc link with the new one 1ad5c33 src/goLanguageServer: protect language restart with mutex 30b7367 package-lock.json: update ini 55b2284 src/goLanguageServer: block until the language client is ready 3c08fec package.json: add dlv to alternateTools value list 05251dd README.md: add the new video material 46a15da src/utils/wmicProcessParser.ts: get exe path from wmic aa02c3f src/pickProcess.ts: add linux cmd for go process cfc3d4f src/goMain: linkify documentLink deprecation warning message 5d48c07 goLanguageServer: add extra information to automated error reports aac9542 goLanguageServer: add an opt-in "always update" setting for gopls 17e80f5 src/pickProcess.ts: fix platform process commands db2234c src/stateUtils.ts: add command to reset memento state 4d6ed04 src/pickProcess.ts: add pick process command for local attach ad3a7d2 build: run docker with SYS_PTRACE capability 1534912 src/goDebug: check if delve exited before attempting to get state 5f88d61 docs: delete broken links about auto formatting 63d2287 src/welcome: correct link to Gophers Slack 9a4ca54 src/goLanguageServer.ts: fix suggestUpdateGopls documentation 76ce9ba docs: minor updates of features.md and troubleshooting.md Change-Id: Id7dfedf1bc1be02f5418e9064d1fbf4a4a502a80
2 parents e365097 + 8da2809 commit 89a1ca0

File tree

119 files changed

+22263
-8644
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

119 files changed

+22263
-8644
lines changed

‎.eslintignore‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
build/
2+
node_modules/

‎.eslintrc.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"extends": "./node_modules/gts/",
3+
"root": true
4+
}

‎.github/workflows/release-nightly.yml‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
- name: Setup Node
2525
uses: actions/setup-node@v1
2626
with:
27-
node-version: '10.x'
27+
node-version: '14.x'
2828

2929
- name: Setup Go
3030
uses: actions/setup-go@v2
@@ -48,7 +48,12 @@ jobs:
4848
go get github.com/acroca/go-symbols
4949
go get github.com/davidrjenni/reftools/cmd/fillstruct
5050
go get github.com/haya14busa/goplay/cmd/goplay
51+
52+
# Install two versions of gocode (one as gocode-gomod)
53+
go get github.com/stamblerre/gocode
54+
mv "${HOME}/go/bin/gocode${{env.EXT}}" "${HOME}/go/bin/gocode-gomod${{env.EXT}}"
5155
go get github.com/mdempsky/gocode
56+
5257
go get github.com/sqs/goreturns
5358
go get github.com/uudashr/gopkgs/v2/cmd/gopkgs
5459
go get github.com/zmb3/gogetdoc
@@ -58,9 +63,10 @@ jobs:
5863
go get github.com/cweill/gotests/...
5964
go get github.com/rogpeppe/godef
6065
go get github.com/ramya-rao-a/go-outline
61-
go get github.com/go-delve/delve/cmd/dlv
66+
go get github.com/go-delve/delve/cmd/dlv@master
6267
env:
63-
GO111MODULE: on
68+
GO111MODULE: on
69+
EXT: "${{ matrix.os == 'windows-latest' && '.exe' || ''}}"
6470

6571
- name: Run unit tests
6672
run: npm run unit-test

‎.github/workflows/release.yml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,5 +108,4 @@ jobs:
108108
env:
109109
VSCE_TOKEN: ${{ secrets.VSCE_TOKEN }}
110110

111-
# TODO: check if the commit is in green state. (test-long.yml results)
112-
# TODO: after publishing, create a gerrit CL to update 'latest' branch if VERSION is for a stable version.
111+
# TODO: check if the commit is in green state. (test-long.yml results)

‎.github/workflows/test-long-all.yml‎

Lines changed: 80 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
1+
name: Daily Build Status
2+
3+
on:
4+
schedule:
5+
- cron: "0 11 * * *" # 11 UTC, everyday
6+
7+
jobs:
8+
build:
9+
name: ${{ matrix.os }} ${{ matrix.version }} ${{ matrix.go }}
10+
runs-on: ${{ matrix.os }}
11+
12+
# Only in the official repository.
13+
if: github.repository == 'golang/vscode-go'
14+
timeout-minutes: 20
15+
strategy:
16+
fail-fast: false
17+
matrix:
18+
os: [ubuntu-latest, windows-latest, macos-latest]
19+
version: ['stable', 'insiders']
20+
go: ['1.15', '1.16']
21+
22+
steps:
23+
- name: Clone repository
24+
uses: actions/checkout@v2
25+
26+
- name: Setup Node
27+
uses: actions/setup-node@v1
28+
with:
29+
node-version: '14.x'
30+
31+
- name: Setup Go
32+
uses: actions/setup-go@v2
33+
with:
34+
go-version: ${{ matrix.go }}
35+
stable: '!contains(${{ matrix.go }}, "beta") && !contains(${{ matrix.go }}, "rc")'
36+
37+
- name: Install dependencies
38+
run: npm ci
39+
40+
- name: Compile
41+
run: npm run vscode:prepublish
42+
43+
- name: Install Go tools (Modules mode)
44+
run: |
45+
go version
46+
go get github.com/acroca/go-symbols
47+
go get github.com/davidrjenni/reftools/cmd/fillstruct
48+
go get github.com/haya14busa/goplay/cmd/goplay
49+
# Install two versions of gocode (one as gocode-gomod)
50+
go get github.com/stamblerre/gocode
51+
mv "${HOME}/go/bin/gocode${{env.EXT}}" "${HOME}/go/bin/gocode-gomod${{env.EXT}}"
52+
go get github.com/mdempsky/gocode
53+
go get github.com/sqs/goreturns
54+
go get github.com/uudashr/gopkgs/v2/cmd/gopkgs
55+
go get github.com/zmb3/gogetdoc
56+
go get golang.org/x/lint/golint
57+
go get golang.org/x/tools/cmd/gorename
58+
go get golang.org/x/tools/gopls
59+
go get github.com/cweill/gotests/...
60+
go get github.com/rogpeppe/godef
61+
go get github.com/ramya-rao-a/go-outline
62+
go get github.com/go-delve/delve/cmd/dlv@master
63+
env:
64+
GO111MODULE: on
65+
EXT: "${{ matrix.os == 'windows-latest' && '.exe' || ''}}"
66+
67+
- name: Run unit tests
68+
run: npm run unit-test
69+
70+
- name: Run tests
71+
uses: GabrielBB/[email protected]
72+
with:
73+
run: npm run test
74+
env:
75+
CODE_VERSION: ${{ matrix.version }}
76+
VSCODEGO_BEFORE_RELEASE_TESTS: true
77+
78+
- name: Lint check
79+
run: npm run lint
80+
if: ${{ matrix.os }} == 'ubuntu-latest' && ${{ matrix.version }} == 'stable' && !contains(${{ matrix.go }}, "beta") && !contains(${{ matrix.go }}, "rc")

‎.github/workflows/test-long.yml‎

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,22 @@
11
name: Long Tests
22

3-
on:
4-
push:
5-
branches-ignore:
6-
- 'latest'
7-
- 'upstream'
3+
on: [push]
84

95
jobs:
106
build:
11-
name: ${{ matrix.os }} ${{ matrix.version }}
7+
name: ${{ matrix.os }} ${{ matrix.version }} ${{ matrix.go }}
128
runs-on: ${{ matrix.os }}
139

1410
# Not containing 'SKIP CI' in the commit message AND
15-
# (Either non-Windows OR triggered on 'push' (if triggered by 'pull_request', github.base_ref is not empty)
16-
if: github.repository == 'golang/vscode-go' && !contains(github.event.head_commit.message, 'SKIP CI')
11+
# (Either the official repository, or the commit message contains 'FORCE RUN CI')
12+
if: (github.repository == 'golang/vscode-go' || contains(github.event.head_commit.message, 'FORCE RUN CI')) && !contains(github.event.head_commit.message, 'SKIP CI')
1713
timeout-minutes: 20
1814
strategy:
1915
fail-fast: false
2016
matrix:
21-
os: [ubuntu-latest, windows-latest, macos-latest]
17+
os: [ubuntu-latest, windows-latest] # TODO: reenable macos-latest
2218
version: ['stable']
19+
go: ['1.15', '1.16']
2320

2421
steps:
2522
- name: Clone repository
@@ -28,12 +25,13 @@ jobs:
2825
- name: Setup Node
2926
uses: actions/setup-node@v1
3027
with:
31-
node-version: '10.x'
28+
node-version: '14.x'
3229

3330
- name: Setup Go
3431
uses: actions/setup-go@v2
3532
with:
36-
go-version: '1.15'
33+
go-version: ${{ matrix.go }}
34+
stable: '!contains(${{ matrix.go }}, "beta") && !contains(${{ matrix.go }}, "rc")'
3735

3836
- name: Install dependencies
3937
run: npm ci
@@ -47,6 +45,9 @@ jobs:
4745
go get github.com/acroca/go-symbols
4846
go get github.com/davidrjenni/reftools/cmd/fillstruct
4947
go get github.com/haya14busa/goplay/cmd/goplay
48+
# Install two versions of gocode (one as gocode-gomod)
49+
go get github.com/stamblerre/gocode
50+
mv "${HOME}/go/bin/gocode${{env.EXT}}" "${HOME}/go/bin/gocode-gomod${{env.EXT}}"
5051
go get github.com/mdempsky/gocode
5152
go get github.com/sqs/goreturns
5253
go get github.com/uudashr/gopkgs/v2/cmd/gopkgs
@@ -57,9 +58,10 @@ jobs:
5758
go get github.com/cweill/gotests/...
5859
go get github.com/rogpeppe/godef
5960
go get github.com/ramya-rao-a/go-outline
60-
go get github.com/go-delve/delve/cmd/dlv
61+
go get github.com/go-delve/delve/cmd/dlv@master
6162
env:
62-
GO111MODULE: on
63+
GO111MODULE: on
64+
EXT: "${{ matrix.os == 'windows-latest' && '.exe' || ''}}"
6365

6466
- name: Run unit tests
6567
run: npm run unit-test

‎.github/workflows/test-smoke.yml‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ jobs:
2424
- name: Setup Node
2525
uses: actions/setup-node@v1
2626
with:
27-
node-version: '10.x'
27+
node-version: '14.x'
2828

2929
- name: Setup Go
3030
uses: actions/setup-go@v2
3131
with:
32-
go-version: '1.15'
32+
go-version: '1.16'
3333

3434
- name: Install dependencies
3535
run: npm ci
@@ -43,6 +43,9 @@ jobs:
4343
go get github.com/acroca/go-symbols
4444
go get github.com/davidrjenni/reftools/cmd/fillstruct
4545
go get github.com/haya14busa/goplay/cmd/goplay
46+
# Install two versions of gocode (one as gocode-gomod)
47+
go get github.com/stamblerre/gocode
48+
mv "${HOME}/go/bin/gocode${{env.EXT}}" "${HOME}/go/bin/gocode-gomod${{env.EXT}}"
4649
go get github.com/mdempsky/gocode
4750
go get github.com/sqs/goreturns
4851
go get github.com/uudashr/gopkgs/v2/cmd/gopkgs
@@ -53,9 +56,10 @@ jobs:
5356
go get github.com/cweill/gotests/...
5457
go get github.com/rogpeppe/godef
5558
go get github.com/ramya-rao-a/go-outline
56-
go get github.com/go-delve/delve/cmd/dlv
59+
go get github.com/go-delve/delve/cmd/dlv@master
5760
env:
58-
GO111MODULE: on
61+
GO111MODULE: on
62+
EXT: "${{ matrix.os == 'windows-latest' && '.exe' || ''}}"
5963

6064
- name: Run unit tests
6165
run: npm run unit-test

‎.prettierrc.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
module.exports = {
2+
...require('gts/.prettierrc.json')
3+
}

‎.vscode/launch.json‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -38,22 +38,6 @@
3838
"smartStep": true,
3939
"preLaunchTask": "npm: webpack"
4040
},
41-
{
42-
"name": "Launch as server (dlv dap)",
43-
"type": "node",
44-
"protocol": "inspector",
45-
"request": "launch",
46-
"program": "${workspaceFolder}/dist/debugAdapter2.js",
47-
"args": [
48-
"--server=4711"
49-
],
50-
"sourceMaps": true,
51-
"smartStep": true,
52-
"outFiles": [
53-
"${workspaceFolder}/dist/**/*.js"
54-
],
55-
"preLaunchTask": "npm: webpack"
56-
},
5741
{
5842
"name": "Launch Extension Tests",
5943
"type": "extensionHost",

‎build/Dockerfile‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# This Docker container is used for testing on GCB.
2-
3-
FROM golang:1.15 AS gobuilder
2+
ARG GOVERSION=1
3+
FROM golang:${GOVERSION} AS gobuilder
44

55
ENV GO111MODULE on
66
ENV GOBIN /gobin
@@ -26,7 +26,7 @@ COPY --from=gobuilder /usr/local/go /usr/local/go
2626
ENV PATH /workspace/vscodego/go/bin:/go/bin:/usr/local/go/bin:${PATH}
2727
ENV DEBIAN_FRONTEND noninteractive
2828

29-
RUN apt-get update && apt-get install -y libnss3 libgtk-3-dev libxss1 libasound2 xvfb libsecret-1-0
29+
RUN apt-get -qq update && apt-get install -qq -y libnss3 libgtk-3-dev libxss1 libasound2 xvfb libsecret-1-0 > /dev/null
3030
RUN npm install -g typescript vsce
3131

3232
WORKDIR /workspace

0 commit comments

Comments
 (0)