[release] prepare v0.23.0 release

8da2809 utils/pathUtils: add the new installation paths for windows
cbb1479 src/goModules: check goVersion isn't null before using it
6c0bda2 package.json: configure the debug adapter from launch.json
481ae47 test/integration/goDebug.test.ts: include reasons for cwd test fail
d96dc45 test/integration/goDebug.test.ts: fix local variable assertion
7f1e239 build/all.bash: use delve at master for ci
516bf10 .github/workflows: use delve at master
7dd7f7a src/goLanguageServer: remove go-langserver deprecation warning
8f31447 test/integration/goDebug.test.ts: run existing debug tests on dlv dap
66e03b8 src/pickProcess: fix regexp to detect go versions with no patch version
7fcd3d2 eslint: Fix some eslint warnings
54602c5 src/debugAdapter: disable stackTrace error pop-ups
8272510 package.json: update logOutput documentation in launch config
5e19b9d .github/workflows: update go, node versions
30b086f src/goMain: use lint tool's name as the lint diagnostic collection name
e760407 src/goDebugConfiguration.ts: remove gcflags using regexp
150a6d3 package-lock.json: update gts/prettier locked versions
8c699ae build: run with a different version of go
526ef89 .github/workflows: remove macos-latest from test-long.yml
4a719c8 CHANGELOG.md: sync CHANGELOG.md with the one in the release branch
49d737e package.json: change version to v0.23.0-dev
f7b122c docs/advanced: add info about format/import
74e266b eslint: reformat files in src with gts fix and eslint comments
289e788 docs/debugging.md: update documentation for processId
c7086f8 src/goDebugFactory.ts: remove the "godlvdap" debug type
84a6b61 package.json: add disableConcurrentTests setting
4ef4f53 eslint: Change test files so eslint does not complain
d0777c4 .github/workflows: allow to run Long Tests outside the official repo
e8a2ba3 .github/workflows: add go1.16 test to Long Tests
64f7875 test/integration: use module mode for testing
ab62b6c test/testdata: add missing go.mod file for cwdTest
9233ebf .github/workflows: install gocode-gomod
02b5116 build/all.bash: install gocode-gomode
0dc8517 goLanguageServer: prompt user to fill out survey when they disable gopls
1a9e669 Revert ".github/workflows: run Long Tests with go1.16 rc1"
32a9f15 .github/workflows: run Long Tests with go1.16 rc1
95dc50c goLanguageServer: add logic to prompt users to opt back into gopls
48c4af1 src/pickProcess.ts: add attach by process name command
3ef8679 third_party/tree-kill: remove dependency on mocha
3525068 src/pickProcess.ts: use lsof to find process exes on darwin
3fa9b0f src/debugAdapter2: remove thin adapter for dlv-dap
0c6dce4 goLanguageServer: add special handling for incorrect flags
6a14cd3 package-lock.json: update package-lock.json to lockfile version 2
2e2c885 test: use CODE_VERSION for testing
7452751 test/runTest: add --force-disable-user-env
df853b9 src/goDebugFactory.ts: run dlv-dap as a server and connect as server
555b11b docs: fix broken links
feee65b src/goMain: fix the exception caused by invalid version string
df04ba2 test/runTest: use vscode 1.52.1
6c94bb8 src/goDebugConfiguration.ts: invoke pick process for local attach
f2fcdb1 src/goMain: correct showGoWelcomePage hard-coded version string
eb53a53 package.json: fix typos
ab0629e src/goLanguageServer: add platfom info in the automated issue report
2c40d20 goLanguageServer: disable the language server with SSH URIs
6841fe0 src/goMain: use a hard-coded version string for welcome page state
306da34 src/goLanguageServer: use isInPreviewMode to enable experiments
cf5ff5f docs/settings.md: replace the old gopls doc link with the new one
1ad5c33 src/goLanguageServer: protect language restart with mutex
30b7367 package-lock.json: update ini
55b2284 src/goLanguageServer: block until the language client is ready
3c08fec package.json: add dlv to alternateTools value list
05251dd README.md: add the new video material
46a15da src/utils/wmicProcessParser.ts: get exe path from wmic
aa02c3f src/pickProcess.ts: add linux cmd for go process
cfc3d4f src/goMain: linkify documentLink deprecation warning message
5d48c07 goLanguageServer: add extra information to automated error reports
aac9542 goLanguageServer: add an opt-in "always update" setting for gopls
17e80f5 src/pickProcess.ts: fix platform process commands
db2234c src/stateUtils.ts: add command to reset memento state
4d6ed04 src/pickProcess.ts: add pick process command for local attach
ad3a7d2 build: run docker with SYS_PTRACE capability
1534912 src/goDebug: check if delve exited before attempting to get state
5f88d61 docs: delete broken links about auto formatting
63d2287 src/welcome: correct link to Gophers Slack
9a4ca54 src/goLanguageServer.ts: fix suggestUpdateGopls documentation
76ce9ba docs: minor updates of features.md and troubleshooting.md

Change-Id: Id7dfedf1bc1be02f5418e9064d1fbf4a4a502a80

Author: hyangah

.eslintignore

@@ -0,0 +1,2 @@
+build/
+node_modules/

.eslintrc.json

@@ -0,0 +1,4 @@
+{
+  "extends": "./node_modules/gts/",
+  "root": true
+}

.github/workflows/release-nightly.yml

@@ -24,7 +24,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v1
         with:
-          node-version: '10.x'
+          node-version: '14.x'
 
       - name: Setup Go
         uses: actions/setup-go@v2
@@ -48,7 +48,12 @@ jobs:
             go get github.com/acroca/go-symbols
             go get github.com/davidrjenni/reftools/cmd/fillstruct
             go get github.com/haya14busa/goplay/cmd/goplay
+
+            # Install two versions of gocode (one as gocode-gomod)
+            go get github.com/stamblerre/gocode
+            mv "${HOME}/go/bin/gocode${{env.EXT}}" "${HOME}/go/bin/gocode-gomod${{env.EXT}}"
             go get github.com/mdempsky/gocode
+
             go get github.com/sqs/goreturns
             go get github.com/uudashr/gopkgs/v2/cmd/gopkgs
             go get github.com/zmb3/gogetdoc
@@ -58,9 +63,10 @@ jobs:
             go get github.com/cweill/gotests/...
             go get github.com/rogpeppe/godef
             go get github.com/ramya-rao-a/go-outline
-            go get github.com/go-delve/delve/cmd/dlv
+            go get github.com/go-delve/delve/cmd/dlv@master
         env:
-          GO111MODULE: on   
+          GO111MODULE: on
+          EXT: "${{ matrix.os == 'windows-latest' && '.exe' || ''}}"
 
       - name: Run unit tests
         run: npm run unit-test

.github/workflows/release.yml

@@ -108,5 +108,4 @@ jobs:
         env:
           VSCE_TOKEN: ${{ secrets.VSCE_TOKEN }}
 
-# TODO: check if the commit is in green state. (test-long.yml results)
-# TODO: after publishing, create a gerrit CL to update 'latest' branch if VERSION is for a stable version.
+# TODO: check if the commit is in green state. (test-long.yml results)

.github/workflows/test-long-all.yml

@@ -0,0 +1,80 @@
+name: Daily Build Status
+
+on:
+  schedule:
+    - cron: "0 11 * * *"  # 11 UTC, everyday
+
+jobs:
+  build:
+    name: ${{ matrix.os }} ${{ matrix.version }} ${{ matrix.go }}
+    runs-on: ${{ matrix.os }}
+
+    # Only in the official repository.
+    if: github.repository == 'golang/vscode-go'
+    timeout-minutes: 20
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+        version: ['stable', 'insiders']
+        go: ['1.15', '1.16']
+
+    steps:
+      - name: Clone repository
+        uses: actions/checkout@v2
+
+      - name: Setup Node
+        uses: actions/setup-node@v1
+        with:
+          node-version: '14.x'
+
+      - name: Setup Go
+        uses: actions/setup-go@v2
+        with:
+         go-version: ${{ matrix.go }}
+         stable: '!contains(${{ matrix.go }}, "beta") && !contains(${{ matrix.go }}, "rc")'
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Compile
+        run: npm run vscode:prepublish
+
+      - name: Install Go tools (Modules mode)
+        run: |
+            go version
+            go get github.com/acroca/go-symbols
+            go get github.com/davidrjenni/reftools/cmd/fillstruct
+            go get github.com/haya14busa/goplay/cmd/goplay
+            # Install two versions of gocode (one as gocode-gomod)
+            go get github.com/stamblerre/gocode
+            mv "${HOME}/go/bin/gocode${{env.EXT}}" "${HOME}/go/bin/gocode-gomod${{env.EXT}}"
+            go get github.com/mdempsky/gocode
+            go get github.com/sqs/goreturns
+            go get github.com/uudashr/gopkgs/v2/cmd/gopkgs
+            go get github.com/zmb3/gogetdoc
+            go get golang.org/x/lint/golint
+            go get golang.org/x/tools/cmd/gorename
+            go get golang.org/x/tools/gopls
+            go get github.com/cweill/gotests/...
+            go get github.com/rogpeppe/godef
+            go get github.com/ramya-rao-a/go-outline
+            go get github.com/go-delve/delve/cmd/dlv@master
+        env:
+          GO111MODULE: on
+          EXT: "${{ matrix.os == 'windows-latest' && '.exe' || ''}}"
+
+      - name: Run unit tests
+        run: npm run unit-test
+
+      - name: Run tests
+        uses: GabrielBB/[email protected]
+        with:
+          run: npm run test
+        env:
+          CODE_VERSION: ${{ matrix.version }}
+          VSCODEGO_BEFORE_RELEASE_TESTS: true
+
+      - name: Lint check
+        run: npm run lint
+        if: ${{ matrix.os }} == 'ubuntu-latest' && ${{ matrix.version }} == 'stable' && !contains(${{ matrix.go }}, "beta") && !contains(${{ matrix.go }}, "rc")

.github/workflows/test-long.yml

@@ -1,25 +1,22 @@
 name: Long Tests
 
-on:
-  push:
-    branches-ignore:
-      - 'latest'
-      - 'upstream'
+on: [push]
 
 jobs:
   build:
-    name: ${{ matrix.os }} ${{ matrix.version }}
+    name: ${{ matrix.os }} ${{ matrix.version }} ${{ matrix.go }}
     runs-on: ${{ matrix.os }}
 
     # Not containing 'SKIP CI' in the commit message AND
-    # (Either non-Windows OR triggered on 'push' (if triggered by 'pull_request', github.base_ref is not empty)
-    if: github.repository == 'golang/vscode-go' && !contains(github.event.head_commit.message, 'SKIP CI')
+    # (Either the official repository, or the commit message contains 'FORCE RUN CI')
+    if: (github.repository == 'golang/vscode-go' || contains(github.event.head_commit.message, 'FORCE RUN CI')) && !contains(github.event.head_commit.message, 'SKIP CI')
     timeout-minutes: 20
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, windows-latest, macos-latest]
+        os: [ubuntu-latest, windows-latest] # TODO: reenable macos-latest
         version: ['stable']
+        go: ['1.15', '1.16']
 
     steps:
       - name: Clone repository
@@ -28,12 +25,13 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v1
         with:
-          node-version: '10.x'
+          node-version: '14.x'
 
       - name: Setup Go
         uses: actions/setup-go@v2
         with:
-         go-version: '1.15'
+         go-version: ${{ matrix.go }}
+         stable: '!contains(${{ matrix.go }}, "beta") && !contains(${{ matrix.go }}, "rc")'
 
       - name: Install dependencies
         run: npm ci
@@ -47,6 +45,9 @@ jobs:
             go get github.com/acroca/go-symbols
             go get github.com/davidrjenni/reftools/cmd/fillstruct
             go get github.com/haya14busa/goplay/cmd/goplay
+            # Install two versions of gocode (one as gocode-gomod)
+            go get github.com/stamblerre/gocode
+            mv "${HOME}/go/bin/gocode${{env.EXT}}" "${HOME}/go/bin/gocode-gomod${{env.EXT}}"
             go get github.com/mdempsky/gocode
             go get github.com/sqs/goreturns
             go get github.com/uudashr/gopkgs/v2/cmd/gopkgs
@@ -57,9 +58,10 @@ jobs:
             go get github.com/cweill/gotests/...
             go get github.com/rogpeppe/godef
             go get github.com/ramya-rao-a/go-outline
-            go get github.com/go-delve/delve/cmd/dlv
+            go get github.com/go-delve/delve/cmd/dlv@master
         env:
-          GO111MODULE: on   
+          GO111MODULE: on
+          EXT: "${{ matrix.os == 'windows-latest' && '.exe' || ''}}"
 
       - name: Run unit tests
         run: npm run unit-test

.github/workflows/test-smoke.yml

@@ -24,12 +24,12 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v1
         with:
-          node-version: '10.x'
+          node-version: '14.x'
 
       - name: Setup Go
         uses: actions/setup-go@v2
         with:
-         go-version: '1.15'
+         go-version: '1.16'
 
       - name: Install dependencies
         run: npm ci
@@ -43,6 +43,9 @@ jobs:
             go get github.com/acroca/go-symbols
             go get github.com/davidrjenni/reftools/cmd/fillstruct
             go get github.com/haya14busa/goplay/cmd/goplay
+            # Install two versions of gocode (one as gocode-gomod)
+            go get github.com/stamblerre/gocode
+            mv "${HOME}/go/bin/gocode${{env.EXT}}"  "${HOME}/go/bin/gocode-gomod${{env.EXT}}"
             go get github.com/mdempsky/gocode
             go get github.com/sqs/goreturns
             go get github.com/uudashr/gopkgs/v2/cmd/gopkgs
@@ -53,9 +56,10 @@ jobs:
             go get github.com/cweill/gotests/...
             go get github.com/rogpeppe/godef
             go get github.com/ramya-rao-a/go-outline
-            go get github.com/go-delve/delve/cmd/dlv
+            go get github.com/go-delve/delve/cmd/dlv@master
         env:
-          GO111MODULE: on             
+          GO111MODULE: on
+          EXT: "${{ matrix.os == 'windows-latest' && '.exe' || ''}}"
 
       - name: Run unit tests
         run: npm run unit-test

.prettierrc.js

@@ -0,0 +1,3 @@
+module.exports = {
+  ...require('gts/.prettierrc.json')
+}

.vscode/launch.json

@@ -38,22 +38,6 @@
 			"smartStep": true,
 			"preLaunchTask": "npm: webpack"
 		},
-		{
-			"name": "Launch as server (dlv dap)",
-			"type": "node",
-			"protocol": "inspector",
-			"request": "launch",
-			"program": "${workspaceFolder}/dist/debugAdapter2.js",
-			"args": [
-				"--server=4711"
-			],
-			"sourceMaps": true,
-			"smartStep": true,
-			"outFiles": [
-				"${workspaceFolder}/dist/**/*.js"
-			],
-			"preLaunchTask": "npm: webpack"
-		},
 		{
 			"name": "Launch Extension Tests",
 			"type": "extensionHost",

build/Dockerfile

@@ -1,6 +1,6 @@
 # This Docker container is used for testing on GCB.
-
-FROM golang:1.15 AS gobuilder
+ARG GOVERSION=1
+FROM golang:${GOVERSION} AS gobuilder
 
 ENV GO111MODULE on
 ENV GOBIN /gobin
@@ -26,7 +26,7 @@ COPY --from=gobuilder /usr/local/go /usr/local/go
 ENV PATH /workspace/vscodego/go/bin:/go/bin:/usr/local/go/bin:${PATH}
 ENV DEBIAN_FRONTEND noninteractive
 
-RUN apt-get update && apt-get install -y libnss3 libgtk-3-dev libxss1 libasound2 xvfb libsecret-1-0
+RUN apt-get -qq update && apt-get install -qq -y libnss3 libgtk-3-dev libxss1 libasound2 xvfb libsecret-1-0 > /dev/null
 RUN npm install -g typescript vsce
 
 WORKDIR /workspace