Skip to content

Commit 97292e3

Browse files
h9jianggopherbot
authored andcommitted
extension/tools/release: skip version check for package creation
Tools gh, git, jq is not required for package creation: - gh & git is being used only in publish. - jq is no longer needed because version check is now skipped. For #3500 Change-Id: I530f600bb983ac1e9e884bc6910bcd8f1b0717e0 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/612815 Commit-Queue: Hongxiang Jiang <[email protected]> kokoro-CI: kokoro <[email protected]> Auto-Submit: Hongxiang Jiang <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
1 parent 1a3eb27 commit 97292e3

File tree

4 files changed

+1
-6
lines changed

4 files changed

+1
-6
lines changed

extension/tools/release/release.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -210,12 +210,11 @@ func runPackage(cmd *command, args []string) {
210210

211211
checkWD()
212212

213-
requireTools("jq", "npx", "gh", "git")
213+
requireTools("npx")
214214

215215
tagName := requireEnv("TAG_NAME")
216216

217217
version, isPrerelease := releaseVersionInfo(tagName)
218-
checkPackageJSON(tagName, isPrerelease)
219218
outDir := prepareOutputDir(cmd.lookupFlag("out").String())
220219
vsix := filepath.Join(outDir, fmt.Sprintf("go-%s.vsix", version))
221220
buildPackage(version, tagName, isPrerelease, vsix)
@@ -423,7 +422,6 @@ func buildPackage(version, tagName string, isPrerelease bool, output string) {
423422
}
424423
if isPrerelease {
425424
args = append(args, "--pre-release")
426-
427425
}
428426
args = append(args, version)
429427

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
1-
jq -r .version package.json
21
cp ../README.md README.md
32
npx vsce package -o /tmp/artifacts/go-0.43.0.vsix --baseContentUrl https://github.com/golang/vscode-go/raw/v0.43.0 --baseImagesUrl https://github.com/golang/vscode-go/raw/v0.43.0 --no-update-package-json --no-git-tag-version --pre-release 0.43.0
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
1-
jq -r .version package.json
21
cp ../README.md README.md
32
npx vsce package -o /tmp/artifacts/go-0.44.0-rc.1.vsix --baseContentUrl https://github.com/golang/vscode-go/raw/v0.44.0-rc.1 --baseImagesUrl https://github.com/golang/vscode-go/raw/v0.44.0-rc.1 --no-update-package-json --no-git-tag-version --pre-release 0.44.0-rc.1
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
1-
jq -r .version package.json
21
cp ../README.md README.md
32
npx vsce package -o /tmp/artifacts/go-0.44.0.vsix --baseContentUrl https://github.com/golang/vscode-go/raw/v0.44.0 --baseImagesUrl https://github.com/golang/vscode-go/raw/v0.44.0 --no-update-package-json --no-git-tag-version 0.44.0

0 commit comments

Comments
 (0)