src/goDebugConfiguration: let vscode resolve pick process

There was a bug that used the command specification as a "name"
argument to pass into the pick process command. This change
makes sure not to attempt to resolve the commands in
resolveDebugConfiguration.

Change-Id: Iaeb99d2447c8eaebb215babfc27489e46d024b3b
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/322294
Trust: Suzy Mueller <[email protected]>
Trust: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Suzy Mueller <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>

Author: suzmue

src/goDebugConfiguration.ts

@@ -297,7 +297,11 @@ export class GoDebugConfigurationProvider implements vscode.DebugConfigurationPr
 			if (!debugConfiguration['processId'] || debugConfiguration['processId'] === 0) {
 				// The processId is not valid, offer a quickpick menu of all processes.
 				debugConfiguration['processId'] = parseInt(await pickProcess(), 10);
-			} else if (typeof debugConfiguration['processId'] === 'string') {
+			} else if (
+				typeof debugConfiguration['processId'] === 'string' &&
+				debugConfiguration['processId'] !== '${command:pickProcess}' &&
+				debugConfiguration['processId'] !== '${command:pickGoProcess}'
+			) {
 				debugConfiguration['processId'] = parseInt(
 					await pickProcessByName(debugConfiguration['processId']),
 					10