Skip to content

Commit acad49d

Browse files
committed
[release] goLanguageServer: disable the language server with SSH URIs
This is another case, like VSLS, where the language server should be running remotely. Fixes #1171 Change-Id: Ic4d2ceac8f1b72cb6742540092e8c32f58a6efd9 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/289197 Run-TryBot: Rebecca Stambler <[email protected]> TryBot-Result: kokoro <[email protected]> Trust: Rebecca Stambler <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> (cherry picked from commit 2c40d20) Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/289329
1 parent 1aefe8e commit acad49d

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

src/goLanguageServer.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -115,10 +115,14 @@ let lastUserAction: Date = new Date();
115115
export async function startLanguageServerWithFallback(ctx: vscode.ExtensionContext, activation: boolean) {
116116

117117
for (const folder of vscode.workspace.workspaceFolders || []) {
118-
if (folder.uri.scheme === 'vsls') {
119-
outputChannel.appendLine(`Language service on the guest side is disabled. ` +
120-
`The server-side language service will provide the language features.`);
121-
return;
118+
switch (folder.uri.scheme) {
119+
case 'vsls':
120+
outputChannel.appendLine(`Language service on the guest side is disabled. ` +
121+
`The server-side language service will provide the language features.`);
122+
return;
123+
case 'ssh':
124+
outputChannel.appendLine(`The language server is not supported for SSH. Disabling it.`);
125+
return;
122126
}
123127
}
124128

@@ -272,7 +276,7 @@ export async function buildLanguageClient(cfg: BuildLanguageClientOption): Promi
272276
const goplsWorkspaceConfig = await adjustGoplsWorkspaceConfiguration(cfg, getGoplsConfig(), 'gopls', undefined);
273277

274278
const documentSelector = [
275-
// Filter out unsupported document types, e.g. vsls, git.
279+
// Filter out unsupported document types, e.g. vsls, git, ssh.
276280
// https://docs.microsoft.com/en-us/visualstudio/liveshare/reference/extensions#visual-studio-code-1
277281
//
278282
// - files

0 commit comments

Comments
 (0)