extension/src/goLint: adding .exe extension to the binary name on Windows

This change ensures that the tools with major versions higher than v2
can be properly installed on Windows systems. An error occurred in the
binary copying process due to the missing .exe extension.

Fixes #3777

Change-Id: Iecd1d419bf87be622986ac1d023274e9914992c5
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/683195
Reviewed-by: Madeline Kalil <[email protected]>
Reviewed-by: Hongxiang Jiang <[email protected]>
kokoro-CI: kokoro <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>

Author: logica0419

extension/src/goInstallTools.ts

@@ -255,8 +255,10 @@ export async function installTools(
 		// v2, v3... of the tools are installed with the same name as v1,
 		// but must be able to co-exist with other major versions in the GOBIN.
 		// Thus, we install it in a tmp directory and copy it to the GOBIN.
-		// See detail: golang/vscode-go#3732
-		if (tool.name.match('-v\\d+$')) {
+		// See detail: https://github.com/golang/vscode-go/issues/3732#issuecomment-2752026894
+		const isUpgradedMajorVersion = tool.name.match('-v\\d+$');
+
+		if (isUpgradedMajorVersion) {
 			envForTools['GOBIN'] = path.join(installingPath, 'tmp');
 		}
 
@@ -268,15 +270,18 @@ export async function installTools(
 			vscode.commands.executeCommand('go.languageserver.restart', RestartReason.INSTALLATION);
 		}
 
-		if (tool.name.match('-v\\d+$')) {
+		if (isUpgradedMajorVersion) {
 			// grep the tool name without version.
 			const toolName = tool.name.match('^(?<tool>.+)-v\\d+$')?.groups?.tool;
 			if (!toolName) {
 				failures.push({ tool, reason: 'failed to grep tool name with regex' });
 				continue;
 			}
 
-			fs.copyFileSync(path.join(installingPath, 'tmp', toolName), path.join(installingPath, tool.name));
+			fs.copyFileSync(
+				path.join(installingPath, 'tmp', correctBinname(toolName)),
+				path.join(installingPath, correctBinname(tool.name))
+			);
 			fs.rmdirSync(path.join(installingPath, 'tmp'), { recursive: true });
 		}
 	}