Skip to content

Commit c3047d2

Browse files
committed
src/goLanguageServer: send only file URIs to gopls
gopls never handled untitled URIs Fixes #1559 Change-Id: Ibb52e5ebffa4f82adaa59c1d54ab5a0ba613be37 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/327189 Trust: Hyang-Ah Hana Kim <[email protected]> Run-TryBot: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: kokoro <[email protected]> Reviewed-by: Rebecca Stambler <[email protected]>
1 parent b70f3c0 commit c3047d2

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

src/goLanguageServer.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -457,22 +457,15 @@ export async function buildLanguageClient(cfg: BuildLanguageClientOption): Promi
457457
const goplsWorkspaceConfig = await adjustGoplsWorkspaceConfiguration(cfg, getGoplsConfig(), 'gopls', undefined);
458458

459459
const documentSelector = [
460-
// Filter out unsupported document types, e.g. vsls, git, ssh.
461-
// https://docs.microsoft.com/en-us/visualstudio/liveshare/reference/extensions#visual-studio-code-1
462-
//
463-
// - files
460+
// gopls handles only file URIs.
464461
{ language: 'go', scheme: 'file' },
465462
{ language: 'go.mod', scheme: 'file' },
466-
{ language: 'go.sum', scheme: 'file' },
467-
// - unsaved files
468-
{ language: 'go', scheme: 'untitled' },
469-
{ language: 'go.mod', scheme: 'untitled' },
470-
{ language: 'go.sum', scheme: 'untitled' }
463+
{ language: 'go.sum', scheme: 'file' }
471464
];
472465

473466
// Let gopls know about .tmpl - this is experimental, so enable it only in the experimental mode now.
474467
if (isInPreviewMode()) {
475-
documentSelector.push({ language: 'tmpl', scheme: 'file' }, { language: 'tmpl', scheme: 'untitled' });
468+
documentSelector.push({ language: 'tmpl', scheme: 'file' });
476469
}
477470
const c = new LanguageClient(
478471
'go', // id

0 commit comments

Comments
 (0)