Commit c8584f4
committed
[release] src/goTest: avoid a name conflicting with the proposed quickpick api
src/goTest used an extended quickpick type that adds a custom property
'kind' to specify the profile type. Unfortunately, that conflicts with
the proposed API added during vscode 1.63 dev cycle and breaks the
extension's profile feature.
Rename ours to 'profilekind'.
And reenabled the profile feature tests disabled due to 1858.
(but these tests don't exercise the affected code path - quickpick
UI interaction)
Fixes #2048
Updates #1858
Change-Id: Iedd1c5f32cdbc8438e203f8989f28bfcaf1c04b4
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/382334
Trust: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Ethan Reesor <[email protected]>
Reviewed-by: Peter Weinberger <[email protected]>
(cherry picked from commit 037e8a3)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/383219
Reviewed-by: Robert Findley <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>1 parent c845547 commit c8584f4
2 files changed
+5
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
80 | | - | |
| 79 | + | |
| 80 | + | |
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
0 commit comments