extension: consolidate documentSelector

Change-Id: I26c853e24a7e0bf7fe3523c4e37514276d9fa98a
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/559735
Reviewed-by: Suzy Mueller <[email protected]>
Commit-Queue: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>

Author: hyangah

extension/src/goMode.ts

@@ -13,16 +13,16 @@ interface Filter extends vscode.DocumentFilter {
 }
 
 export const GO_MODE: Filter = { language: 'go', scheme: 'file' };
-export const GO_MOD_MODE: Filter = { language: 'go.mod', scheme: 'file' };
-export const GO_SUM_MODE: Filter = { language: 'go.sum', scheme: 'file' };
 
 export function isGoFile(document: vscode.TextDocument): boolean {
-	if (
-		vscode.languages.match(GO_MODE, document) ||
-		vscode.languages.match(GO_MOD_MODE, document) ||
-		vscode.languages.match(GO_SUM_MODE, document)
-	) {
-		return true;
-	}
-	return false;
+	return GoDocumentSelector.some((selector) => vscode.languages.match(selector, document));
 }
+
+export const GoDocumentSelector = [
+	// gopls handles only file URIs.
+	{ language: 'go', scheme: 'file' },
+	{ language: 'go.mod', scheme: 'file' },
+	{ language: 'go.sum', scheme: 'file' },
+	{ language: 'go.work', scheme: 'file' },
+	{ language: 'gotmpl', scheme: 'file' }
+];

extension/src/language/goLanguageServer.ts

@@ -62,6 +62,7 @@ import { URI } from 'vscode-uri';
 import { IVulncheckTerminal, VulncheckReport, VulncheckTerminal, writeVulns } from '../goVulncheck';
 import { createHash } from 'crypto';
 import { GoExtensionContext } from '../context';
+import { GoDocumentSelector } from '../goMode';
 
 export interface LanguageServerConfig {
 	serverName: string;
@@ -397,15 +398,6 @@ export async function buildLanguageClient(
 	await getLocalGoplsVersion(cfg); // populate and cache cfg.version
 	const goplsWorkspaceConfig = await adjustGoplsWorkspaceConfiguration(cfg, getGoplsConfig(), 'gopls', undefined);
 
-	const documentSelector = [
-		// gopls handles only file URIs.
-		{ language: 'go', scheme: 'file' },
-		{ language: 'go.mod', scheme: 'file' },
-		{ language: 'go.sum', scheme: 'file' },
-		{ language: 'go.work', scheme: 'file' },
-		{ language: 'gotmpl', scheme: 'file' }
-	];
-
 	// when initialization is failed after the connection is established,
 	// we want to handle the connection close error case specially. Capture the error
 	// in initializationFailedHandler and handle it in the connectionCloseHandler.
@@ -425,7 +417,7 @@ export async function buildLanguageClient(
 		} as ServerOptions,
 		{
 			initializationOptions: goplsWorkspaceConfig,
-			documentSelector,
+			documentSelector: GoDocumentSelector,
 			uriConverters: {
 				// Apply file:/// scheme to all file paths.
 				code2Protocol: (uri: vscode.Uri): string =>