[release] prepare v0.19.0 release

Change-Id: I61d0614fca3b7cd9dbd7525c7b4c6d2414282b51

Author: suzmue

.github/workflows/release-nightly.yml

@@ -27,7 +27,7 @@ jobs:
           node-version: '10.x'
 
       - name: Setup Go
-        uses: actions/setup-go@v1
+        uses: actions/setup-go@v2
         with:
          go-version: '1.15'
 

.github/workflows/test-long.yml

@@ -31,7 +31,7 @@ jobs:
           node-version: '10.x'
 
       - name: Setup Go
-        uses: actions/setup-go@v1
+        uses: actions/setup-go@v2
         with:
          go-version: '1.15'
 

.github/workflows/test-smoke.yml

@@ -27,7 +27,7 @@ jobs:
           node-version: '10.x'
 
       - name: Setup Go
-        uses: actions/setup-go@v1
+        uses: actions/setup-go@v2
         with:
          go-version: '1.15'
 

.gitignore

@@ -3,3 +3,4 @@ dist/
 node_modules/
 .vscode-test/
 .DS_Store
+.user-data-dir-test/

.vscode/launch.json

@@ -18,6 +18,9 @@
 			"sourceMaps": true,
 			"smartStep": true,
 			"preLaunchTask": "npm: webpack",
+			"env": {
+				"VSCODE_GO_IN_TEST": ""  // Enable code
+			},
 		},
 		{
 			"name": "Launch as server",
@@ -61,13 +64,18 @@
 				"--disable-extensions",
 				"--extensionDevelopmentPath=${workspaceFolder}",
 				"--extensionTestsPath=${workspaceFolder}/out/test/integration/index",
+				"--user-data-dir=${workspaceFolder}/.user-data-dir-test",
 				"--timeout",
 				"999999"
 			],
+			"env": {
+				"VSCODE_GO_IN_TEST": "1"  // Disable code that shouldn't be used in test
+			},
 			"stopOnEntry": false,
 			"sourceMaps": true,
 			"smartStep": true,
 			"outFiles": [
+				"${workspaceFolder}/out/**/*.js",
 				"${workspaceFolder}/out/test/**/*.js"
 			],
 			"preLaunchTask": "npm: watch"
@@ -82,12 +90,16 @@
 				"--disable-extensions",
 				"--extensionDevelopmentPath=${workspaceFolder}",
 				"--extensionTestsPath=${workspaceFolder}/out/test/gopls/index",
+				"--user-data-dir=${workspaceFolder}/.user-data-dir-test",
 				"--timeout", "999999",
-				"${workspaceFolder}/test/gopls/testfixtures/src/workspace"  // gopls requires a workspace to work with.
 			],
+			"env": {
+				"VSCODE_GO_IN_TEST": "1"  // Disable code that shouldn't be used in test
+			},
 			"stopOnEntry": false,
 			"sourceMaps": true,
 			"outFiles": [
+				"${workspaceFolder}/out/**/*.js",
 				"${workspaceFolder}/out/test/**/*.js"
 			],
 			"preLaunchTask": "npm: watch",

.vscode/settings.json

@@ -11,4 +11,4 @@
 	},
 	"editor.insertSpaces": false,
 	"typescript.tsdk": "node_modules\\typescript\\lib",
-}
+}

build/Dockerfile

@@ -12,13 +12,18 @@ RUN /scratch/build/all.bash setup_env
 
 FROM node:latest
 
+# Prepare a home directory under workspace.
+RUN mkdir -p /workspace/vscodego
+ENV HOME=/workspace/vscodego
+
 # GO111MODULE=auto
 RUN mkdir /go
 COPY --from=gobuilder /gobin /go/bin
 COPY --from=gobuilder /usr/local/go /usr/local/go
 
-ENV GOPATH /go
-ENV PATH ${GOPATH}/bin:/usr/local/go/bin:${PATH}
+# Add the default GOPATH/bin to the PATH.
+# Add the directories of the go tool chains to PATH.
+ENV PATH /workspace/vscodego/go/bin:/go/bin:/usr/local/go/bin:${PATH}
 ENV DEBIAN_FRONTEND noninteractive
 
 RUN apt-get update && apt-get install -y libnss3 libgtk-3-dev libxss1 libasound2 xvfb libsecret-1-0

build/all.bash

@@ -89,20 +89,20 @@ prepare_nightly() {
 
 # setup dependencies required for tests.
 install_dependencies() {
-	GO111MODULE=on go get -x golang.org/x/tools/gopls
-	GO111MODULE=on go get -x github.com/acroca/go-symbols
-	GO111MODULE=on go get -x github.com/cweill/gotests/...
-	GO111MODULE=on go get -x github.com/davidrjenni/reftools/cmd/fillstruct
-	GO111MODULE=on go get -x github.com/haya14busa/goplay/cmd/goplay
-	GO111MODULE=on go get -x github.com/mdempsky/gocode
-	GO111MODULE=on go get -x github.com/ramya-rao-a/go-outline
-	GO111MODULE=on go get -x github.com/rogpeppe/godef
-	GO111MODULE=on go get -x github.com/sqs/goreturns
-	GO111MODULE=on go get -x github.com/uudashr/gopkgs/v2/cmd/gopkgs
-	GO111MODULE=on go get -x github.com/zmb3/gogetdoc
-	GO111MODULE=on go get -x golang.org/x/lint/golint
-	GO111MODULE=on go get -x golang.org/x/tools/cmd/gorename
-	GO111MODULE=on go get -x github.com/go-delve/delve/cmd/dlv
+	GO111MODULE=on go get golang.org/x/tools/gopls
+	GO111MODULE=on go get github.com/acroca/go-symbols
+	GO111MODULE=on go get github.com/cweill/gotests/...
+	GO111MODULE=on go get github.com/davidrjenni/reftools/cmd/fillstruct
+	GO111MODULE=on go get github.com/haya14busa/goplay/cmd/goplay
+	GO111MODULE=on go get github.com/mdempsky/gocode
+	GO111MODULE=on go get github.com/ramya-rao-a/go-outline
+	GO111MODULE=on go get github.com/rogpeppe/godef
+	GO111MODULE=on go get github.com/sqs/goreturns
+	GO111MODULE=on go get github.com/uudashr/gopkgs/v2/cmd/gopkgs
+	GO111MODULE=on go get github.com/zmb3/gogetdoc
+	GO111MODULE=on go get golang.org/x/lint/golint
+	GO111MODULE=on go get golang.org/x/tools/cmd/gorename
+	GO111MODULE=on go get github.com/go-delve/delve/cmd/dlv
 }
 
 main() {

docs/nightly.md

@@ -4,8 +4,6 @@ This master branch of this extension is built and published nightly through the
 
 [Go Nightly] is the **preview** version of the Go extension, so it may be broken or unstable at times. The [Changelog](nightly/CHANGELOG.md) and [README](nightly/README.md) for [Go Nightly] can be found in the [docs/nightly](nightly/) directory.
 
-If you try out [Go Nightly], please file issues when you notice bugs. You can also join the maintainers in the [#vscode-dev](https://gophers.slack.com/archives/CUWGEKH5Z) channel on the [Gophers Slack](https://invite.slack.golangbridge.org/).
-
 ## Installation
 
 To use the [Go Nightly] extension (`golang.go-nightly`), you **must** first disable the standard Go extension (`golang.go`). The two are not compatible and will cause conflicts if enabled simultaneously.
@@ -16,6 +14,14 @@ Otherwise, you can disable it temporarily. To do so, open the Extensions view in
 
 Once you have uninstalled or disabled the standard Go extension, search for [Go Nightly] in the VS Code Marketplace and install it instead.
 
+## Feedback
+
+If you use [Go Nightly], please share your feedback or bug reports by [filing an issue]. You can also speak to the maintainers directly in the [#vscode-dev](https://gophers.slack.com/archives/CUWGEKH5Z) channel on the [Gophers Slack].
+
+### Community
+
+Go Nightly users are encouraged to discuss issues and share feedback in the [#vscode-go-nightly](https://gophers.slack.com/archives/C01DQ2KBMNU) channel on [Gophers Slack] or on the [Go Nightly mailing list](https://groups.google.com/g/vscode-go-nightly). The VS Code Go maintainers may send communications to these channels to request feedback as well.
+
 ## Releases
 
 A new version of [Go Nightly], based on the repository's current [`master` branch](https://go.googlesource.com/vscode-go/+/refs/heads/master), will be released at least once a day between Monday and Thursday. If there are no new commits at master, a new version **will not** be released.
@@ -33,3 +39,5 @@ Pre-releases of the Go extension will be made available on the [Releases page](h
 **Note**: If you install an extension from a VSIX file, you will stop receiving automatic prompts when updates are released.
 
 [Go Nightly]: https://marketplace.visualstudio.com/items?itemName=golang.go-nightly
+[filing an issue]: https://github.com/golang/vscode-go/issues/new/choose
+[Gophers Slack]: https://invite.slack.golangbridge.org/

docs/settings.md

@@ -29,6 +29,7 @@ Default:{<br/>
 &nbsp;&nbsp;`"options": "json=omitempty"`,<br/>
 &nbsp;&nbsp;`"promptForTags": false`,<br/>
 &nbsp;&nbsp;`"tags": "json"`,<br/>
+&nbsp;&nbsp;`"template": ""`,<br/>
 &nbsp;&nbsp;`"transform": "snakecase"`,<br/>
     }