Skip to content

Commit dfefea0

Browse files
quoctruonghyangah
authored andcommitted
[release] debugAdapter: fix a bug where we are not sending back configuration done response
This change is to address this bug: eclipse-theia/theia#8455. The Go extension is not able to continue past after hitting the breakpoint because `setConfigurationDoneRequest` is not sending back a response if the program is already running. This keeps Theia waiting for the response (which it never receives!). Change-Id: Ie416638793d4c4505d9dd6b9e34753b60188ac5d GitHub-Last-Rev: 5423aae GitHub-Pull-Request: #641 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/254959 Run-TryBot: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Trust: Quoc Truong <[email protected]> Trust: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: kokoro <[email protected]> (cherry picked from commit 29cee47) Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/255677 Reviewed-by: Quoc Truong <[email protected]>
1 parent 6f67a37 commit dfefea0

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/debugAdapter/goDebug.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -872,13 +872,15 @@ export class GoDebugSession extends LoggingDebugSession {
872872
if (this.stopOnEntry) {
873873
this.sendEvent(new StoppedEvent('entry', 1));
874874
log('StoppedEvent("entry")');
875-
this.sendResponse(response);
876875
} else {
877876
this.debugState = await this.delve.getDebugState();
878877
if (!this.debugState.Running) {
879-
this.continueRequest(<DebugProtocol.ContinueResponse>response);
878+
log('Changing DebugState from Halted to Running');
879+
this.continue();
880880
}
881881
}
882+
this.sendResponse(response);
883+
log('ConfigurationDoneResponse', response);
882884
}
883885

884886
/**

0 commit comments

Comments
 (0)