[release] prepare v0.18.0 release @9e91b75

9e91b75 test: extract helper function for checking variable value
59e1356 src/goMain: try both gc_details and gopls_gc_details
26d2a33 src/debugAdapter: indicate that conditional breakpoints are supported
8fc4183 src/goLanguageServer: enable survey for the go extension users
6703469 src/debugAdapter: revert cl/253578
d2fbb62 debugAdapter: Fix bugs that cause remote debug to hang
c17c69f src/goModules: exclude vendor paths from inferGopath disable mechanism
0cdccf1 test: increase timeout for debug adapter tests
6a2a004 test: fix breakpoint tests on windows
7d5f58a test: add go directive to fixtures
9e6fac4 src/goInstallTools: prompt again after showing 'release notes'
d57f263 test: adjust tests involving 'check*' when language server is on
560405b src/goInstallTools.ts: handle stderr of go env
8f08cfd src/goEnvironmentStatus.ts: allow to choose go from file browser
263c427 test: test the debug adapter on test launch configurations
51a4b3a test: disconnect from the debug adapter after each test
5b25666 package.json: upgrade vscode-languageclient to use 7.0.0-next.9
a587fea src/goMain.ts: call gc_details command through vscode API
0aea0bf CHANGELOG.md: cherry-pick v0.17.1/v0.17.2 CHANGELOG changes
acf2483 src/util.ts: handle diagnostics errors for all visible files
0c3ec39 docs: improve documentation for debugging CLI applications
7e58c56 snippets: add a placeholder for the for loop index
cfa00f0 test: add debug adapter tests
ec96bd7 src/goStatus.ts: refactor status bar code into goStatus.ts
b2692c9 src/debugAdapter: send terminated event when program exits
70f7a71 src/goLanguageServer.ts: enable language server by default in nightly
39c9a2e build/all.bash: install dependencies without -v
473c0fc vs-code tasks: missed comma in the snippet
89f5d4e goLanguageServer: send the gopls config as initialization options
b6aeab4 goModules: set "go.useLanguageServer" to true if the user installs it
1b82f49 src/goEnvironmentStatus.ts: clear pre-installed terminal PATH mutation
9bf9d64 src/goInstallTools.ts: add GOROOT/bin to PATH when it wasn't found from PATH
50240bf LICENSE: restore LICENSE
dbb38c5 goLanguageServer: correctly reflect modifications to the survey config
690469c src/goStatus.ts: consolidate Go status bar items
9ab1e77 src/goMain.ts: call listeners for active text editor on init
a2c7402 goLanguageServer: add command to toggle gc_details
ab4b257 src/goInstallTools.ts: mutate PATH only when necessary
e0ce53b docs/debugging.md: document lack of symlink support
c65170a docs/stdlib.md: clarify the change in the go.alternateTools section
8e9cae7 src/goInstallTools.ts: return a rejected promise when go isn't found
18cfe6e src/debugAdapter: add 'panic' and 'fatal error' as stopped reasons
f9daaad src/goLogging.ts: add go.logging.level and log PATH mutation
9ebcc1f src/goLanguageServer.ts: include sanitized trace to issue report
9d97bb5 src/debugAdapter: delete unused launch.json
8d0bafa package.json: default 'go.coverMode' to be 'default'
ed434b2 Merge "[latest] v0.17.0"
e2dedc0 [latest] v0.17.0
5c4b766 src/debugAdapter: remove null items in variables response for maps
29cee47 debugAdapter: fix a bug where we are not sending back configuration done response
5879a3e test/gopls: fix completion middleware test
59858d7 src/goDebugConfiguration.ts: add resolveDebugConfiguration back
9a2bc10 src/debugAdapter: send stopped events from continue on breakpoint only
d34fee8 docs/debugging.md: update remote debugging documentation
a5e0287 build/all.bash: build vscode-test-env from the root
c929a2b [latest] v0.16.2
2fe721b [latest] v0.16.1
586c956 [latest] v0.15.2
dc45442 [latest] v0.15.1 release
eab00f7 [latest] v0.15.0 release

Change-Id: If2f9a073a8a86754044e85671d5527b04d7c7ae4

Author: hyangah

LICENSE

@@ -76,9 +76,7 @@ prepare_nightly() {
 .displayName="Go Nightly" |
 .publisher="golang" |
 .description="Rich Go language support for Visual Studio Code (Nightly)" |
-.author.name="Go Team at Google" |
-.repository.url="https://github.com/golang/vscode-go" |
-.bugs.url="https://github.com/golang/vscode-go/issues"
+.contributes.configuration.properties."go.useLanguageServer".default=true
 ') > /tmp/package.json && mv /tmp/package.json package.json
 
   # Replace CHANGELOG.md with CHANGELOG.md + Release commit info.
@@ -91,20 +89,20 @@ prepare_nightly() {
 
 # setup dependencies required for tests.
 install_dependencies() {
-	GO111MODULE=on go get -x -v golang.org/x/tools/gopls
-	GO111MODULE=on go get -x -v github.com/acroca/go-symbols
-	GO111MODULE=on go get -x -v github.com/cweill/gotests/...
-	GO111MODULE=on go get -x -v github.com/davidrjenni/reftools/cmd/fillstruct
-	GO111MODULE=on go get -x -v github.com/haya14busa/goplay/cmd/goplay
-	GO111MODULE=on go get -x -v github.com/mdempsky/gocode
-	GO111MODULE=on go get -x -v github.com/ramya-rao-a/go-outline
-	GO111MODULE=on go get -x -v github.com/rogpeppe/godef
-	GO111MODULE=on go get -x -v github.com/sqs/goreturns
-	GO111MODULE=on go get -x -v github.com/uudashr/gopkgs/v2/cmd/gopkgs
-	GO111MODULE=on go get -x -v github.com/zmb3/gogetdoc
-	GO111MODULE=on go get -x -v golang.org/x/lint/golint
-	GO111MODULE=on go get -x -v golang.org/x/tools/cmd/gorename
-	GO111MODULE=on go get -x -v github.com/go-delve/delve/cmd/dlv
+	GO111MODULE=on go get -x golang.org/x/tools/gopls
+	GO111MODULE=on go get -x github.com/acroca/go-symbols
+	GO111MODULE=on go get -x github.com/cweill/gotests/...
+	GO111MODULE=on go get -x github.com/davidrjenni/reftools/cmd/fillstruct
+	GO111MODULE=on go get -x github.com/haya14busa/goplay/cmd/goplay
+	GO111MODULE=on go get -x github.com/mdempsky/gocode
+	GO111MODULE=on go get -x github.com/ramya-rao-a/go-outline
+	GO111MODULE=on go get -x github.com/rogpeppe/godef
+	GO111MODULE=on go get -x github.com/sqs/goreturns
+	GO111MODULE=on go get -x github.com/uudashr/gopkgs/v2/cmd/gopkgs
+	GO111MODULE=on go get -x github.com/zmb3/gogetdoc
+	GO111MODULE=on go get -x golang.org/x/lint/golint
+	GO111MODULE=on go get -x golang.org/x/tools/cmd/gorename
+	GO111MODULE=on go get -x github.com/go-delve/delve/cmd/dlv
 }
 
 main() {

build/all.bash

@@ -91,6 +91,10 @@ Generates unit tests for the selected function in the current file
 
 Generates method stub for implementing the provided interface and inserts at the cursor.
 
+### `Go: Toggle gc details`
+
+Toggle the display of compiler optimization choices
+
 ### `Go: Add Import`
 
 Add an import declaration

docs/commands.md

@@ -24,21 +24,21 @@ As a next step, you may want to debug the Debug Adapter, in order to understand
 **NOTE: Since the Debug Adapter runs in a separate process from the rest of the extension, the steps below only enable you to debug the Debug Adapter code, not the entire extension. To debug the entire extension, as well as the debug adapter, see the instructions [below](#debug-the-entire-extension).**
 
 1. Open the `vscode-go` folder in VS Code.
-2. Go the Run view and choose the `Launch as server` debug configuration.
+2. Go to the Run view and choose the `Launch as server` debug configuration.
 3. Add breakpoints as needed to the [`vscode-go/src/debugAdapter/goDebug.ts`](../src/debugAdapter/goDebug.ts) file.
 4. Open another instance of VS Code and open the Go project to debug.
 5. Create a debug configuration for the Go project if it doesn't exist. Set `"debugServer": 4711` in the root of the configuration.
 6. Start debugging your Go program using this configuration. This will trigger the breakpoints in [`goDebug.ts`](../src/debugAdapter/goDebug.ts) file.
 
 ## Debug the entire extension, including the Debug Adapter
 
-You should take this step if your change modifies both the Debug Adapter and the main extension. This setup requires three instances of VS Code.
+You can take this step if your change modifies both the Debug Adapter and the main extension.
 
-1. Open the root [`vscode-go`](../) folder in one instance of VS Code.
-2. Choose the `Launch Extension` debug target and run it (F5). This will launch the second instance of VS Code.
-3. In this second instance, open the Go application you'd like to debug. Here, as above, create a debug configuration pointing to the program you want to debug. Add `"debugServer": 4711` to the root of the configuration.
-4. Open the [`vscode-go/src/debugAdapter`](../src/debugAdapter) folder in a third VS Code instance. Select the `Launch as server` configuration and run it (`F5`).
-5. Return to the second VS Code instance with the Go program. Run the debug configuration (`F5`). Debuggers from the other two VS Code windows are attached to the Debug Adapter and the Go extension, so you can set breakpoints, step through code, and inspect state as needed.
+1. Open the `vscode-go` folder in VS Code.
+2. Go to the Run view and choose the `Extension + Debug server` debug configuration. This combines `Launch Extension` and `Launch as server` debug configurations.
+3. Add breakpoints as needed and start debugging (`F5`). It will start an Extension Development Host window and the Debug Adapter server process at port 4711. Debuggers are attached to both processes and the breakpoints will apply to both of them.
+4. In the Extension Development Host window, open the Go application source code you'd like to debug. Here, as above, create a debug configuration pointing to the program you want to debug. Add `"debugServer": 4711` to the root of the configuration. Then, run the debug configuration (`F5`), which will start debugging of the Go application.
+5. Combined debug information (call stacks, breakpoints, etc) of the debugged Extension Development Host and the Debug Adapter will be displayed in the debug view of the original VS Code window. You can use the dropdown menu in the Debug toolbar to switch between the two instances (`Launch Extension` and `Launch as server`).
 
 ## Debug VS Code and the Debug Adapter
 

docs/debug-adapter.md

@@ -103,13 +103,14 @@ type       | Always leave this set to `"go"`. VS Code uses this setting to deter
 request    | One of `launch` or `attach`. Use `attach` when you want to attach to a running process.
 mode       | For `launch` requests, one of `auto`, `debug`, `remote`, `test`, or `exec`. For `attach` requests, use `local` or `remote`.
 program    | In `test` or `debug` mode, this refers to the absolute path to the package or file to debug. In `exec` mode, this is the existing binary file to debug. Not applicable to `attach` requests.
-env        | Environment variables to use when debugging. Use the format: `{ "NAME": "VALUE" }`.
+env        | Environment variables to use when debugging. Use the format: `{ "NAME": "VALUE" }`. Not applicable to `attach` requests.
 envFile    | Absolute path to a file containing environment variable definitions. The environment variables passed in via the `env` property override the ones in this file.
 args       | Array of command-line arguments to pass to the program being debugged.
 showLog    | If `true`, Delve logs will be printed in the Debug Console panel.
 logOutput  | Comma-separated list of Delve components (`debugger`, `gdbwire`, `lldbout`, `debuglineerr`, `rpc`) that should produce debug output when `showLog` is `true`.
 buildFlags | Build flags to pass to the Go compiler.
-remotePath | If remote debugging (`mode`: `remote`), this should be the absolute path to the file being debugged on the remote machine. See the section on [Remote Debugging](#remote-debugging) for further details. [golang/vscode-go#45](https://github.com/golang/vscode-go/issues/45) is also relevant.
+remotePath | If remote debugging (`mode`: `remote`), this should be the absolute path to the package being debugged on the remote machine. See the section on [Remote Debugging](#remote-debugging) for further details. [golang/vscode-go#45](https://github.com/golang/vscode-go/issues/45) is also relevant.
+cwd | The working directory to be used in running the program. If remote debugging (`mode`: `remote`), this should be the absolute path to the working directory being debugged on the local machine. See the section on [Remote Debugging](#remote-debugging) for further details. [golang/vscode-go#45](https://github.com/golang/vscode-go/issues/45) is also relevant.
 processId  | This is the process ID of the executable you want to debug. Applicable only when using the `attach` request in `local` mode.
 
 ### Specifying [build tags](https://golang.org/pkg/go/build/#hdr-Build_Constraints)
@@ -238,6 +239,19 @@ There is no snippet suggestion for this configuration.
 }
 ```
 
+If passing arguments to or calling subcommands and flags from a binary, the `args` property can be used.
+
+```json
+{
+    "name": "Launch executable",
+    "type": "go",
+    "request": "launch",
+    "mode": "exec",
+    "program": "/absolute/path/to/executable",
+    "args": ["subcommand", "arg", "--flag"],
+}
+```
+
 ## Debugging on [Windows Subsystem for Linux (WSL)](https://docs.microsoft.com/en-us/windows/wsl/)
 
 If you are using using WSL, you will need the WSL 2 Linux kernel.  See [WSL 2 Installation](https://docs.microsoft.com/en-us/windows/wsl/wsl2-install) and note the Window 10 build version requirements.
@@ -266,21 +280,18 @@ Then, create a remote debug configuration in your `launch.json`.
 {
     "name": "Launch remote",
     "type": "go",
-    "request": "launch",
+    "request": "attach",
     "mode": "remote",
-    "remotePath": "/absolute/path/file/on/remote/machine",
+    "remotePath": "/absolute/path/dir/on/remote/machine",
     "port": 2345,
     "host": "127.0.0.1",
-    "program": "/absolute/path/file/on/local/machine",
-    "env": {}
+    "cwd": "/absolute/path/dir/on/local/machine",
 }
 ```
 
 In the example, the VS Code debugger will run on the same machine as the headless `dlv` server. Make sure to update the `port` and `host` settings to point to your remote machine.
 
-`remotePath` should point to the absolute path of the file being debugged in the remote machine. See [golang/vscode-go#126](https://github.com/golang/vscode-go/issues/126) for updates regarding `remotePath`.
-
-`program` should point to the absolute path of the file on your local machine. This should be the counterpart of the file in `remotePath`.
+`remotePath` should point to the absolute path of the program being debugged in the remote machine. `cwd` should point to the absolute path of the working directory of the program being debugged on your local machine. This should be the counterpart of the folder in `remotePath`. See [golang/vscode-go#45](https://github.com/golang/vscode-go/issues/45) for updates regarding `remotePath` and `cwd`.
 
 When you run the `Launch remote` target, VS Code will send debugging commands to the `dlv` server you started, instead of launching it's own `dlv` instance against your program.
 
@@ -375,6 +386,12 @@ Docker has security settings preventing `ptrace(2)` operations by default within
 
 This error can show up for Mac users using Delve versions 0.12.2 and above. `xcode-select --install` has solved the problem for a number of users.
 
+### Debugging symlink directories
+
+This extension does not provide support for debugging projects containing symlinks. Make sure that you are setting breakpoints in the files that Go will use to compile your program.
+
+For updates to symlink support reference [golang/vscode-go#622](https://github.com/golang/vscode-go/issues/622).
+
 [Delve]: https://github.com/go-delve/delve
 [VS Code variables]: https://code.visualstudio.com/docs/editor/variables-reference
 [snippets]: https://code.visualstudio.com/docs/editor/userdefinedsnippets

docs/debugging.md

@@ -2,7 +2,7 @@
 
 ## Using The Go Status Bar
 
-You can view the current Go version by looking at the status bar item in the bottom left corner of VS Code. Clicking this button will present you with a menu from which you can select any version of Go that exists in your $HOME/sdk directory or on <https://golang.org/dl>.
+You can view the current Go version by looking at the status bar item in the bottom left corner of VS Code. Clicking this button and selecting `Choose Go Environment` will present you with a menu from which you can select any version of Go that exists in your $HOME/sdk directory or on <https://golang.org/dl>. This command is also available through the command pallette using `Go: Choose Go Environment`.
 
 Previously, the `go.goroot` and `go.alternateTools` settings controlled the Go version used by VS Code Go. If you have configured these settings, they are no longer needed and should be deleted.
 

docs/go-version.md

@@ -292,6 +292,14 @@ Default:{<br/>
     }
 
 
+### `go.logging.level`
+
+The logging level the extension logs at, defaults to 'error'
+
+Allowed Values:`[off error info verbose]`
+
+Default: `error`
+
 ### `go.overwriteGoplsMiddleware`
 
 This option provides a set of flags which determine if vscode-go should intercept certain commands from gopls. These flags assume the `gopls` settings, which enable codelens from gopls, are also present.

docs/settings.md

@@ -6,25 +6,36 @@ First, you **must open the `src/` folder in VS Code**, not the Go tree root.
 (See [golang/go#32394](https://github.com/golang/go/issues/32394).)
 
 Then, you need to configure the workspace, by placing the following in `src/.vscode/settings.json`.
+[Command Palette](https://code.visualstudio.com/docs/getstarted/userinterface#_command-palette)
+-> `Preferences: Open Workspace Settings (JSON)` will open the setting file.
 
 ```json5
 {
-    // Use the local go tool. This needs to be built with make.bash.
-    "go.alternateTools": {
-        "go": "~/godev/bin/go"
-    },
-    // Build a separate set of tools. For golang/vscode-go#294.
-    "go.toolsGopath": "~/.vscode/godev",
-    // Don't reformat HTML files since we have a custom style.
-    "html.format.enable": false,
+  // Use the local go tool. This needs to be built with make.bash.
+  "go.alternateTools": {
+    "go": "~/godev/bin/go"
+  },
+
+  //
+  // Below is optional.
+  //
+  // Build a separate set of tools. For golang/vscode-go#294.
+  "go.toolsGopath": "~/.vscode/godev",
+  // Don't reformat HTML files since we have a custom style.
+  "html.format.enable": false
 }
 ```
 
 The above assumes the Go tree is checked out at `~/godev`. If your Go tree is somewhere else, modify
-`go.alternateTools.go` accordingly.
+`go.alternateTools.go` to point to the go *binary* accordingly. Many underlying tools
+including `gopls` invoke the go command (`go list`, etc), so we assume the binary isn't 
+completely broken.
 
 You can add `.vscode` to `.git/info/exclude` to avoid risking checking `settings.json` into git.
 
+The Go language server ([`gopls`](https://golang.org/s/gopls)) works for developing the standard
+library. To enable it, please read our [`gopls` documentation](gopls.md).
+
 If you see an "inconsistent vendoring" error, please report it at
 [golang/go#40250](https://github.com/golang/go/issues/40250).
 

docs/stdlib.md

@@ -65,7 +65,7 @@ If you want to invoke tools other than `go`, you will have to move the `"command
             "label": "run",
             "command": "go",
             "args": ["run", "${file}"],
-            "group": "build"
+            "group": "build",
             "type": "shell",
         },
         {