[release] merge master@8aab1a2 into release branch

Change-Id: Ib5639453c6e973e6f23c7e4711b0b5a3121012f3

Author: hyangah

.github/workflows/codeql-analysis.yml

@@ -40,37 +40,36 @@ jobs:
       - name: Compile
         run: npm run vscode:prepublish
 
+      # TODO: use prerelease versions of tools (how? or master?)
+
       - name: Install Go tools (Modules mode)
         run: |
             go version
-            go get github.com/acroca/go-symbols \
-               github.com/davidrjenni/reftools/cmd/fillstruct \
-               github.com/haya14busa/goplay/cmd/goplay \
-               github.com/mdempsky/gocode \
-               github.com/sqs/goreturns \
-               github.com/uudashr/gopkgs/v2/cmd/gopkgs \
-               github.com/zmb3/gogetdoc \
-               golang.org/x/lint/golint \
-               golang.org/x/tools/cmd/gorename \
-               golang.org/x/tools/gopls
-
+            go get github.com/acroca/go-symbols
+            go get github.com/davidrjenni/reftools/cmd/fillstruct
+            go get github.com/haya14busa/goplay/cmd/goplay
+            go get github.com/mdempsky/gocode
+            go get github.com/sqs/goreturns
+            go get github.com/uudashr/gopkgs/v2/cmd/gopkgs
+            go get github.com/zmb3/gogetdoc
+            go get golang.org/x/lint/golint
+            go get golang.org/x/tools/cmd/gorename
+            go get golang.org/x/tools/gopls
         env:
-          GO111MODULE: on
-
+          GO111MODULE: on   
+          
       - name: Install Go tools (GOPATH mode)
         run: |
           go version
-          go get github.com/cweill/gotests/... \
-            github.com/rogpeppe/godef \
-            github.com/ramya-rao-a/go-outline
+          go get github.com/cweill/gotests/...
+          go get github.com/rogpeppe/godef
+          go get github.com/ramya-rao-a/go-outline
             # Because some tests depend on the source code checked in GOPATH. TODO: FIX THEM.
         env:
           GO111MODULE: off
 
-
       - name: Run unit tests
         run: npm run unit-test
-        continue-on-error: true
 
       - name: Run tests
         uses: GabrielBB/[email protected]

.github/workflows/release-nightly.yml

@@ -21,20 +21,20 @@ name: Release (golang.go)
 #    the 'Release (golang.go)' workflow specified in this file.
 #      - For stable version release (vX.X.X), check if the package.json has the matching version.
 #      - Packaging using 'vsce package'
-#      - Create a release in Github
+#      - Create a release in GitHub
 #      - Upload the vsix file as an asset of the release
 #      - For stable version release (vX.X.X), upload to the vscode market place
-#        (not implemented in this CL)
 
 on:
   push:
     tags:
       - v*
 
 jobs:
-  build:
+  release:
     name: create release
     runs-on: ubuntu-latest
+    if: github.repository == 'golang/vscode-go'
 
     steps:
       - name: checkout code
@@ -95,6 +95,14 @@ jobs:
           asset_path: ./go-${{ env.EXT_VERSION }}.vsix
           asset_name: go-${{ env.EXT_VERSION }}.vsix
           asset_content_type: application/zip
+
+      - name: publish
+        if: env.EXT_ISPREVIEW != 1 && github.repository == 'golang/vscode-go'
+        uses: lannonbr/vsce-action@704da577da0f27de5cdb4ae018374c2f08b5f523
+        with:
+          args: "publish -p $VSCE_TOKEN"
+        env:
+          VSCE_TOKEN: ${{ secrets.VSCE_TOKEN }}
+
 # TODO: check if the commit is in green state. (test-long.yml results)
-# TODO: publish to the market if VERSION is for a stable version.
 # TODO: after publishing, create a gerrit CL to update 'latest' branch if VERSION is for a stable version.

.github/workflows/release.yml

@@ -69,7 +69,6 @@ jobs:
 
       - name: Run unit tests
         run: npm run unit-test
-        continue-on-error: true
 
       - name: Run tests
         uses: GabrielBB/[email protected]

.github/workflows/test-long.yml

@@ -65,7 +65,6 @@ jobs:
 
       - name: Run unit tests
         run: npm run unit-test
-        continue-on-error: true
 
       - name: Run tests
         uses: GabrielBB/[email protected]

.github/workflows/test-smoke.yml

@@ -1,4 +1,5 @@
-out
-node_modules
-.vscode-test
+out/
+dist/
+node_modules/
+.vscode-test/
 .DS_Store

.gitignore

@@ -1,7 +1,6 @@
 {
 	"version": "0.2.0",
 	"configurations": [
-		
 		{
 			"name": "Launch Extension",
 			"type": "extensionHost",
@@ -12,27 +11,45 @@
 				"--extensionDevelopmentPath=${workspaceFolder}",
 				"--disable-extensions"
 			],
+			"outFiles": [
+                "${workspaceFolder}/dist/**/*.js"
+            ],
 			"stopOnEntry": false,
 			"sourceMaps": true,
+			"smartStep": true,
+			"preLaunchTask": "npm: webpack",
+		},
+		{
+			"name": "Launch as server",
+			"type": "node",
+			"protocol": "inspector",
+			"request": "launch",
+			"program": "${workspaceFolder}/dist/debugAdapter.js",
+			"args": [
+				"--server=4711"
+			],
 			"outFiles": [
-				"${workspaceFolder}/out/**/*.js"
+				"${workspaceFolder}/dist/**/*.js"
 			],
-			"preLaunchTask": "npm: watch"
+			"sourceMaps": true,
+			"smartStep": true,
+			"preLaunchTask": "npm: webpack"
 		},
 		{
-			"name": "Launch as server",
+			"name": "Launch as server (dlv dap)",
 			"type": "node",
 			"protocol": "inspector",
 			"request": "launch",
-			"program": "${workspaceFolder}/out/src/debugAdapter/goDebug.js",
+			"program": "${workspaceFolder}/dist/debugAdapter2.js",
 			"args": [
 				"--server=4711"
 			],
 			"sourceMaps": true,
+			"smartStep": true,
 			"outFiles": [
-				"${workspaceFolder}/out/**/*.js"
+				"${workspaceFolder}/dist/**/*.js"
 			],
-			"preLaunchTask": "npm"
+			"preLaunchTask": "npm: webpack"
 		},
 		{
 			"name": "Launch Extension Tests",
@@ -49,6 +66,7 @@
 			],
 			"stopOnEntry": false,
 			"sourceMaps": true,
+			"smartStep": true,
 			"outFiles": [
 				"${workspaceFolder}/out/test/**/*.js"
 			],
@@ -87,7 +105,8 @@
 				"--colors",
 				"${workspaceFolder}/out/test/unit"
 			],
-			"internalConsoleOptions": "openOnSessionStart"
+			"internalConsoleOptions": "openOnSessionStart",
+			"preLaunchTask": "npm: watch",
 		},
 	],
 	"compounds": [
@@ -99,4 +118,4 @@
 			]
 		}
 	]
-}
+}

.travis.yml

@@ -1,18 +1,19 @@
-src/**/*
-test/
-third_party/
-typings/**/*
-.vscode/**/*
-tsconfig.json
-.gitignore
-node_modules/fs-extra
 **/*.map
 **/tslint.json
-build/**/*
-docs/
-*.md.nightly
 .github/**/*
+.gitignore
 .prettierrc.json
-out/test/**
 .vscode-test/**
+.vscode/
 SECURITY.md
+build/
+docs/
+node_modules
+out/
+src/
+test/
+third_party/
+tools/
+tsconfig.json
+typings/
+webpack.config.js

.vscode/launch.json

@@ -345,15 +345,15 @@ The solution this issue differs based on your OS.
 
 #### OSX
 
-This usually happens on OSX due to signing issues. See the discussions in [Microsoft/vscode-go#717](https://github.com/Microsoft/vscode-go/issues/717), [Microsoft/vscode-go#269](https://github.com/Microsoft/vscode-go/issues/269) and [derekparker/delve#357](https://github.com/derekparker/delve/issues/357).
+This usually happens on OSX due to signing issues. See the discussions in [Microsoft/vscode-go#717](https://github.com/Microsoft/vscode-go/issues/717), [Microsoft/vscode-go#269](https://github.com/Microsoft/vscode-go/issues/269) and [go-delve/delve#357](https://github.com/go-delve/delve/issues/357).
 
-**_Solution_**: You may have to uninstall dlv and install it manually as described in the [Delve instructions](https://github.com/derekparker/delve/blob/master/Documentation/installation/osx/install.md#manual-install).
+**_Solution_**: You may have to uninstall dlv and install it manually as described in the [Delve instructions](https://github.com/go-delve/delve/blob/master/Documentation/installation/osx/install.md#manual-install).
 
 #### Linux/Docker
 
 Docker has security settings preventing `ptrace(2)` operations by default within the container.
 
-**_Solution_**: To run your container insecurely, pass `--security-opt=seccomp:unconfined` to `docker run`. See [derekparker/delve#515](https://github.com/derekparker/delve/issues/515) for references.
+**_Solution_**: To run your container insecurely, pass `--security-opt=seccomp:unconfined` to `docker run`. See [go-delve/delve#515](https://github.com/go-delve/delve/issues/515) for references.
 
 #### could not launch process: exec: "lldb-server": executable file not found in $PATH