package.json: delete go.overwriteGoplsMiddleware setting

This option has been marked as 'deprecated' for a while.
We always overwrite codelens info from gopls to invoke
extension's own test/benchmark commands.

Change-Id: I3e1f802c5588847fef3f1576b457a9a360ab08ba
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/304775
Trust: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Suzy Mueller <[email protected]>
TryBot-Result: kokoro <[email protected]>

Author: hyangah

docs/settings.md

@@ -344,14 +344,6 @@ The logging level the extension logs at, defaults to 'error'<br/>
 Allowed Options: `off`, `error`, `info`, `verbose`
 
 Default: `"error"`
-### `go.overwriteGoplsMiddleware (deprecated)`
-
-This option is deprecated.
-This option provides a set of flags which determine if vscode-go should intercept certain commands from gopls. These flags assume the `gopls` settings, which enable codelens from gopls, are also present.
-| Properties | Description |
-| --- | --- |
-| `codelens` |  |
-| `default` |  |
 ### `go.playground`
 
 The flags configured here will be passed through to command `goplay`

package.json

@@ -1424,35 +1424,6 @@
           "description": "Feature level setting to enable/disable code lens for references and run/debug tests",
           "scope": "resource"
         },
-        "go.overwriteGoplsMiddleware": {
-          "type": "object",
-          "properties": {
-            "codelens": {
-              "type": "object",
-              "properties": {
-                "test": {
-                  "type": "boolean",
-                  "default": false,
-                  "description": "'test' codelens will be handled by gopls if true"
-                },
-                "bench": {
-                  "type": "boolean",
-                  "default": false,
-                  "description": "'benchmark' codelens will be handled by gopls if true"
-                }
-              }
-            },
-            "default": {
-              "codelens": {
-                "test": false,
-                "bench": false
-              }
-            }
-          },
-          "scope": "resource",
-          "deprecationMessage": "This option is deprecated.",
-          "description": "This option provides a set of flags which determine if vscode-go should intercept certain commands from gopls. These flags assume the `gopls` settings, which enable codelens from gopls, are also present."
-        },
         "go.addTags": {
           "type": "object",
           "properties": {

src/goLanguageServer.ts

@@ -551,19 +551,12 @@ export async function buildLanguageClient(cfg: BuildLanguageClientOption): Promi
 					if (!codeLens || codeLens.length === 0) {
 						return codeLens;
 					}
-					const goplsEnabledLens = (getGoConfig().get('overwriteGoplsMiddleware') as any)?.codelens ?? {};
 					return codeLens.reduce((lenses: vscode.CodeLens[], lens: vscode.CodeLens) => {
 						switch (lens.command.title) {
 							case 'run test': {
-								if (goplsEnabledLens.test) {
-									return [...lenses, lens];
-								}
 								return [...lenses, ...createTestCodeLens(lens)];
 							}
 							case 'run benchmark': {
-								if (goplsEnabledLens.bench) {
-									return [...lenses, lens];
-								}
 								return [...lenses, ...createBenchmarkCodeLens(lens)];
 							}
 							default: {