Skip to content

Commit e5a31d1

Browse files
committed
chore: add more TODOs
1 parent b3da57f commit e5a31d1

File tree

4 files changed

+18
-7
lines changed

4 files changed

+18
-7
lines changed

.github/workflows/codeql.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,14 @@ name: "Code Scanning - Action"
22

33
on:
44
push:
5-
branches: [ master ]
5+
branches:
6+
- master
7+
- main
68
pull_request:
79
# The branches below must be a subset of the branches above
8-
branches: [ master ]
10+
branches:
11+
- master
12+
- main
913
schedule:
1014
- cron: '0 17 * * 5'
1115

.github/workflows/test.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
11
name: "build-and-test"
22
on: # rebuild any PRs and main branch changes
33
pull_request:
4+
branches:
5+
- master
6+
- main
47
push:
58
branches:
69
- master
10+
- main
711
- "releases/*"
812

913
jobs:
@@ -53,8 +57,8 @@ jobs:
5357
version:
5458
- ""
5559
- "latest"
56-
- "v1.60"
57-
- "v1.60.1"
60+
- "v1.60" # TODO(ldez): it should be updated for v2.
61+
- "v1.60.1" # TODO(ldez): it should be updated for v2.
5862
runs-on: ${{ matrix.os }}
5963
permissions:
6064
contents: read
@@ -82,8 +86,8 @@ jobs:
8286
version:
8387
- ""
8488
- "latest"
85-
- "v1.60.1"
86-
- "adbdfdb288e939a175182b7a12b7555215ce98b2"
89+
- "v1.60.1" # TODO(ldez): it should be updated for v2.
90+
- "adbdfdb288e939a175182b7a12b7555215ce98b2" # TODO(ldez): it should be updated for v2.
8791
runs-on: ${{ matrix.os }}
8892
permissions:
8993
contents: read

src/install.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,14 @@ export async function goInstall(versionConfig: VersionConfig): Promise<string> {
9191

9292
const options: ExecOptions = { env: { ...process.env, CGO_ENABLED: "1" } }
9393

94+
// TODO(ldez): it should be updated for v2.
9495
const exres = await execShellCommand(
9596
`go install github.com/golangci/golangci-lint/cmd/golangci-lint@${versionConfig.TargetVersion}`,
9697
options
9798
)
9899
printOutput(exres)
99100

101+
// TODO(ldez): it should be updated for v2.
100102
const res = await execShellCommand(
101103
`go install -n github.com/golangci/golangci-lint/cmd/golangci-lint@${versionConfig.TargetVersion}`,
102104
options

src/version.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,8 @@ export async function findLintVersion(mode: InstallMode): Promise<VersionConfig>
135135

136136
if (mode == InstallMode.GoInstall) {
137137
const v: string = core.getInput(`version`)
138-
// TODO(ldez): latest should be replaced with an explicit version (ex: v1.64.0)
138+
// TODO(ldez): latest should be replaced with an explicit version (ex: v1.64.0).
139+
// TODO(ldez): AssetURL should be updated for v2.
139140
return { TargetVersion: v ? v : "latest", AssetURL: "github.com/golangci/golangci-lint" }
140141
}
141142

0 commit comments

Comments
 (0)