fix: toStaticCheckSettings

Signed-off-by: sivchari <[email protected]>

Author: sivchari

pkg/commands/internal/migrate/migrate_linters_settings.go

@@ -789,10 +789,22 @@ func toSpancheckSettings(old versionone.SpancheckSettings) versiontwo.SpancheckS
 }
 
 func toStaticCheckSettings(old versionone.LintersSettings) versiontwo.StaticCheckSettings {
-	checks := slices.Concat(old.Staticcheck.Checks, old.Stylecheck.Checks, old.Gosimple.Checks)
+	checks := Unique(slices.Concat(old.Staticcheck.Checks, old.Stylecheck.Checks, old.Gosimple.Checks))
+	// If an element is prefixed with `-` it means that we want to disable that check.
+	// So we have to resort and put everything after the non-minus elements.
+	slices.SortFunc(checks, func(e1, e2 string) int {
+		if strings.HasPrefix(e1, "-") && !strings.HasPrefix(e2, "-") {
+			return 1
+		}
+
+		if !strings.HasPrefix(e1, "-") && strings.HasPrefix(e2, "-") {
+			return -1
+		}
+		return strings.Compare(e1, e2)
+	})
 
 	return versiontwo.StaticCheckSettings{
-		Checks:                  Unique(checks),
+		Checks:                  checks,
 		Initialisms:             old.Stylecheck.Initialisms,
 		DotImportWhitelist:      old.Stylecheck.DotImportWhitelist,
 		HTTPStatusCodeWhitelist: old.Stylecheck.HTTPStatusCodeWhitelist,

pkg/commands/internal/migrate/migrate_linters_settings_test.go

@@ -0,0 +1,26 @@
+package migrate
+
+import (
+	"testing"
+
+	"github.com/golangci/golangci-lint/v2/pkg/commands/internal/migrate/versionone"
+	"github.com/golangci/golangci-lint/v2/pkg/commands/internal/migrate/versiontwo"
+	"github.com/google/go-cmp/cmp"
+)
+
+func Test_toStaticCheckSettings(t *testing.T) {
+	old := versionone.LintersSettings{
+		Staticcheck: versionone.StaticCheckSettings{
+			Checks: []string{"all", "-SA1000"},
+		},
+	}
+	new := toStaticCheckSettings(old)
+
+	expected := versiontwo.StaticCheckSettings{
+		Checks: []string{"all", "-SA1000"},
+	}
+
+	if diff := cmp.Diff(new, expected); diff != "" {
+		t.Errorf("toStaticCheckSettings() mismatch (-got +want):\n%s", diff)
+	}
+}