Change writeFixedFile to replace the right line-range.

csilvers · csilvers · commit 06d26d5c12d5 · 2020-01-22T09:14:40.000-08:00
The function assumed, previously, that issue.Line always equals
issue.LineRange.From.  But this needn't be true, and the code needn't
assume it.  Now we actually replace the specified line-range.
diff --git a/pkg/result/processors/fixer.go b/pkg/result/processors/fixer.go
@@ -218,7 +218,7 @@ func (f Fixer) writeFixedFile(origFileLines [][]byte, issues []result.Issue, tmp
 		}
 
 		origFileLineNumber := i + 1
-		if nextIssue == nil || origFileLineNumber != nextIssue.Line() {
+		if nextIssue == nil || origFileLineNumber != nextIssue.GetLineRange().From {
 			outLine = string(origFileLines[i])
 		} else {
 			nextIssueIndex++

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ func (f Fixer) writeFixedFile(origFileLines [][]byte, issues []result.Issue, tmp`
`218`	`218`	`}`
`219`	`219`
`220`	`220`	`origFileLineNumber := i + 1`
`221`		`- if nextIssue == nil \|\| origFileLineNumber != nextIssue.Line() {`
	`221`	`+ if nextIssue == nil \|\| origFileLineNumber != nextIssue.GetLineRange().From {`
`222`	`222`	`outLine = string(origFileLines[i])`
`223`	`223`	`} else {`
`224`	`224`	`nextIssueIndex++`