fix: formatters shound't be enabled/disabled as linters (#5516)

Author: ldez

.golangci.yml

@@ -199,4 +199,10 @@ formatters:
     goimports:
       local-prefixes:
         - github.com/golangci/golangci-lint
-
+  exclusions:
+    paths:
+      - test/testdata_etc # test files
+      - internal/go # extracted from Go code
+      - internal/x # extracted from x/tools code
+      - pkg/goformatters/gci/internal # extracted from gci code
+      - pkg/goanalysis/runner_checker.go # extracted from x/tools code

internal/go/cache/cache.go

@@ -22,9 +22,10 @@ import (
 	"strings"
 	"time"
 
+	"github.com/rogpeppe/go-internal/lockedfile"
+
 	"github.com/golangci/golangci-lint/internal/go/mmap"
 	"github.com/golangci/golangci-lint/internal/go/robustio"
-	"github.com/rogpeppe/go-internal/lockedfile"
 )
 
 // An ActionID is a cache action key, the hash of a complete description of a

pkg/config/linters.go

@@ -1,5 +1,10 @@
 package config
 
+import (
+	"fmt"
+	"slices"
+)
+
 const (
 	GroupStandard = "standard"
 	GroupAll      = "all"
@@ -21,6 +26,8 @@ type Linters struct {
 func (l *Linters) Validate() error {
 	validators := []func() error{
 		l.Exclusions.Validate,
+		l.validateNoFormattersEnabled,
+		l.validateNoFormattersDisabled,
 	}
 
 	for _, v := range validators {
@@ -31,3 +38,27 @@ func (l *Linters) Validate() error {
 
 	return nil
 }
+
+func (l *Linters) validateNoFormattersEnabled() error {
+	for _, n := range l.Enable {
+		if slices.Contains(getAllFormatterNames(), n) {
+			return fmt.Errorf("%s is a formatter", n)
+		}
+	}
+
+	return nil
+}
+
+func (l *Linters) validateNoFormattersDisabled() error {
+	for _, n := range l.Disable {
+		if slices.Contains(getAllFormatterNames(), n) {
+			return fmt.Errorf("%s is a formatter", n)
+		}
+	}
+
+	return nil
+}
+
+func getAllFormatterNames() []string {
+	return []string{"gci", "gofmt", "gofumpt", "goimports"}
+}

pkg/config/loader.go

@@ -167,9 +167,13 @@ func (l *Loader) handleEnableOnlyOption() error {
 
 	if len(only) > 0 {
 		l.cfg.Linters = Linters{
-			Enable:  only,
-			Default: GroupNone,
+			Default:    GroupNone,
+			Enable:     only,
+			Settings:   l.cfg.Linters.Settings,
+			Exclusions: l.cfg.Linters.Exclusions,
 		}
+
+		l.cfg.Formatters = Formatters{}
 	}
 
 	return nil

pkg/goformatters/gofumpt/gofumpt.go

@@ -37,10 +37,5 @@ func (f *Formatter) Format(_ string, src []byte) ([]byte, error) {
 }
 
 func getLangVersion(v string) string {
-	if v == "" {
-		// TODO: defaults to "1.15", in the future (v2) must be removed.
-		return "go1.15"
-	}
-
 	return "go" + strings.TrimPrefix(v, "go")
 }

pkg/golinters/gci/testdata/fix/in/gci.go

@@ -1,4 +1,3 @@
-//golangcitest:args -Egci
 //golangcitest:config_path testdata/gci.yml
 //golangcitest:expected_exitcode 0
 package gci

pkg/golinters/gci/testdata/fix/out/gci.go

@@ -1,4 +1,3 @@
-//golangcitest:args -Egci
 //golangcitest:config_path testdata/gci.yml
 //golangcitest:expected_exitcode 0
 package gci

pkg/golinters/gci/testdata/gci.go

@@ -1,4 +1,3 @@
-//golangcitest:args -Egci
 //golangcitest:config_path testdata/gci.yml
 package testdata
 

pkg/golinters/gci/testdata/gci_cgo.go

@@ -1,4 +1,3 @@
-//golangcitest:args -Egci
 //golangcitest:config_path testdata/gci.yml
 package testdata
 

pkg/golinters/gci/testdata/gci_go124.go

@@ -1,6 +1,6 @@
 //go:build go1.24
 
-//golangcitest:args -Egci
+//golangcitest:config_path testdata/gci_go124.yml
 //golangcitest:expected_exitcode 0
 package testdata