chore: new concurrency default

Author: ldez

.golangci.next.reference.yml

@@ -4186,8 +4186,8 @@ run:
   go: '1.19'
 
   # Number of operating system threads (`GOMAXPROCS`) that can execute golangci-lint simultaneously.
-  # If it is explicitly set to 0 (i.e. not the default) then golangci-lint will automatically set the value to match Linux container CPU quota.
-  # Default: the number of logical CPUs in the machine
+  # Default: automatically set to match Linux container CPU quota and
+  # fall back to the number of logical CPUs in the machine.
   concurrency: 4
 
 

pkg/commands/flagsets.go

@@ -42,8 +42,9 @@ func setupFormattersFlagSet(v *viper.Viper, fs *pflag.FlagSet) {
 }
 
 func setupRunFlagSet(v *viper.Viper, fs *pflag.FlagSet) {
-	internal.AddFlagAndBindP(v, fs, fs.IntP, "concurrency", "j", "run.concurrency", getDefaultConcurrency(),
-		color.GreenString("Number of CPUs to use (Default: number of logical CPUs)"))
+	internal.AddFlagAndBindP(v, fs, fs.IntP, "concurrency", "j", "run.concurrency", 0,
+		color.GreenString("Number of CPUs to use (Default: Automatically set to match Linux container CPU quota,"+
+			" fall backs on number of logical CPUs)"))
 
 	internal.AddFlagAndBind(v, fs, fs.String, "modules-download-mode", "run.modules-download-mode", "",
 		color.GreenString("Modules download mode. If not empty, passed as -mod=<mode> to go tools"))

pkg/commands/run.go

@@ -161,6 +161,7 @@ func (c *runCommand) persistentPreRunE(cmd *cobra.Command, args []string) error
 	}
 
 	if c.cfg.Run.Concurrency == 0 {
+		// `runtime.GOMAXPROCS` defaults to the value of `runtime.NumCPU`.
 		backup := runtime.GOMAXPROCS(0)
 
 		// Automatically set GOMAXPROCS to match Linux container CPU quota.
@@ -590,16 +591,6 @@ func setupRunPersistentFlags(fs *pflag.FlagSet, opts *runOptions) {
 	fs.StringVar(&opts.TracePath, "trace-path", "", color.GreenString("Path to trace output file"))
 }
 
-func getDefaultConcurrency() int {
-	if os.Getenv(envHelpRun) == "1" {
-		// Make stable concurrency for generating help documentation.
-		const prettyConcurrency = 8
-		return prettyConcurrency
-	}
-
-	return runtime.NumCPU()
-}
-
 func printMemStats(ms *runtime.MemStats, logger logutils.Log) {
 	logger.Infof("Mem stats: alloc=%s total_alloc=%s sys=%s "+
 		"heap_alloc=%s heap_sys=%s heap_idle=%s heap_released=%s heap_in_use=%s "+