review

Author: ldez

pkg/commands/internal/migrate/migrate_linters_settings.go

@@ -351,7 +351,27 @@ func toGoCriticSettings(old versionone.GoCriticSettings) versiontwo.GoCriticSett
 			settings.SettingsPerCheck = make(map[string]versiontwo.GoCriticCheckSettings)
 		}
 
-		settings.SettingsPerCheck[k] = versiontwo.GoCriticCheckSettings(checkSettings)
+		if k != "ruleguard" {
+			settings.SettingsPerCheck[k] = versiontwo.GoCriticCheckSettings(checkSettings)
+
+			continue
+		}
+
+		gccs := versiontwo.GoCriticCheckSettings{}
+
+		for sk, value := range checkSettings {
+			if sk != "rules" {
+				gccs[sk] = value
+
+				continue
+			}
+
+			if rules, ok := value.(string); ok {
+				gccs[sk] = strings.ReplaceAll(rules, "${configDir}", "${base-path}")
+			}
+		}
+
+		settings.SettingsPerCheck[k] = gccs
 	}
 
 	return settings

pkg/commands/internal/migrate/testdata/linters-settings_gocritic.golden.yml

@@ -254,7 +254,7 @@ linters:
           disable: myGroupName,#myTagName
           enable: myGroupName,#myTagName
           failon: dsl,import
-          rules: ${configDir}/ruleguard/rules-*.go,${configDir}/myrule1.go
+          rules: ${base-path}/ruleguard/rules-*.go,${base-path}/myrule1.go
         toomanyresultschecker:
           maxresults: 10
         truncatecmp: