review

Author: ldez

pkg/golinters/arangolint/testdata/arangolint.go

@@ -1,13 +1,13 @@
 //golangcitest:args -Earangolint
-package testdata
+package arangolint
 
 import (
 	"context"
 
 	"github.com/arangodb/go-driver/v2/arangodb"
 )
 
-func example() {
+func _() {
 	ctx := context.Background()
 	arangoClient := arangodb.NewClient(nil)
 	db, _ := arangoClient.GetDatabase(ctx, "name", nil)
@@ -32,16 +32,4 @@ func example() {
 	// direct with other fields
 	db.BeginTransaction(ctx, arangodb.TransactionCollections{}, &arangodb.BeginTransactionOptions{AllowImplicit: true, LockTimeout: 0})
 	trx, _ = db.BeginTransaction(ctx, arangodb.TransactionCollections{}, &arangodb.BeginTransactionOptions{AllowImplicit: true, LockTimeout: 0})
-
-	// indirect no pointer
-	// options := arangodb.BeginTransactionOptions{LockTimeout: 0}
-	// db.BeginTransaction(ctx, arangodb.TransactionCollections{}, &options) // w@nt "missing AllowImplicit option"
-	// options.AllowImplicit = true
-	// db.BeginTransaction(ctx, arangodb.TransactionCollections{}, &options)
-	//
-	// indirect pointer
-	// optns := &arangodb.BeginTransactionOptions{LockTimeout: 0}
-	// db.BeginTransaction(ctx, arangodb.TransactionCollections{}, optns) // w@nt "missing AllowImplicit option"
-	// options.AllowImplicit = true
-	// db.BeginTransaction(ctx, arangodb.TransactionCollections{}, optns)
 }

pkg/golinters/arangolint/testdata/arangolint_cgo.go

@@ -1,5 +1,5 @@
 //golangcitest:args -Earangolint
-package testdata
+package arangolint
 
 /*
  #include <stdio.h>
@@ -28,7 +28,25 @@ func _() {
 	ctx := context.Background()
 	arangoClient := arangodb.NewClient(nil)
 	db, _ := arangoClient.GetDatabase(ctx, "name", nil)
-	trx, _ := db.BeginTransaction(ctx, arangodb.TransactionCollections{}, &arangodb.BeginTransactionOptions{LockTimeout: 0}) // want "missing AllowImplicit option"
-	db.BeginTransaction(ctx, arangodb.TransactionCollections{}, &arangodb.BeginTransactionOptions{AllowImplicit: false})
+
+	// direct nil
+	db.BeginTransaction(ctx, arangodb.TransactionCollections{}, nil)           // want "missing AllowImplicit option"
+	trx, _ := db.BeginTransaction(ctx, arangodb.TransactionCollections{}, nil) // want "missing AllowImplicit option"
 	_ = trx
+
+	// direct missing
+	db.BeginTransaction(ctx, arangodb.TransactionCollections{}, &arangodb.BeginTransactionOptions{LockTimeout: 0})          // want "missing AllowImplicit option"
+	trx, _ = db.BeginTransaction(ctx, arangodb.TransactionCollections{}, &arangodb.BeginTransactionOptions{LockTimeout: 0}) // want "missing AllowImplicit option"
+
+	// direct false
+	db.BeginTransaction(ctx, arangodb.TransactionCollections{}, &arangodb.BeginTransactionOptions{AllowImplicit: false})
+	trx, _ = db.BeginTransaction(ctx, arangodb.TransactionCollections{}, &arangodb.BeginTransactionOptions{AllowImplicit: false})
+
+	// direct true
+	db.BeginTransaction(ctx, arangodb.TransactionCollections{}, &arangodb.BeginTransactionOptions{AllowImplicit: true})
+	trx, _ = db.BeginTransaction(ctx, arangodb.TransactionCollections{}, &arangodb.BeginTransactionOptions{AllowImplicit: true})
+
+	// direct with other fields
+	db.BeginTransaction(ctx, arangodb.TransactionCollections{}, &arangodb.BeginTransactionOptions{AllowImplicit: true, LockTimeout: 0})
+	trx, _ = db.BeginTransaction(ctx, arangodb.TransactionCollections{}, &arangodb.BeginTransactionOptions{AllowImplicit: true, LockTimeout: 0})
 }

pkg/golinters/arangolint/testdata/go.mod

@@ -1,4 +1,4 @@
-module testdata
+module arangolint
 
 go 1.23.0