tests: add wsl_v5 tests

Author: ldez

pkg/golinters/wsl/testdata/fix/in/wsl_v5.go

@@ -0,0 +1,78 @@
+//golangcitest:args -Ewsl_v5
+//golangcitest:expected_exitcode 0
+package testdata
+
+import (
+	"bytes"
+	"encoding/json"
+)
+
+type T struct {
+	I int
+}
+
+func NewT() *T {
+	return &T{}
+}
+
+func (*T) Fn() int {
+	return 1
+}
+
+func FnC(_ string, fn func() error) error {
+	fn()
+	return nil
+}
+
+func strictAppend() {
+	s := []string{}
+	s = append(s, "a")
+	s = append(s, "b")
+	x := "c"
+	s = append(s, x)
+	y := "e"
+	s = append(s, "d") // want `missing whitespace above this line \(no shared variables above append\)`
+	s = append(s, y)
+}
+
+func incDec() {
+	x := 1
+	x++
+	x--
+	y := x
+
+	_ = y
+}
+
+func assignAndCall() {
+	t1 := NewT()
+	t2 := NewT()
+
+	t1.Fn()
+	x := t1.Fn()
+	t1.Fn()
+
+	_, _ = t2, x
+}
+
+func closureInCall() {
+	buf := &bytes.Buffer{}
+	_ = FnC("buf", func() error {
+		return json.NewEncoder(buf).Encode("x")
+	})
+}
+
+func assignAfterBlock() {
+	x := 1
+	if x > 0 {
+		return
+	}
+	x = 2 // want `missing whitespace above this line \(invalid statement above assign\)`
+}
+
+func decl() {
+	var x string
+	y := "" // want `missing whitespace above this line \(invalid statement above assign\)`
+
+	_, _ = x, y
+}

pkg/golinters/wsl/testdata/fix/out/wsl_v5.go

@@ -0,0 +1,81 @@
+//golangcitest:args -Ewsl_v5
+//golangcitest:expected_exitcode 0
+package testdata
+
+import (
+	"bytes"
+	"encoding/json"
+)
+
+type T struct {
+	I int
+}
+
+func NewT() *T {
+	return &T{}
+}
+
+func (*T) Fn() int {
+	return 1
+}
+
+func FnC(_ string, fn func() error) error {
+	fn()
+	return nil
+}
+
+func strictAppend() {
+	s := []string{}
+	s = append(s, "a")
+	s = append(s, "b")
+	x := "c"
+	s = append(s, x)
+	y := "e"
+
+	s = append(s, "d") // want `missing whitespace above this line \(no shared variables above append\)`
+	s = append(s, y)
+}
+
+func incDec() {
+	x := 1
+	x++
+	x--
+	y := x
+
+	_ = y
+}
+
+func assignAndCall() {
+	t1 := NewT()
+	t2 := NewT()
+
+	t1.Fn()
+	x := t1.Fn()
+	t1.Fn()
+
+	_, _ = t2, x
+}
+
+func closureInCall() {
+	buf := &bytes.Buffer{}
+	_ = FnC("buf", func() error {
+		return json.NewEncoder(buf).Encode("x")
+	})
+}
+
+func assignAfterBlock() {
+	x := 1
+	if x > 0 {
+		return
+	}
+
+	x = 2 // want `missing whitespace above this line \(invalid statement above assign\)`
+}
+
+func decl() {
+	var x string
+
+	y := "" // want `missing whitespace above this line \(invalid statement above assign\)`
+
+	_, _ = x, y
+}

pkg/golinters/wsl/testdata/wsl_v5.go

@@ -0,0 +1,77 @@
+//golangcitest:args -Ewsl_v5
+package testdata
+
+import (
+	"bytes"
+	"encoding/json"
+)
+
+type T struct {
+	I int
+}
+
+func NewT() *T {
+	return &T{}
+}
+
+func (*T) Fn() int {
+	return 1
+}
+
+func FnC(_ string, fn func() error) error {
+	fn()
+	return nil
+}
+
+func strictAppend() {
+	s := []string{}
+	s = append(s, "a")
+	s = append(s, "b")
+	x := "c"
+	s = append(s, x)
+	y := "e"
+	s = append(s, "d") // want `missing whitespace above this line \(no shared variables above append\)`
+	s = append(s, y)
+}
+
+func incDec() {
+	x := 1
+	x++
+	x--
+	y := x
+
+	_ = y
+}
+
+func assignAndCall() {
+	t1 := NewT()
+	t2 := NewT()
+
+	t1.Fn()
+	x := t1.Fn()
+	t1.Fn()
+
+	_, _ = t2, x
+}
+
+func closureInCall() {
+	buf := &bytes.Buffer{}
+	_ = FnC("buf", func() error {
+		return json.NewEncoder(buf).Encode("x")
+	})
+}
+
+func assignAfterBlock() {
+	x := 1
+	if x > 0 {
+		return
+	}
+	x = 2 // want `missing whitespace above this line \(invalid statement above assign\)`
+}
+
+func decl() {
+	var x string
+	y := "" // want `missing whitespace above this line \(invalid statement above assign\)`
+
+	_, _ = x, y
+}

pkg/golinters/wsl/testdata/wsl_v5_config.go

@@ -0,0 +1,13 @@
+//golangcitest:args -Ewsl_v5
+//golangcitest:config_path testdata/wsl_v5_config.yml
+package testdata
+
+func fn1(s []string) {
+	a := "a"
+	s = append(s, a)
+
+	x := 1
+	s = append(s, "s") // want `missing whitespace above this line \(no shared variables above append\)`
+
+	_ = x
+}

pkg/golinters/wsl/testdata/wsl_v5_config.yml

@@ -0,0 +1,10 @@
+version: "2"
+
+linters:
+  settings:
+  wsl_v5:
+    allow-first-in-block: true
+    allow-whole-block: false
+    branch-max-lines: 2
+    case-max-lines: 0
+    default: all