Skip to content

Commit 310150d

Browse files
committed
tests: update integration tests
1 parent 000fdf1 commit 310150d

File tree

4 files changed

+20
-23
lines changed

4 files changed

+20
-23
lines changed

test/output_test.go

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ func TestOutput_lineNumber(t *testing.T) {
2121
testshared.NewRunnerBuilder(t).
2222
WithArgs(
2323
"--disable-all",
24-
"--print-issued-lines=false",
25-
"--print-linter-name=false",
26-
"--out-format=line-number",
24+
"--output.text.print-issued-lines=false",
25+
"--output.text.print-linter-name=false",
26+
"--output.text.path=stdout",
2727
).
2828
WithDirectives(sourcePath).
2929
WithTargetPath(sourcePath).
@@ -40,9 +40,7 @@ func TestOutput_Stderr(t *testing.T) {
4040
testshared.NewRunnerBuilder(t).
4141
WithArgs(
4242
"--disable-all",
43-
"--print-issued-lines=false",
44-
"--print-linter-name=false",
45-
"--out-format=json:stderr",
43+
"--output.json.path=stderr",
4644
).
4745
WithDirectives(sourcePath).
4846
WithTargetPath(sourcePath).
@@ -60,9 +58,7 @@ func TestOutput_File(t *testing.T) {
6058
testshared.NewRunnerBuilder(t).
6159
WithArgs(
6260
"--disable-all",
63-
"--print-issued-lines=false",
64-
"--print-linter-name=false",
65-
fmt.Sprintf("--out-format=json:%s", resultPath),
61+
fmt.Sprintf("--output.json.path=%s", resultPath),
6662
).
6763
WithDirectives(sourcePath).
6864
WithTargetPath(sourcePath).
@@ -82,9 +78,10 @@ func TestOutput_Multiple(t *testing.T) {
8278
testshared.NewRunnerBuilder(t).
8379
WithArgs(
8480
"--disable-all",
85-
"--print-issued-lines=false",
86-
"--print-linter-name=false",
87-
"--out-format=line-number,json:stdout",
81+
"--output.text.print-issued-lines=false",
82+
"--output.text.print-linter-name=false",
83+
"--output.text.path=stdout",
84+
"--output.json.path=stdout",
8885
).
8986
WithDirectives(sourcePath).
9087
WithTargetPath(sourcePath).

test/run_test.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ func TestLineDirectiveProcessedFiles(t *testing.T) {
269269
{
270270
desc: "lite loading",
271271
args: []string{
272-
"--print-issued-lines=false",
272+
"--output.text.print-issued-lines=false",
273273
"--exclude-use-default=false",
274274
"-Erevive",
275275
},
@@ -284,7 +284,7 @@ func TestLineDirectiveProcessedFiles(t *testing.T) {
284284
{
285285
desc: "full loading",
286286
args: []string{
287-
"--print-issued-lines=false",
287+
"--output.text.print-issued-lines=false",
288288
"--exclude-use-default=false",
289289
"-Erevive,govet",
290290
},
@@ -351,7 +351,7 @@ func TestSortedResults(t *testing.T) {
351351

352352
testshared.NewRunnerBuilder(t).
353353
WithNoConfig().
354-
WithArgs("--print-issued-lines=false", test.opt).
354+
WithArgs("--output.text.print-issued-lines=false", test.opt).
355355
WithTargetPath(testdataDir, "sort_results").
356356
WithBinPath(binPath).
357357
Runner().
@@ -367,7 +367,7 @@ func TestSkippedDirsNoMatchArg(t *testing.T) {
367367
testshared.NewRunnerBuilder(t).
368368
WithNoConfig().
369369
WithArgs(
370-
"--print-issued-lines=false",
370+
"--output.text.print-issued-lines=false",
371371
"--exclude-dirs", dir,
372372
"-Erevive",
373373
).
@@ -384,7 +384,7 @@ func TestSkippedDirsTestdata(t *testing.T) {
384384
testshared.NewRunnerBuilder(t).
385385
WithNoConfig().
386386
WithArgs(
387-
"--print-issued-lines=false",
387+
"--output.text.print-issued-lines=false",
388388
"-Erevive",
389389
).
390390
WithTargetPath(testdataDir, "skipdirs", "...").
@@ -504,7 +504,7 @@ func TestAbsPathDirAnalysis(t *testing.T) {
504504
testshared.NewRunnerBuilder(t).
505505
WithNoConfig().
506506
WithArgs(
507-
"--print-issued-lines=false",
507+
"--output.text.print-issued-lines=false",
508508
"-Erevive",
509509
).
510510
WithTargetPath(absDir).
@@ -523,7 +523,7 @@ func TestAbsPathFileAnalysis(t *testing.T) {
523523
testshared.NewRunnerBuilder(t).
524524
WithNoConfig().
525525
WithArgs(
526-
"--print-issued-lines=false",
526+
"--output.text.print-issued-lines=false",
527527
"-Erevive",
528528
).
529529
WithTargetPath(absDir).

test/testshared/integration/fix.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ func runFix(t *testing.T, extraArgs ...string) {
6767

6868
testshared.NewRunnerBuilder(t).
6969
WithArgs("--disable-all",
70-
"--print-issued-lines=false",
71-
"--print-linter-name=false",
72-
"--out-format=line-number",
70+
"--output.text.print-issued-lines=false",
71+
"--output.text.print-linter-name=false",
72+
"--output.text.path=stdout",
7373
"--fix").
7474
WithArgs(extraArgs...).
7575
WithRunContext(rc).

test/testshared/integration/run.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ func testOneSource(t *testing.T, log *logutils.StderrLog, binPath, sourcePath st
6363

6464
args := []string{
6565
"--disable-all",
66-
"--out-format=json",
66+
"--output.json.path=stdout",
6767
"--max-same-issues=100",
6868
"--max-issues-per-linter=100",
6969
}

0 commit comments

Comments
 (0)