review

ldez · ldez · commit 38ef65affe23 · 2024-12-18T13:46:59.000+01:00
diff --git a/pkg/result/processors/fixer.go b/pkg/result/processors/fixer.go
@@ -77,7 +77,6 @@ func (p Fixer) process(issues []result.Issue) ([]result.Issue, error) {
 		issue := issues[i]
 
 		if issue.SuggestedFixes == nil || skipNoTextEdit(&issue) {
-			println("Fixing", len(issues), "issues")
 			notFixableIssues = append(notFixableIssues, issue)
 			continue
 		}
@@ -199,15 +198,13 @@ func (p Fixer) printStat() {
 
 func skipNoTextEdit(issue *result.Issue) bool {
 	var onlyMessage int
-	var count int
 	for _, sf := range issue.SuggestedFixes {
 		if len(sf.TextEdits) == 0 {
 			onlyMessage++
 		}
-		count++
 	}
 
-	return count == onlyMessage
+	return len(issue.SuggestedFixes) == onlyMessage
 }
 
 // validateEdits returns a list of edits that is sorted and

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,6 @@ func (p Fixer) process(issues []result.Issue) ([]result.Issue, error) {`
`77`	`77`	`issue := issues[i]`
`78`	`78`
`79`	`79`	`if issue.SuggestedFixes == nil \|\| skipNoTextEdit(&issue) {`
`80`		`- println("Fixing", len(issues), "issues")`
`81`	`80`	`notFixableIssues = append(notFixableIssues, issue)`
`82`	`81`	`continue`
`83`	`82`	`}`
`@@ -199,15 +198,13 @@ func (p Fixer) printStat() {`
`199`	`198`
`200`	`199`	`func skipNoTextEdit(issue *result.Issue) bool {`
`201`	`200`	`var onlyMessage int`
`202`		`- var count int`
`203`	`201`	`for _, sf := range issue.SuggestedFixes {`
`204`	`202`	`if len(sf.TextEdits) == 0 {`
`205`	`203`	`onlyMessage++`
`206`	`204`	`}`
`207`		`- count++`
`208`	`205`	`}`
`209`	`206`
`210`		`- return count == onlyMessage`
	`207`	`+ return len(issue.SuggestedFixes) == onlyMessage`
`211`	`208`	`}`
`212`	`209`
`213`	`210`	`// validateEdits returns a list of edits that is sorted and`