Skip to content

Commit 44bf197

Browse files
authored
fix regression: update thelper to v0.2.1 (#1639)
1 parent e5a395b commit 44bf197

File tree

3 files changed

+22
-3
lines changed

3 files changed

+22
-3
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ require (
3131
github.com/jgautheron/goconst v0.0.0-20201117150253-ccae5bf973f3
3232
github.com/jingyugao/rowserrcheck v0.0.0-20191204022205-72ab7603b68a
3333
github.com/jirfag/go-printf-func-name v0.0.0-20191110105641-45db9963cdd3
34-
github.com/kulti/thelper v0.2.0
34+
github.com/kulti/thelper v0.2.1
3535
github.com/kunwardeep/paralleltest v1.0.2
3636
github.com/kyoh86/exportloopref v0.1.8
3737
github.com/maratori/testpackage v1.0.1

go.sum

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/testdata/thelper.go

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,22 @@ func bhelperWithNotFirst(s string, b *testing.B, i int) { // ERROR "parameter \*
2828
func bhelperWithIncorrectName(o *testing.B) { // ERROR "parameter \*testing.B should have name b"
2929
o.Helper()
3030
}
31+
32+
func TestSubtestShouldNotBeChecked(t *testing.T) {
33+
testCases := []struct {
34+
desc string
35+
}{
36+
{
37+
desc: "example",
38+
},
39+
}
40+
41+
for _, test := range testCases {
42+
test := test
43+
t.Run(test.desc, func(t *testing.T) {
44+
t.Parallel()
45+
46+
t.Error("test")
47+
})
48+
}
49+
}

0 commit comments

Comments
 (0)