review

Author: ldez

pkg/commands/internal/migrate/migrate_linters_settings.go

@@ -789,20 +789,29 @@ func toSpancheckSettings(old versionone.SpancheckSettings) versiontwo.SpancheckS
 }
 
 func toStaticCheckSettings(old versionone.LintersSettings) versiontwo.StaticCheckSettings {
-	checks := slices.Compact(
-		slices.SortedFunc(
-			slices.Values(
-				slices.Concat(old.Staticcheck.Checks, old.Stylecheck.Checks, old.Gosimple.Checks),
-			),
-			func(a, b string) int {
-				if a == "*" || a == "all" {
-					return 1
-				}
-
-				return strings.Compare(a, b)
-			},
-		),
-	)
+	var checks []string
+
+	for _, check := range slices.Concat(old.Staticcheck.Checks, old.Stylecheck.Checks, old.Gosimple.Checks) {
+		if check == "*" {
+			checks = append(checks, "all")
+			continue
+		}
+		checks = append(checks, check)
+	}
+
+	checks = Unique(checks)
+
+	slices.SortFunc(checks, func(a, b string) int {
+		if a == "all" {
+			return -1
+		}
+
+		if b == "all" {
+			return 1
+		}
+
+		return strings.Compare(a, b)
+	})
 
 	return versiontwo.StaticCheckSettings{
 		Checks:                  checks,

pkg/commands/internal/migrate/testdata/yaml/linters-settings_staticcheck_merge.golden.yml

@@ -3,7 +3,7 @@ linters:
   settings:
     staticcheck:
       checks:
-        - '*'
+        - all
         - -S1000
         - -S1001
         - -S1002
@@ -152,7 +152,6 @@ linters:
         - ST1021
         - ST1022
         - ST1023
-        - all
       initialisms:
         - ACL
         - API