review: add fix tests

Author: ldez

pkg/golinters/embeddedstructfieldcheck/embeddedstructfieldcheck_integration_test.go

@@ -9,3 +9,11 @@ import (
 func TestFromTestdata(t *testing.T) {
 	integration.RunTestdata(t)
 }
+
+func TestFix(t *testing.T) {
+	integration.RunFix(t)
+}
+
+func TestFixPathPrefix(t *testing.T) {
+	integration.RunFixPathPrefix(t)
+}

pkg/golinters/embeddedstructfieldcheck/testdata/fix/in/comments.go

@@ -0,0 +1,39 @@
+//golangcitest:args -Eembeddedstructfieldcheck
+//golangcitest:expected_exitcode 0
+package testdata
+
+import "time"
+
+type ValidStructWithSingleLineComments struct {
+	// time.Time Single line comment
+	time.Time
+
+	// version Single line comment
+	version int
+}
+
+type StructWithSingleLineComments struct {
+	// time.Time Single line comment
+	time.Time // want `there must be an empty line separating embedded fields from regular fields`
+
+	// version Single line comment
+	version int
+}
+
+type StructWithMultiLineComments struct {
+	// time.Time Single line comment
+	time.Time // want `there must be an empty line separating embedded fields from regular fields`
+
+	// version Single line comment
+	// very long comment
+	version int
+}
+
+type A struct {
+	// comment
+	ValidStructWithSingleLineComments
+	// C is foo
+	StructWithSingleLineComments // want `there must be an empty line separating embedded fields from regular fields`
+
+	D string
+}

pkg/golinters/embeddedstructfieldcheck/testdata/fix/in/simple.go

@@ -0,0 +1,23 @@
+//golangcitest:args -Eembeddedstructfieldcheck
+//golangcitest:expected_exitcode 0
+package testdata
+
+import (
+	"time"
+)
+
+type ValidStruct struct {
+	time.Time
+
+	version int
+}
+
+type NoSpaceStruct struct {
+	time.Time // want `there must be an empty line separating embedded fields from regular fields`
+	version   int
+}
+
+type EmbeddedWithPointers struct {
+	*time.Time // want `there must be an empty line separating embedded fields from regular fields`
+	version    int
+}

pkg/golinters/embeddedstructfieldcheck/testdata/fix/out/comments.go

@@ -0,0 +1,39 @@
+//golangcitest:args -Eembeddedstructfieldcheck
+//golangcitest:expected_exitcode 0
+package testdata
+
+import "time"
+
+type ValidStructWithSingleLineComments struct {
+	// time.Time Single line comment
+	time.Time
+
+	// version Single line comment
+	version int
+}
+
+type StructWithSingleLineComments struct {
+	// time.Time Single line comment
+	time.Time // want `there must be an empty line separating embedded fields from regular fields`
+
+	// version Single line comment
+	version int
+}
+
+type StructWithMultiLineComments struct {
+	// time.Time Single line comment
+	time.Time // want `there must be an empty line separating embedded fields from regular fields`
+
+	// version Single line comment
+	// very long comment
+	version int
+}
+
+type A struct {
+	// comment
+	ValidStructWithSingleLineComments
+	// C is foo
+	StructWithSingleLineComments // want `there must be an empty line separating embedded fields from regular fields`
+
+	D string
+}

pkg/golinters/embeddedstructfieldcheck/testdata/fix/out/simple.go

@@ -0,0 +1,25 @@
+//golangcitest:args -Eembeddedstructfieldcheck
+//golangcitest:expected_exitcode 0
+package testdata
+
+import (
+	"time"
+)
+
+type ValidStruct struct {
+	time.Time
+
+	version int
+}
+
+type NoSpaceStruct struct {
+	time.Time // want `there must be an empty line separating embedded fields from regular fields`
+
+	version int
+}
+
+type EmbeddedWithPointers struct {
+	*time.Time // want `there must be an empty line separating embedded fields from regular fields`
+
+	version int
+}