fix: improve HTTP download error handling for wget and curl

- Updated `http_download_curl` to log HTTP errors using `log_err` instead of `log_debug`.
- Modified `http_download_wget` to check HTTP status codes, mirroring curl's behavior.
- Return exit status 1 for non-200 responses in `http_download_wget`.
- Standardized error logging across both download functions.

Author: tjasko

install.sh

@@ -301,7 +301,7 @@ http_download_curl() {
     code=$(curl -w '%{http_code}' -sL -H "$header" -o "$local_file" "$source_url")
   fi
   if [ "$code" != "200" ]; then
-    log_debug "http_download_curl received HTTP status $code"
+    log_err "http_download_curl received HTTP status $code"
     return 1
   fi
   return 0
@@ -311,20 +311,20 @@ http_download_wget() {
   source_url=$2
   header=$3
   if [ -z "$header" ]; then
-    wget -q -O "$local_file" "$source_url"
+    code=$(wget --server-response --quiet -O "$local_file" "$source_url" 2>&1 | awk '/^  HTTP/{print $2}' | tail -n1)
   else
-    wget -q --header "$header" -O "$local_file" "$source_url"
+    code=$(wget --server-response --quiet --header "$header" -O "$local_file" "$source_url" 2>&1 | awk '/^  HTTP/{print $2}' | tail -n1)
   fi
+  if [ "$code" != "200" ]; then
+    log_err "http_download_wget received HTTP status $code"
+    return 1
+  fi
+  return 0
 }
 http_download() {
   log_debug "http_download $2"
-  if is_command curl; then
-    http_download_curl "$@"
-    return
-  elif is_command wget; then
-    http_download_wget "$@"
-    return
-  fi
+  http_download_wget "$@"
+  return
   log_crit "http_download unable to find wget or curl"
   return 1
 }