review

Author: ldez

pkg/commands/internal/migrate/migrate_linter_names.go

@@ -927,6 +927,10 @@ func convertAlternativeNames(names []string) []string {
 	var results []string
 
 	for _, name := range names {
+		if name == "typecheck" {
+			continue
+		}
+
 		if n, ok := altNames[name]; ok {
 			results = append(results, n)
 			continue

pkg/commands/internal/migrate/migrate_severity.go

@@ -9,9 +9,14 @@ func toSeverity(old *versionone.Config) versiontwo.Severity {
 	var rules []versiontwo.SeverityRule
 
 	for _, rule := range old.Severity.Rules {
+		names := convertStaticcheckLinterNames(convertAlternativeNames(rule.Linters))
+		if len(rule.Linters) > 0 && len(names) == 0 {
+			continue
+		}
+
 		rules = append(rules, versiontwo.SeverityRule{
 			BaseRule: versiontwo.BaseRule{
-				Linters:    convertStaticcheckLinterNames(convertAlternativeNames(rule.Linters)),
+				Linters:    names,
 				Path:       rule.Path,
 				PathExcept: rule.PathExcept,
 				Text:       rule.Text,

pkg/commands/internal/migrate/testdata/yaml/issues_04_c.golden.yml

@@ -0,0 +1 @@
+version: "2"

pkg/commands/internal/migrate/testdata/yaml/issues_04_c.yml

@@ -0,0 +1,31 @@
+issues:
+  # Only to not generate unrelated elements inside golden.
+  exclude-use-default: false
+  # Only to not generate unrelated elements inside golden.
+  exclude-generated: strict
+  # Only to not generate unrelated elements inside golden.
+  exclude-dirs-use-default: false
+
+  exclude-case-sensitive: true
+
+  exclude-rules:
+    - path: _test\.go
+      linters:
+        - typecheck
+
+    - path-except: _test\.go
+      linters:
+        - typecheck
+
+    - path: internal/hmac/
+      text: "weak cryptographic primitive"
+      linters:
+        - typecheck
+
+    - linters:
+        - typecheck
+      text: "SA9003:"
+
+    - linters:
+        - typecheck
+      source: "foo"

pkg/commands/internal/migrate/testdata/yaml/severity_03.golden.yml

@@ -0,0 +1 @@
+version: "2"

pkg/commands/internal/migrate/testdata/yaml/severity_03.yml

@@ -0,0 +1,35 @@
+issues:
+  # Only to not generate unrelated elements inside golden.
+  exclude-use-default: false
+  # Only to not generate unrelated elements inside golden.
+  exclude-generated: strict
+  # Only to not generate unrelated elements inside golden.
+  exclude-dirs-use-default: false
+
+severity:
+  rules:
+    - path: _test\.go
+      severity: info
+      linters:
+        - typecheck
+
+    - path-except: _test\.go
+      severity: info
+      linters:
+        - typecheck
+
+    - path: internal/hmac/
+      severity: info
+      text: "weak cryptographic primitive"
+      linters:
+        - typecheck
+
+    - linters:
+        - typecheck
+      text: "SA9003:"
+      severity: info
+
+    - linters:
+        - typecheck
+      source: "foo"
+      severity: info