feat: don't allow formatters settings from linters settings

Author: ldez

pkg/config/linters_settings.go

@@ -204,7 +204,7 @@ var defaultLintersSettings = LintersSettings{
 }
 
 type LintersSettings struct {
-	FormatterSettings `mapstructure:",squash"`
+	FormatterSettings `mapstructure:"-"`
 
 	Asasalint       AsasalintSettings       `mapstructure:"asasalint"`
 	BiDiChk         BiDiChkSettings         `mapstructure:"bidichk"`

pkg/golinters/gci/testdata/gci.yml

@@ -1,9 +1,12 @@
 version: "2"
 
-linters-settings:
-  gci:
-    sections:
-      - standard
-      - prefix(github.com/golangci/golangci-lint,github.com/daixiang0/gci)
-      - default
-    custom-order: true
+formatters:
+  enable:
+    - gci
+  settings:
+    gci:
+      sections:
+        - standard
+        - prefix(github.com/golangci/golangci-lint,github.com/daixiang0/gci)
+        - default
+      custom-order: true

pkg/golinters/gofmt/testdata/gofmt_no_simplify.yml

@@ -1,5 +1,8 @@
 version: "2"
 
-linters-settings:
-  gofmt:
-    simplify: false
+formatters:
+  enable:
+    - gofmt
+  settings:
+    gofmt:
+      simplify: false

pkg/golinters/gofmt/testdata/gofmt_rewrite_rules.yml

@@ -1,9 +1,12 @@
 version: "2"
 
-linters-settings:
-  gofmt:
-    rewrite-rules:
-      - pattern: 'interface{}'
-        replacement: 'any'
-      - pattern: 'a[b:len(a)]'
-        replacement: 'a[b:]'
+formatters:
+  enable:
+    - gofmt
+  settings:
+    gofmt:
+      rewrite-rules:
+        - pattern: 'interface{}'
+          replacement: 'any'
+        - pattern: 'a[b:len(a)]'
+          replacement: 'a[b:]'

pkg/golinters/gofumpt/testdata/gofumpt-fix.yml

@@ -1,5 +1,8 @@
 version: "2"
 
-linters-settings:
-  gofumpt:
-    extra-rules: true
+formatters:
+  enable:
+    - gofumpt
+  settings:
+    gofumpt:
+      extra-rules: true

pkg/golinters/gofumpt/testdata/gofumpt_with_extra.yml

@@ -1,5 +1,8 @@
 version: "2"
 
-linters-settings:
-  gofumpt:
-    extra-rules: true
+formatters:
+  enable:
+    - gofumpt
+  settings:
+    gofumpt:
+      extra-rules: true

pkg/golinters/goimports/testdata/goimports_local.yml

@@ -1,5 +1,8 @@
 version: "2"
 
-linters-settings:
-  goimports:
-    local-prefixes: github.com/golangci/golangci-lint
+formatters:
+  enable:
+    - goimports
+  settings:
+    goimports:
+      local-prefixes: github.com/golangci/golangci-lint

test/testdata/configs/multiple-issues-fix.yml

@@ -1,6 +1,8 @@
 version: "2"
 
-linters-settings:
-  gofumpt:
-    extra-rules: true
-
+formatters:
+  enable:
+    - gofumpt
+  settings:
+    gofumpt:
+      extra-rules: true