Enable 'identical' by default, disable the rest

Author: uudashr

.golangci.next.reference.yml

@@ -1223,12 +1223,11 @@ linters-settings:
     var-require-grouping: true
 
   iface:
-    # By default, set to empty.
-    # Empty means that all analyzers are enabled.
-    # Default: []
+    # By default is set to 'identical' only.
+    # Default: [identical]
     enable:
-      - unused
       - identical
+      - unused
       - opaque
     settings:
       unused:

jsonschema/golangci.next.jsonschema.json

@@ -295,8 +295,8 @@
     },
     "iface-analyzers": {
       "enum": [
-        "unused",
         "identical",
+        "unused",
         "opaque"
       ]
     },

pkg/golinters/iface/iface.go

@@ -2,12 +2,10 @@ package iface
 
 import (
 	"slices"
-	"strings"
 
 	"github.com/uudashr/iface/identical"
 	"github.com/uudashr/iface/opaque"
 	"github.com/uudashr/iface/unused"
-	"golang.org/x/exp/maps"
 	"golang.org/x/tools/go/analysis"
 
 	"github.com/golangci/golangci-lint/pkg/config"
@@ -30,24 +28,23 @@ func New(settings *config.IfaceSettings) *goanalysis.Linter {
 
 func analyzersFromSettings(settings *config.IfaceSettings) []*analysis.Analyzer {
 	allAnalyzers := map[string]*analysis.Analyzer{
-		"unused":    unused.Analyzer,
 		"identical": identical.Analyzer,
+		"unused":    unused.Analyzer,
 		"opaque":    opaque.Analyzer,
 	}
 
 	if settings == nil || len(settings.Enable) == 0 {
-		analyzers := maps.Values(allAnalyzers)
-
-		// To have a deterministic order.
-		slices.SortFunc(analyzers, func(a *analysis.Analyzer, b *analysis.Analyzer) int {
-			return strings.Compare(a.Name, b.Name)
-		})
-
-		return analyzers
+		// Default enable `identical` analyzer only
+		return []*analysis.Analyzer{identical.Analyzer}
 	}
 
 	var analyzers []*analysis.Analyzer
 	for _, name := range uniqueNames(settings.Enable) {
+		if _, ok := allAnalyzers[name]; !ok {
+			// skip unknown analyzer
+			continue
+		}
+
 		analyzers = append(analyzers, allAnalyzers[name])
 	}
 

pkg/golinters/iface/testdata/iface.go renamed to pkg/golinters/iface/testdata/iface_all.go

@@ -1,4 +1,5 @@
 //golangcitest:args -Eiface
+//golangcitest:config_path testdata/iface_all.yml
 package testdata
 
 // identical

pkg/golinters/iface/testdata/iface_all.yml

@@ -0,0 +1,6 @@
+linters-settings:
+  iface:
+    enable:
+      - unused
+      - identical
+      - opaque

pkg/golinters/iface/testdata/iface_unused_settings.go renamed to pkg/golinters/iface/testdata/iface_default.go

@@ -1,15 +1,13 @@
 //golangcitest:args -Eiface
-//golangcitest:config_path testdata/iface_unused_settings.yml
-//golangcitest:expected_exitcode 0
 package testdata
 
 // identical
 
-type Pinger interface {
+type Pinger interface { // want "identical: interface Pinger contains identical methods or type constraints from another interface, causing redundancy"
 	Ping() error
 }
 
-type Healthcheck interface {
+type Healthcheck interface { // want "identical: interface Healthcheck contains identical methods or type constraints from another interface, causing redundancy"
 	Ping() error
 }