ttempdir added

Author: peczenyj

.golangci.reference.yml

@@ -2289,6 +2289,15 @@ linters-settings:
       # Default: true
       begin: false
 
+  ttempdir:
+    # The option `all` will run against whole test files (`_test.go`) regardless of method/function signatures.
+    # Otherwise, only methods that take `*testing.T`, `*testing.B`, and `testing.TB` as arguments are checked.
+    # Default: false
+    all: false
+    # The option `max-recursion-level` is uses to analyze function calls in recursion.
+    # Default: 5
+    max-recursion-level: 5
+
   usestdlibvars:
     # Suggest the use of http.MethodXX.
     # Default: true

go.mod

@@ -83,6 +83,7 @@ require (
 	github.com/nishanths/exhaustive v0.12.0
 	github.com/nishanths/predeclared v0.2.2
 	github.com/nunnatsa/ginkgolinter v0.16.2
+	github.com/peczenyj/ttempdir v0.2.1
 	github.com/pelletier/go-toml/v2 v2.2.2
 	github.com/polyfloyd/go-errorlint v1.5.2
 	github.com/quasilyte/go-ruleguard/dsl v0.3.22

go.sum

@@ -269,6 +269,7 @@ type LintersSettings struct {
 	Testifylint     TestifylintSettings
 	Testpackage     TestpackageSettings
 	Thelper         ThelperSettings
+	Ttempdir        TtempdirSettings
 	Unconvert       UnconvertSettings
 	Unparam         UnparamSettings
 	Unused          UnusedSettings
@@ -914,6 +915,11 @@ type TenvSettings struct {
 	All bool `mapstructure:"all"`
 }
 
+type TtempdirSettings struct {
+	All               bool `mapstructure:"all"`
+	MaxRecursionLevel uint `mapstructure:"max-recursion-level"`
+}
+
 type UseStdlibVarsSettings struct {
 	HTTPMethod         bool `mapstructure:"http-method"`
 	HTTPStatusCode     bool `mapstructure:"http-status-code"`

pkg/config/linters_settings.go

@@ -0,0 +1,79 @@
+//golangcitest:args -Ettempdir
+//golangcitest:config_path testdata/ttempdir_all.yml
+package testdata
+
+import (
+	"os"
+	"testing"
+)
+
+var (
+	_, e = os.MkdirTemp("a", "b") // never seen
+)
+
+func testsetup() {
+	os.MkdirTemp("a", "b")           // if -all = true, want  "os\\.MkdirTemp\\(\\) can be replaced by `testing\\.TempDir\\(\\)` in testsetup"
+	_, err := os.MkdirTemp("a", "b") // if -all = true, want  "os\\.MkdirTemp\\(\\) can be replaced by `testing\\.TempDir\\(\\)` in testsetup"
+	if err != nil {
+		_ = err
+	}
+	os.MkdirTemp("a", "b") // if -all = true, "func setup is not using testing.TempDir"
+}
+
+func TestF(t *testing.T) {
+	testsetup()
+	os.MkdirTemp("a", "b")           // want "os\\.MkdirTemp\\(\\) can be replaced by `t\\.TempDir\\(\\)` in TestF"
+	_, err := os.MkdirTemp("a", "b") // want "os\\.MkdirTemp\\(\\) can be replaced by `t\\.TempDir\\(\\)` in TestF"
+	_ = err
+	if _, err := os.MkdirTemp("a", "b"); err != nil { // want "os\\.MkdirTemp\\(\\) can be replaced by `t\\.TempDir\\(\\)` in TestF"
+		_ = err
+	}
+}
+
+func BenchmarkF(b *testing.B) {
+	TB(b)
+	os.MkdirTemp("a", "b")           // want "os\\.MkdirTemp\\(\\) can be replaced by `b\\.TempDir\\(\\)` in BenchmarkF"
+	_, err := os.MkdirTemp("a", "b") // want "os\\.MkdirTemp\\(\\) can be replaced by `b\\.TempDir\\(\\)` in BenchmarkF"
+	_ = err
+	if _, err := os.MkdirTemp("a", "b"); err != nil { // want "os\\.MkdirTemp\\(\\) can be replaced by `b\\.TempDir\\(\\)` in BenchmarkF"
+		_ = err
+	}
+}
+
+func TB(tb testing.TB) {
+	os.MkdirTemp("a", "b")           // want "os\\.MkdirTemp\\(\\) can be replaced by `tb\\.TempDir\\(\\)` in TB"
+	_, err := os.MkdirTemp("a", "b") // want "os\\.MkdirTemp\\(\\) can be replaced by `tb\\.TempDir\\(\\)` in TB"
+	_ = err
+	if _, err := os.MkdirTemp("a", "b"); err != nil { // want "os\\.MkdirTemp\\(\\) can be replaced by `tb\\.TempDir\\(\\)` in TB"
+		_ = err
+	}
+}
+
+func FuzzF(f *testing.F) {
+	os.MkdirTemp("a", "b")           // want "os\\.MkdirTemp\\(\\) can be replaced by `f\\.TempDir\\(\\)` in FuzzF"
+	_, err := os.MkdirTemp("a", "b") // want "os\\.MkdirTemp\\(\\) can be replaced by `f\\.TempDir\\(\\)` in FuzzF"
+	_ = err
+	if _, err := os.MkdirTemp("a", "b"); err != nil { // want "os\\.MkdirTemp\\(\\) can be replaced by `f\\.TempDir\\(\\)` in FuzzF"
+		_ = err
+	}
+}
+
+func TestFunctionLiteral(t *testing.T) {
+	testsetup()
+	t.Run("test", func(t *testing.T) {
+		os.MkdirTemp("a", "b")           // want "os\\.MkdirTemp\\(\\) can be replaced by `t\\.TempDir\\(\\)` in anonymous function"
+		_, err := os.MkdirTemp("a", "b") // want "os\\.MkdirTemp\\(\\) can be replaced by `t\\.TempDir\\(\\)` in anonymous function"
+		_ = err
+		if _, err := os.MkdirTemp("a", "b"); err != nil { // want "os\\.MkdirTemp\\(\\) can be replaced by `t\\.TempDir\\(\\)` in anonymous function"
+			_ = err
+		}
+	})
+}
+
+func TestEmpty(t *testing.T) {
+	t.Run("test", func(*testing.T) {})
+}
+
+func TestEmptyTB(t *testing.T) {
+	func(testing.TB) {}(t)
+}

pkg/golinters/ttempdir/testdata/ttempdir.go

@@ -0,0 +1,4 @@
+linters-settings:
+  ttempdir:
+    all: true
+    max-recursion-level: 5

pkg/golinters/ttempdir/testdata/ttempdir_all.yml

@@ -0,0 +1,30 @@
+package ttempdir
+
+import (
+	"github.com/peczenyj/ttempdir"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/config"
+	"github.com/golangci/golangci-lint/pkg/goanalysis"
+)
+
+func New(settings *config.TtempdirSettings) *goanalysis.Linter {
+	a := ttempdir.Analyzer
+
+	var cfg map[string]map[string]any
+	if settings != nil {
+		cfg = map[string]map[string]any{
+			a.Name: {
+				ttempdir.A:   settings.All,
+				ttempdir.MRL: settings.MaxRecursionLevel,
+			},
+		}
+	}
+
+	return goanalysis.NewLinter(
+		a.Name,
+		a.Doc,
+		[]*analysis.Analyzer{a},
+		cfg,
+	).WithLoadMode(goanalysis.LoadModeSyntax)
+}

pkg/golinters/ttempdir/ttempdir.go

@@ -0,0 +1,11 @@
+package ttempdir
+
+import (
+	"testing"
+
+	"github.com/golangci/golangci-lint/test/testshared/integration"
+)
+
+func TestFromTestdata(t *testing.T) {
+	integration.RunTestdata(t)
+}

pkg/golinters/ttempdir/ttempdir_integration_test.go

@@ -100,6 +100,7 @@ import (
 	"github.com/golangci/golangci-lint/pkg/golinters/testpackage"
 	"github.com/golangci/golangci-lint/pkg/golinters/thelper"
 	"github.com/golangci/golangci-lint/pkg/golinters/tparallel"
+	"github.com/golangci/golangci-lint/pkg/golinters/ttempdir"
 	"github.com/golangci/golangci-lint/pkg/golinters/unconvert"
 	"github.com/golangci/golangci-lint/pkg/golinters/unparam"
 	"github.com/golangci/golangci-lint/pkg/golinters/unused"
@@ -756,6 +757,12 @@ func (LinterBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
 			WithLoadForGoAnalysis().
 			WithURL("https://github.com/moricho/tparallel"),
 
+		linter.NewConfig(ttempdir.New(&cfg.LintersSettings.Ttempdir)).
+			WithSince("v1.60.0").
+			WithPresets(linter.PresetStyle).
+			WithLoadForGoAnalysis().
+			WithURL("https://github.com/peczenyj/ttempdir"),
+
 		linter.NewConfig(golinters.NewTypecheck()).
 			WithInternal().
 			WithEnabledByDefault().