Test mergeReplaceDirectives with duplicate module

Author: sublee

pkg/commands/internal/builder.go

@@ -168,29 +168,51 @@ func (b Builder) addReplaceDirective(ctx context.Context, plugin *Plugin) error
 	return nil
 }
 
-func (b Builder) mergeReplaceDirectives(ctx context.Context, pluginPath string) error {
+type goModReplace struct {
+	Replace []struct {
+		Old struct{ Path, Version string }
+		New struct{ Path, Version string }
+	}
+}
+
+func readGoModReplace(ctx context.Context, dir string) (*goModReplace, error) {
 	cmd := exec.CommandContext(ctx, "go", "mod", "edit", "-json")
-	cmd.Dir = pluginPath
+	cmd.Dir = dir
 
 	output, err := cmd.CombinedOutput()
 	if err != nil {
-		b.log.Warnf("%s", string(output))
+		return nil, fmt.Errorf("%s: %w", strings.Join(cmd.Args, " "), err)
+	}
 
-		return fmt.Errorf("%s: %w", strings.Join(cmd.Args, " "), err)
+	var goMod goModReplace
+	err = json.Unmarshal(output, &goMod)
+	if err != nil {
+		return nil, fmt.Errorf("unmarshal go.mod json: %w", err)
 	}
 
-	var goMod struct {
-		Replace []struct {
-			Old struct{ Path, Version string }
-			New struct{ Path, Version string }
-		}
+	return &goMod, nil
+}
+
+func (b Builder) mergeReplaceDirectives(ctx context.Context, pluginPath string) error {
+	pluginGoMod, err := readGoModReplace(ctx, pluginPath)
+	if err != nil {
+		return err
 	}
-	err = json.Unmarshal(output, &goMod)
+
+	rootGoMod, err := readGoModReplace(ctx, b.repo)
 	if err != nil {
-		return fmt.Errorf("unmarshal go mod json: %w", err)
+		return err
+	}
+
+	for _, r := range pluginGoMod.Replace {
+		for _, rr := range rootGoMod.Replace {
+			if r.Old.Path == rr.Old.Path && r.Old.Version == rr.Old.Version {
+				return fmt.Errorf("duplicate replace directive for %s@%s", r.Old.Path, r.Old.Version)
+			}
+		}
 	}
 
-	for _, r := range goMod.Replace {
+	for _, r := range pluginGoMod.Replace {
 		abs, err := filepath.Abs(filepath.Join(pluginPath, r.New.Path))
 		if err != nil {
 			return fmt.Errorf("get absolute path: %w", err)

pkg/commands/internal/builder_test.go

@@ -104,3 +104,62 @@ go 1.24.0
 	require.Len(t, goMod.Replace, 1)
 	assert.Contains(t, goMod.Replace[0].New.Path, "testdata/plugin/target")
 }
+
+func TestMergeReplaceDirectives_DuplicateReplace(t *testing.T) {
+	t.Parallel()
+
+	tmp := t.TempDir()
+	require.NoError(t, os.WriteFile(filepath.Join(tmp, "go.mod"), []byte(`
+module github.com/golangci/golangci-lint/v2
+go 1.24.0
+`), 0o600))
+	require.NoError(t, os.Mkdir(filepath.Join(tmp, "golangci-lint"), 0o700))
+
+	// Both plugins define a replace directive for example.com/target.
+	b := NewBuilder(nil, &Configuration{Plugins: []*Plugin{
+		{Module: "example.com/plugin", Path: "testdata/plugin"},
+		{Module: "example.com/plugin2", Path: "testdata/plugin2"},
+	}}, tmp)
+
+	err := b.mergeReplaceDirectives(t.Context(), filepath.Join("testdata", "plugin"))
+	require.NoError(t, err)
+
+	err = b.mergeReplaceDirectives(t.Context(), filepath.Join("testdata", "plugin2"))
+	assert.ErrorContains(t, err, "duplicate replace directive for example.com/target")
+}
+
+func TestMergeReplaceDirectives_DuplicateButDifferentVersion(t *testing.T) {
+	t.Parallel()
+
+	tmp := t.TempDir()
+	require.NoError(t, os.WriteFile(filepath.Join(tmp, "go.mod"), []byte(`
+module github.com/golangci/golangci-lint/v2
+go 1.24.0
+`), 0o600))
+	require.NoError(t, os.Mkdir(filepath.Join(tmp, "golangci-lint"), 0o700))
+
+	// Both plugins define a replace directive for example.com/target.
+	b := NewBuilder(nil, &Configuration{Plugins: []*Plugin{
+		{Module: "example.com/plugin", Path: "testdata/plugin"},
+		{Module: "example.com/plugin3", Path: "testdata/plugin3"},
+	}}, tmp)
+
+	err := b.mergeReplaceDirectives(t.Context(), filepath.Join("testdata", "plugin"))
+	require.NoError(t, err)
+
+	err = b.mergeReplaceDirectives(t.Context(), filepath.Join("testdata", "plugin3"))
+	require.NoError(t, err)
+
+	cmd := exec.CommandContext(t.Context(), "go", "mod", "edit", "-json")
+	cmd.Dir = b.repo
+	output, err := cmd.CombinedOutput()
+	require.NoError(t, err)
+
+	var goMod struct {
+		Replace []struct{ New struct{ Path string } }
+	}
+	err = json.Unmarshal(output, &goMod)
+	require.NoError(t, err)
+
+	assert.Len(t, goMod.Replace, 2)
+}

pkg/commands/internal/testdata/plugin2/go.mod

@@ -0,0 +1,7 @@
+module example.com/plugin2
+
+go 1.24.0
+
+require example.com/target v0.0.0
+
+replace example.com/target => ./target

pkg/commands/internal/testdata/plugin2/plugin.go

@@ -0,0 +1,3 @@
+package plugin
+
+import _ "example.com/target"

pkg/commands/internal/testdata/plugin2/target/go.mod

@@ -0,0 +1,3 @@
+module example.com/target
+
+go 1.24.0

pkg/commands/internal/testdata/plugin2/target/target.go

@@ -0,0 +1 @@
+package target

pkg/commands/internal/testdata/plugin3/go.mod

@@ -0,0 +1,7 @@
+module example.com/plugin2
+
+go 1.24.0
+
+require example.com/target v1.0.0
+
+replace example.com/[email protected] => ./target

pkg/commands/internal/testdata/plugin3/plugin.go

@@ -0,0 +1,3 @@
+package plugin
+
+import _ "example.com/target"

pkg/commands/internal/testdata/plugin3/target/go.mod

@@ -0,0 +1,3 @@
+module example.com/target
+
+go 1.24.0

pkg/commands/internal/testdata/plugin3/target/target.go

@@ -0,0 +1 @@
+package target