Fix all technical requirements from maintainer feedback

- Remove all ignore-related options from configuration
- Remove gounqvet_test.go as requested
- Fix testdata directives format (move 'want' to end of line)
- Remove ignore fields from GounqvetSettings struct
- Change WithLoadForGoAnalysis to LoadModeSyntax (no type info needed)
- Add empty lines at end of all files
- Simplify configuration to only check-sql-builders and allowed-patterns

All technical feedback addressed.

Author: MirrexOne

.golangci.next.reference.yml

@@ -1656,29 +1656,11 @@ linters:
       # Enable SQL builder checking.
       # Default: true
       check-sql-builders: false
-      # Functions to skip during analysis.
-      # Default: []
-      ignored-functions:
-        - "fmt.Printf"
-        - "log.Printf"
-      # Packages to ignore completely.
-      # Default: []
-      ignored-packages:
-        - "testing"
-        - "debug"
       # Regex patterns for acceptable SELECT * usage.
       # Default: ["SELECT \\* FROM information_schema\\..*", "SELECT \\* FROM pg_catalog\\..*", "SELECT COUNT\\(\\*\\)", "SELECT MAX\\(\\*\\)", "SELECT MIN\\(\\*\\)"]
       allowed-patterns:
         - "SELECT \\* FROM temp_.*"
         - "SELECT \\* FROM.*-- migration"
-      # File patterns to ignore.
-      # Default: ["*_test.go", "*.pb.go", "*_gen.go", "*.gen.go", "*_generated.go"]
-      ignored-file-patterns:
-        - "my_special_pattern.go"
-      # Directories to ignore.
-      # Default: ["vendor", "testdata", "migrations", "generated", ".git", "node_modules"]
-      ignored-directories:
-        - "my_special_dir"
 
     gosmopolitan:
       # Allow and ignore `time.Local` usages.

pkg/config/linters_settings.go

@@ -1105,10 +1105,6 @@ func (s *CustomLinterSettings) Validate() error {
 }
 
 type GounqvetSettings struct {
-	CheckSQLBuilders      bool     `mapstructure:"check-sql-builders"`
-	IgnoredFunctions      []string `mapstructure:"ignored-functions"`
-	IgnoredPackages       []string `mapstructure:"ignored-packages"`
-	AllowedPatterns       []string `mapstructure:"allowed-patterns"`
-	IgnoredFilePatterns   []string `mapstructure:"ignored-file-patterns"`
-	IgnoredDirectories    []string `mapstructure:"ignored-directories"`
+	CheckSQLBuilders bool     `mapstructure:"check-sql-builders"`
+	AllowedPatterns  []string `mapstructure:"allowed-patterns"`
 }

pkg/golinters/gounqvet/gounqvet.go

@@ -13,12 +13,8 @@ func New(settings *config.GounqvetSettings) *goanalysis.Linter {
 	var cfg *pkgconfig.GounqvetSettings
 	if settings != nil {
 		cfg = &pkgconfig.GounqvetSettings{
-			CheckSQLBuilders:      settings.CheckSQLBuilders,
-			IgnoredFunctions:      settings.IgnoredFunctions,
-			IgnoredPackages:       settings.IgnoredPackages,
-			AllowedPatterns:       settings.AllowedPatterns,
-			IgnoredFilePatterns:   settings.IgnoredFilePatterns,
-			IgnoredDirectories:    settings.IgnoredDirectories,
+			CheckSQLBuilders: settings.CheckSQLBuilders,
+			AllowedPatterns:  settings.AllowedPatterns,
 		}
 	}
 
@@ -29,5 +25,5 @@ func New(settings *config.GounqvetSettings) *goanalysis.Linter {
 		"Detects SELECT * usage in SQL queries and SQL builders, encouraging explicit column selection",
 		[]*analysis.Analyzer{analyzer},
 		nil,
-	).WithLoadMode(goanalysis.LoadModeTypesInfo)
-}
+	).WithLoadMode(goanalysis.LoadModeSyntax)
+}

pkg/golinters/gounqvet/gounqvet_test.go

@@ -7,12 +7,10 @@ import (
 )
 
 func badQueries() {
-	// want "avoid SELECT \\* - explicitly specify needed columns for better performance, maintainability and stability"
-	query := "SELECT * FROM users"
+	query := "SELECT * FROM users" // want "avoid SELECT \\* - explicitly specify needed columns for better performance, maintainability and stability"
 
 	var db *sql.DB
-	// want "avoid SELECT \\* - explicitly specify needed columns for better performance, maintainability and stability"
-	rows, _ := db.Query("SELECT * FROM orders WHERE status = ?", "active")
+	rows, _ := db.Query("SELECT * FROM orders WHERE status = ?", "active") // want "avoid SELECT \\* - explicitly specify needed columns for better performance, maintainability and stability"
 	_ = rows
 
 	// This should not trigger because it's a COUNT function
@@ -41,13 +39,12 @@ type SQLBuilder interface {
 }
 
 func badSQLBuilder(builder SQLBuilder) {
-	// want "avoid SELECT \\* in SQL builder - explicitly specify columns to prevent unnecessary data transfer and schema change issues"
-	query := builder.Select("*").From("products")
+	query := builder.Select("*").From("products") // want "avoid SELECT \\* in SQL builder - explicitly specify columns to prevent unnecessary data transfer and schema change issues"
 	_ = query
 }
 
 func goodSQLBuilder(builder SQLBuilder) {
 	// Good usage - should not trigger
 	query := builder.Select("id", "name", "price").From("products")
 	_ = query
-}
+}

pkg/golinters/gounqvet/testdata/gounqvet.go

@@ -401,7 +401,6 @@ func (LinterBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
 
 		linter.NewConfig(gounqvet.New(&cfg.Linters.Settings.Gounqvet)).
 			WithSince("v2.5.0").
-			WithLoadForGoAnalysis().
 			WithURL("https://github.com/MirrexOne/gounqvet"),
 
 		linter.NewConfig(gosmopolitan.New(&cfg.Linters.Settings.Gosmopolitan)).