review

Author: ldez

pkg/commands/internal/migrate/cloner/cloner.go

@@ -69,15 +69,12 @@ func skipFile(path string) bool {
 		return true
 	}
 
-	if filepath.Base(path) == "base_loader.go" {
-		return true
-	}
-
-	if filepath.Base(path) == "loader.go" {
+	switch filepath.Base(path) {
+	case "base_loader.go", "loader.go":
 		return true
+	default:
+		return false
 	}
-
-	return false
 }
 
 func processFile(file *ast.File) {

pkg/commands/internal/migrate/migrate_formatters.go

@@ -67,7 +67,7 @@ func toGciSettings(old versionone.GciSettings) versiontwo.GciSettings {
 		NoInlineComments: old.NoInlineComments,
 		NoPrefixComments: old.NoPrefixComments,
 		CustomOrder:      old.CustomOrder,
-		NoLexOrder:       old.CustomOrder,
+		NoLexOrder:       old.NoLexOrder,
 	}
 }
 

pkg/commands/internal/migrate/migrate_linters_settings.go

@@ -791,10 +791,8 @@ func toSpancheckSettings(old versionone.SpancheckSettings) versiontwo.SpancheckS
 func toStaticCheckSettings(old versionone.LintersSettings) versiontwo.StaticCheckSettings {
 	checks := slices.Concat(old.Staticcheck.Checks, old.Stylecheck.Checks, old.Gosimple.Checks)
 
-	slices.Sort(checks)
-
 	return versiontwo.StaticCheckSettings{
-		Checks:                  slices.Compact(checks),
+		Checks:                  Unique(checks),
 		Initialisms:             old.Stylecheck.Initialisms,
 		DotImportWhitelist:      old.Stylecheck.DotImportWhitelist,
 		HTTPStatusCodeWhitelist: old.Stylecheck.HTTPStatusCodeWhitelist,