feat: boolset linter

Signed-off-by: Artur Melanchyk <[email protected]>

Author: arturmelanchyk

.golangci.next.reference.yml

@@ -25,6 +25,7 @@ linters:
     - asciicheck
     - bidichk
     - bodyclose
+    - boolset
     - canonicalheader
     - containedctx
     - contextcheck
@@ -139,6 +140,7 @@ linters:
     - asciicheck
     - bidichk
     - bodyclose
+    - boolset
     - canonicalheader
     - containedctx
     - contextcheck

go.mod

@@ -23,6 +23,7 @@ require (
 	github.com/alexkohler/prealloc v1.0.0
 	github.com/alingse/asasalint v0.0.11
 	github.com/alingse/nilnesserr v0.2.0
+	github.com/arturmelanchyk/boolset v0.1.0
 	github.com/ashanbrown/forbidigo/v2 v2.1.0
 	github.com/ashanbrown/makezero/v2 v2.0.1
 	github.com/bkielbasa/cyclop v1.2.3

go.sum

@@ -0,0 +1,13 @@
+package boolset
+
+import (
+	"github.com/arturmelanchyk/boolset/boolset"
+
+	"github.com/golangci/golangci-lint/v2/pkg/goanalysis"
+)
+
+func New() *goanalysis.Linter {
+	return goanalysis.
+		NewLinterFromAnalyzer(boolset.NewAnalyzer()).
+		WithLoadMode(goanalysis.LoadModeTypesInfo)
+}

pkg/golinters/boolset/boolset.go

@@ -0,0 +1,11 @@
+package boolset
+
+import (
+	"testing"
+
+	"github.com/golangci/golangci-lint/v2/test/testshared/integration"
+)
+
+func TestFromTestdata(t *testing.T) {
+	integration.RunTestdata(t)
+}

pkg/golinters/boolset/boolset_integration_test.go

@@ -0,0 +1,23 @@
+//golangcitest:args -Eboolset
+package testdata
+
+import (
+	"log"
+)
+
+var allNames = []string{"a", "a", "b", "c", "c", "d"}
+
+func findDuplicates() []string {
+	var duplicates []string
+	uniqueNames := make(map[string]bool) // want "map\\[string\\]bool only stores \"true\" values; consider map\\[string\\]struct\\{\\}"
+	for _, name := range allNames {
+		if _, ok := uniqueNames[name]; ok {
+			duplicates = append(duplicates, name)
+			log.Println("Duplicate found: ", name)
+		} else {
+			uniqueNames[name] = true
+		}
+	}
+
+	return duplicates
+}

pkg/golinters/boolset/testdata/boolset.go

@@ -0,0 +1,40 @@
+//golangcitest:args -Eboolset
+package testdata
+
+/*
+ #include <stdio.h>
+ #include <stdlib.h>
+
+ void myprint(char* s) {
+ 	printf("%d\n", s);
+ }
+*/
+import "C"
+
+import (
+	"log"
+	"unsafe"
+)
+
+func _() {
+	cs := C.CString("Hello from stdio\n")
+	C.myprint(cs)
+	C.free(unsafe.Pointer(cs))
+}
+
+var allNamesCgo = []string{"a", "a", "b", "c", "c", "d"}
+
+func findDuplicatesCgo() []string {
+	var duplicates []string
+	uniqueNames := make(map[string]bool) // want "map\\[string\\]bool only stores \"true\" values; consider map\\[string\\]struct\\{\\}"
+	for _, name := range allNamesCgo {
+		if _, ok := uniqueNames[name]; ok {
+			duplicates = append(duplicates, name)
+			log.Println("Duplicate found: ", name)
+		} else {
+			uniqueNames[name] = true
+		}
+	}
+
+	return duplicates
+}

pkg/golinters/boolset/testdata/boolset_cgo.go

@@ -8,6 +8,7 @@ import (
 	"github.com/golangci/golangci-lint/v2/pkg/golinters/asciicheck"
 	"github.com/golangci/golangci-lint/v2/pkg/golinters/bidichk"
 	"github.com/golangci/golangci-lint/v2/pkg/golinters/bodyclose"
+	"github.com/golangci/golangci-lint/v2/pkg/golinters/boolset"
 	"github.com/golangci/golangci-lint/v2/pkg/golinters/canonicalheader"
 	"github.com/golangci/golangci-lint/v2/pkg/golinters/containedctx"
 	"github.com/golangci/golangci-lint/v2/pkg/golinters/contextcheck"
@@ -165,6 +166,11 @@ func (LinterBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
 			WithLoadForGoAnalysis().
 			WithURL("https://github.com/timakin/bodyclose"),
 
+		linter.NewConfig(boolset.New()).
+			WithSince("v2.6.0").
+			WithLoadForGoAnalysis().
+			WithURL("https://github.com/arturmelanchyk/boolset"),
+
 		linter.NewConfig(canonicalheader.New()).
 			WithSince("v1.58.0").
 			WithLoadForGoAnalysis().