Test mergeReplaceDirectives

Author: sublee

pkg/commands/internal/builder.go

@@ -191,13 +191,17 @@ func (b Builder) mergeReplaceDirectives(ctx context.Context, pluginPath string)
 	}
 
 	for _, r := range goMod.Replace {
-		abs := filepath.Join(pluginPath, r.New.Path)
+		abs, err := filepath.Abs(filepath.Join(pluginPath, r.New.Path))
+		if err != nil {
+			return fmt.Errorf("get absolute path: %w", err)
+		}
+
 		stat, err := os.Stat(abs)
 		if err != nil {
 			return fmt.Errorf("%s: %w", abs, err)
 		}
 		if stat.IsDir() {
-			r.New.Path = filepath.Join(pluginPath, r.New.Path)
+			r.New.Path = abs
 		}
 
 		replace := fmt.Sprintf("%s=%s", r.Old.Path, r.New.Path)

pkg/commands/internal/builder_test.go

@@ -1,9 +1,14 @@
 package internal
 
 import (
+	"encoding/json"
+	"os"
+	"os/exec"
+	"path/filepath"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func Test_sanitizeVersion(t *testing.T) {
@@ -54,3 +59,39 @@ func Test_sanitizeVersion(t *testing.T) {
 		})
 	}
 }
+
+func TestMergeReplaceDirectives(t *testing.T) {
+	t.Parallel()
+
+	// Create a temporary module structure:
+	// tmp/
+	//   go.mod
+	//   golangci-lint/
+	tmp := t.TempDir()
+	require.NoError(t, os.WriteFile(filepath.Join(tmp, "go.mod"), []byte(`
+module github.com/golangci/golangci-lint/v2
+go 1.24.0
+`), 0o644))
+	require.NoError(t, os.Mkdir(filepath.Join(tmp, "golangci-lint"), 0o755))
+
+	b := NewBuilder(nil, &Configuration{Plugins: []*Plugin{
+		{Module: "example.com/plugin", Path: "testdata/plugin"},
+	}}, tmp)
+
+	err := b.mergeReplaceDirectives(t.Context(), filepath.Join("testdata", "plugin"))
+	require.NoError(t, err)
+
+	cmd := exec.Command("go", "mod", "edit", "-json")
+	cmd.Dir = b.repo
+	output, err := cmd.CombinedOutput()
+	require.NoError(t, err)
+
+	var goMod struct {
+		Replace []struct{ New struct{ Path string } }
+	}
+	err = json.Unmarshal(output, &goMod)
+	require.NoError(t, err)
+
+	require.Len(t, goMod.Replace, 1)
+	assert.Contains(t, goMod.Replace[0].New.Path, "testdata/plugin/target")
+}

pkg/commands/internal/testdata/plugin/go.mod

@@ -0,0 +1,7 @@
+module example.com/plugin
+
+go 1.24.0
+
+require example.com/target v0.0.0
+
+replace example.com/target => ./target

pkg/commands/internal/testdata/plugin/plugin.go

@@ -0,0 +1,3 @@
+package plugin
+
+import _ "example.com/target"

pkg/commands/internal/testdata/plugin/target/go.mod

@@ -0,0 +1,3 @@
+module example.com/target
+
+go 1.24.0

pkg/commands/internal/testdata/plugin/target/target.go

@@ -0,0 +1 @@
+package target