chore: isolate code from x/tools

Author: ldez

pkg/goanalysis/runner_action.go

@@ -56,10 +56,6 @@ type action struct {
 	needAnalyzeSource   bool
 }
 
-func (act *action) String() string {
-	return fmt.Sprintf("%s@%s", act.a, act.pkg)
-}
-
 func (act *action) waitUntilDependingAnalyzersWorked() {
 	for _, dep := range act.deps {
 		if dep.pkg == act.pkg {

pkg/goanalysis/runner_base.go

@@ -16,10 +16,28 @@ import (
 	"reflect"
 	"time"
 
-	"github.com/golangci/golangci-lint/pkg/goanalysis/pkgerrors"
 	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/goanalysis/pkgerrors"
 )
 
+// NOTE(ldez) no alteration.
+type objectFactKey struct {
+	obj types.Object
+	typ reflect.Type
+}
+
+// NOTE(ldez) no alteration.
+type packageFactKey struct {
+	pkg *types.Package
+	typ reflect.Type
+}
+
+// NOTE(ldez) no alteration.
+func (act *action) String() string {
+	return fmt.Sprintf("%s@%s", act.a, act.pkg)
+}
+
 // NOTE(ldez) altered version of `func (act *action) execOnce()`.
 func (act *action) analyze() {
 	defer close(act.analysisDoneCh) // unblock actions depending on this action