chore: new show-stats default

Author: ldez

.golangci.next.reference.yml

@@ -4123,8 +4123,8 @@ output:
     - file # filepath, line, and column.
 
   # Show statistics per linter.
-  # Default: false
-  show-stats: true
+  # Default: true
+  show-stats: false
 
 
 # Options for analysis running.

jsonschema/golangci.next.jsonschema.json

@@ -3888,7 +3888,7 @@
         "show-stats": {
           "description": "Show statistics per linter.",
           "type": "boolean",
-          "default": false
+          "default": true
         },
         "sort-order": {
           "type": "array",

pkg/commands/flagsets.go

@@ -72,7 +72,7 @@ func setupRunFlagSet(v *viper.Viper, fs *pflag.FlagSet) {
 func setupOutputFlagSet(v *viper.Viper, fs *pflag.FlagSet) {
 	internal.AddFlagAndBind(v, fs, fs.String, "path-prefix", "output.path-prefix", "",
 		color.GreenString("Path prefix to add to output"))
-	internal.AddFlagAndBind(v, fs, fs.Bool, "show-stats", "output.show-stats", false, color.GreenString("Show statistics per linter"))
+	internal.AddFlagAndBind(v, fs, fs.Bool, "show-stats", "output.show-stats", true, color.GreenString("Show statistics per linter"))
 
 	setupOutputFormatsFlagSet(v, fs)
 }

test/run_test.go

@@ -37,6 +37,7 @@ func TestAutogeneratedNoIssues(t *testing.T) {
 
 	testshared.NewRunnerBuilder(t).
 		WithConfig(cfg).
+		WithArgs("--show-stats=false").
 		WithTargetPath(testdataDir, "autogenerated").
 		WithBinPath(binPath).
 		Runner().
@@ -47,6 +48,7 @@ func TestAutogeneratedNoIssues(t *testing.T) {
 func TestEmptyDirRun(t *testing.T) {
 	testshared.NewRunnerBuilder(t).
 		WithEnviron("GO111MODULE=off").
+		WithArgs("--show-stats=false").
 		WithTargetPath(testdataDir, "nogofiles").
 		Runner().
 		Install().
@@ -69,6 +71,7 @@ func TestNotExistingDirRun(t *testing.T) {
 
 func TestSymlinkLoop(t *testing.T) {
 	testshared.NewRunnerBuilder(t).
+		WithArgs("--show-stats=false").
 		WithTargetPath(testdataDir, "symlink_loop", "...").
 		Runner().
 		Install().
@@ -120,7 +123,9 @@ func TestTestsAreLintedByDefault(t *testing.T) {
 func TestCgoOk(t *testing.T) {
 	testshared.NewRunnerBuilder(t).
 		WithNoConfig().
-		WithArgs("--timeout=3m",
+		WithArgs(
+			"--timeout=3m",
+			"--show-stats=false",
 			"--enable-all",
 		).
 		WithTargetPath(testdataDir, "cgo").
@@ -358,7 +363,10 @@ func TestUnsafeOk(t *testing.T) {
 
 	testshared.NewRunnerBuilder(t).
 		WithConfig(cfg).
-		WithArgs("--enable-all").
+		WithArgs(
+			"--show-stats=false",
+			"--enable-all",
+		).
 		WithTargetPath(testdataDir, "unsafe").
 		WithBinPath(binPath).
 		Runner().
@@ -371,7 +379,10 @@ func TestSortedResults(t *testing.T) {
 
 	testshared.NewRunnerBuilder(t).
 		WithNoConfig().
-		WithArgs("--output.text.print-issued-lines=false").
+		WithArgs(
+			"--show-stats=false",
+			"--output.text.print-issued-lines=false",
+		).
 		WithTargetPath(testdataDir, "sort_results").
 		WithBinPath(binPath).
 		Runner().
@@ -385,7 +396,11 @@ func TestSortedResults(t *testing.T) {
 func TestIdentifierUsedOnlyInTests(t *testing.T) {
 	testshared.NewRunnerBuilder(t).
 		WithNoConfig().
-		WithArgs("--disable-all", "-Eunused").
+		WithArgs(
+			"--show-stats=false",
+			"--disable-all",
+			"-Eunused",
+		).
 		WithTargetPath(testdataDir, "used_only_in_tests").
 		Runner().
 		Install().
@@ -395,6 +410,7 @@ func TestIdentifierUsedOnlyInTests(t *testing.T) {
 
 func TestUnusedCheckExported(t *testing.T) {
 	testshared.NewRunnerBuilder(t).
+		WithArgs("--show-stats=false").
 		WithConfigFile("testdata_etc/unused_exported/golangci.yml").
 		WithTargetPath("testdata_etc/unused_exported/...").
 		Runner().

test/testshared/integration/run.go

@@ -63,6 +63,7 @@ func testOneSource(t *testing.T, log *logutils.StderrLog, binPath, sourcePath st
 
 	args := []string{
 		"--disable-all",
+		"--show-stats=false",
 		"--output.json.path=stdout",
 		"--max-same-issues=100",
 		"--max-issues-per-linter=100",