chore: use config pointer like analyzers

Author: ldez

pkg/goformatters/gci/gci.go

@@ -1,8 +1,11 @@
 package gci
 
 import (
+	"fmt"
+
 	gcicfg "github.com/daixiang0/gci/pkg/config"
 	"github.com/daixiang0/gci/pkg/gci"
+	"github.com/daixiang0/gci/pkg/log"
 	"github.com/ldez/grignotin/gomod"
 
 	"github.com/golangci/golangci-lint/pkg/config"
@@ -14,23 +17,36 @@ type Formatter struct {
 	config *gcicfg.Config
 }
 
-func New(cfg config.GciSettings) (*Formatter, error) {
+func New(settings *config.GciSettings) (*Formatter, error) {
+	log.InitLogger()
+	_ = log.L().Sync()
+
 	modPath, err := gomod.GetModulePath()
 	if err != nil {
 		return nil, err
 	}
 
-	parsedCfg, err := gcicfg.YamlConfig{
+	cfg := gcicfg.YamlConfig{
 		Cfg: gcicfg.BoolConfig{
-			NoInlineComments: cfg.NoInlineComments,
-			NoPrefixComments: cfg.NoPrefixComments,
-			SkipGenerated:    cfg.SkipGenerated,
-			CustomOrder:      cfg.CustomOrder,
-			NoLexOrder:       cfg.NoLexOrder,
+			NoInlineComments: settings.NoInlineComments,
+			NoPrefixComments: settings.NoPrefixComments,
+			SkipGenerated:    settings.SkipGenerated,
+			CustomOrder:      settings.CustomOrder,
+			NoLexOrder:       settings.NoLexOrder,
 		},
-		SectionStrings: cfg.Sections,
+		SectionStrings: settings.Sections,
 		ModPath:        modPath,
-	}.Parse()
+	}
+
+	if settings.LocalPrefixes != "" {
+		cfg.SectionStrings = []string{
+			"standard",
+			"default",
+			fmt.Sprintf("prefix(%s)", settings.LocalPrefixes),
+		}
+	}
+
+	parsedCfg, err := cfg.Parse()
 	if err != nil {
 		return nil, err
 	}

pkg/goformatters/gofmt/gofmt.go

@@ -12,18 +12,18 @@ type Formatter struct {
 	options gofmt.Options
 }
 
-func New(cfg config.GoFmtSettings) *Formatter {
-	var rewriteRules []gofmt.RewriteRule
-	for _, rule := range cfg.RewriteRules {
-		rewriteRules = append(rewriteRules, gofmt.RewriteRule(rule))
-	}
+func New(settings *config.GoFmtSettings) *Formatter {
+	options := gofmt.Options{}
+
+	if settings != nil {
+		options.NeedSimplify = settings.Simplify
 
-	return &Formatter{
-		options: gofmt.Options{
-			NeedSimplify: cfg.Simplify,
-			RewriteRules: rewriteRules,
-		},
+		for _, rule := range settings.RewriteRules {
+			options.RewriteRules = append(options.RewriteRules, gofmt.RewriteRule(rule))
+		}
 	}
+
+	return &Formatter{options: options}
 }
 
 func (*Formatter) Name() string {

pkg/goformatters/gofumpt/gofumpt.go

@@ -14,14 +14,18 @@ type Formatter struct {
 	options gofumpt.Options
 }
 
-func New(cfg config.GofumptSettings, goVersion string) *Formatter {
-	return &Formatter{
-		options: gofumpt.Options{
+func New(settings *config.GofumptSettings, goVersion string) *Formatter {
+	var options gofumpt.Options
+
+	if settings != nil {
+		options = gofumpt.Options{
 			LangVersion: getLangVersion(goVersion),
-			ModulePath:  cfg.ModulePath,
-			ExtraRules:  cfg.ExtraRules,
-		},
+			ModulePath:  settings.ModulePath,
+			ExtraRules:  settings.ExtraRules,
+		}
 	}
+
+	return &Formatter{options: options}
 }
 
 func (*Formatter) Name() string {
@@ -32,7 +36,6 @@ func (f *Formatter) Format(_ string, src []byte) ([]byte, error) {
 	return gofumpt.Source(src, f.options)
 }
 
-// modified copy of pkg/golinters/gofumpt/gofumpt.go
 func getLangVersion(v string) string {
 	if v == "" {
 		// TODO: defaults to "1.15", in the future (v2) must be removed.

pkg/goformatters/goimports/goimports.go

@@ -2,13 +2,19 @@ package goimports
 
 import (
 	"golang.org/x/tools/imports"
+
+	"github.com/golangci/golangci-lint/pkg/config"
 )
 
 const Name = "goimports"
 
 type Formatter struct{}
 
-func New() *Formatter {
+func New(settings *config.GoImportsSettings) *Formatter {
+	if settings != nil {
+		imports.LocalPrefix = settings.LocalPrefixes
+	}
+
 	return &Formatter{}
 }
 

pkg/goformatters/meta_formatter.go

@@ -23,20 +23,20 @@ func NewMetaFormatter(log logutils.Log, cfg *config.Config, enabledLinters map[s
 	m := &MetaFormatter{log: log}
 
 	if _, ok := enabledLinters[gofmt.Name]; ok {
-		m.formatters = append(m.formatters, gofmt.New(cfg.LintersSettings.Gofmt))
+		m.formatters = append(m.formatters, gofmt.New(&cfg.LintersSettings.Gofmt))
 	}
 
 	if _, ok := enabledLinters[gofumpt.Name]; ok {
-		m.formatters = append(m.formatters, gofumpt.New(cfg.LintersSettings.Gofumpt, cfg.Run.Go))
+		m.formatters = append(m.formatters, gofumpt.New(&cfg.LintersSettings.Gofumpt, cfg.Run.Go))
 	}
 
 	if _, ok := enabledLinters[goimports.Name]; ok {
-		m.formatters = append(m.formatters, goimports.New())
+		m.formatters = append(m.formatters, goimports.New(&cfg.LintersSettings.Goimports))
 	}
 
 	// gci is a last because the only goal of gci is to handle imports.
 	if _, ok := enabledLinters[gci.Name]; ok {
-		formatter, err := gci.New(cfg.LintersSettings.Gci)
+		formatter, err := gci.New(&cfg.LintersSettings.Gci)
 		if err != nil {
 			return nil, fmt.Errorf("gci: creating formatter: %w", err)
 		}